All of lore.kernel.org
 help / color / mirror / Atom feed
From: David Miller <davem@davemloft.net>
To: anisse@astier.eu
Cc: xemul@parallels.com, netdev@vger.kernel.org, eric.dumazet@gmail.com
Subject: Re: [PATCH] net: Default UDP and UNIX diag to 'n'.
Date: Tue, 07 Feb 2012 13:36:17 -0500 (EST)	[thread overview]
Message-ID: <20120207.133617.2073149861534644798.davem@davemloft.net> (raw)
In-Reply-To: <20120207183911.4dd65ac8@destiny.ordissimo>

From: Anisse Astier <anisse@astier.eu>
Date: Tue, 7 Feb 2012 18:39:11 +0100

> On Tue, 07 Feb 2012 12:29:31 -0500 (EST), David Miller <davem@davemloft.net> wrote :
> 
>> From: Pavel Emelyanov <xemul@parallels.com>
>> Date: Tue, 07 Feb 2012 17:37:51 +0400
>> 
>> > @@ -409,7 +409,7 @@ config INET_TCP_DIAG
>> >  
>> >  config INET_UDP_DIAG
>> >  	tristate "UDP: socket monitoring interface"
>> > -	depends on INET_DIAG
>> > +	depends on INET_DIAG && IPV6
>> 
>> This needs to be something like "INET_DIAG && (IPV6 || IPV6=n)"
> 
> Yes, this works better. This is the right solution.
> 
> Tested-by: Anisse Astier <anisse@astier.eu>

The patch was corrupted by your email client, it turned all the
tab characters into spaces, you also didn't write an appropriate
commit message.

I took care of this, but if you plan to submit any patch at all in
the future, even as an "request for comments" and testing, you must
keep these issues in mind.

  reply	other threads:[~2012-02-07 18:36 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-01-07 20:13 [PATCH] net: Default UDP and UNIX diag to 'n' David Miller
2012-02-07 11:12 ` Anisse Astier
2012-02-07 13:37   ` Pavel Emelyanov
2012-02-07 13:51     ` Anisse Astier
2012-02-07 17:29       ` David Miller
2012-02-07 17:29     ` David Miller
2012-02-07 17:39       ` Anisse Astier
2012-02-07 18:36         ` David Miller [this message]
2012-02-07 21:01           ` Anisse Astier

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20120207.133617.2073149861534644798.davem@davemloft.net \
    --to=davem@davemloft.net \
    --cc=anisse@astier.eu \
    --cc=eric.dumazet@gmail.com \
    --cc=netdev@vger.kernel.org \
    --cc=xemul@parallels.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.