* [PATCH] ASoC: wm8994: Fix typo in VMID ramp setting
@ 2012-02-07 19:02 Mark Brown
2012-02-07 19:17 ` Liam Girdwood
0 siblings, 1 reply; 3+ messages in thread
From: Mark Brown @ 2012-02-07 19:02 UTC (permalink / raw)
To: Liam Girdwood; +Cc: alsa-devel, patches, Mark Brown
The VMID ramp rate is supposed to be 3b, not 0x11. Fix that.
Signed-off-by: Mark Brown <broonie@opensource.wolfsonmicro.com>
---
sound/soc/codecs/wm8994.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/sound/soc/codecs/wm8994.c b/sound/soc/codecs/wm8994.c
index 81795eb..b75a652 100644
--- a/sound/soc/codecs/wm8994.c
+++ b/sound/soc/codecs/wm8994.c
@@ -785,7 +785,7 @@ static void vmid_reference(struct snd_soc_codec *codec)
WM8994_VMID_RAMP_MASK,
WM8994_STARTUP_BIAS_ENA |
WM8994_VMID_BUF_ENA |
- (0x11 << WM8994_VMID_RAMP_SHIFT));
+ (0x3 << WM8994_VMID_RAMP_SHIFT));
/* Main bias enable, VMID=2x40k */
snd_soc_update_bits(codec, WM8994_POWER_MANAGEMENT_1,
--
1.7.9.rc1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] ASoC: wm8994: Fix typo in VMID ramp setting
2012-02-07 19:02 [PATCH] ASoC: wm8994: Fix typo in VMID ramp setting Mark Brown
@ 2012-02-07 19:17 ` Liam Girdwood
2012-02-07 19:20 ` Mark Brown
0 siblings, 1 reply; 3+ messages in thread
From: Liam Girdwood @ 2012-02-07 19:17 UTC (permalink / raw)
To: Mark Brown; +Cc: alsa-devel, patches
On Tue, 2012-02-07 at 19:02 +0000, Mark Brown wrote:
> The VMID ramp rate is supposed to be 3b, not 0x11. Fix that.
>
> Signed-off-by: Mark Brown <broonie@opensource.wolfsonmicro.com>
> ---
> sound/soc/codecs/wm8994.c | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/sound/soc/codecs/wm8994.c b/sound/soc/codecs/wm8994.c
> index 81795eb..b75a652 100644
> --- a/sound/soc/codecs/wm8994.c
> +++ b/sound/soc/codecs/wm8994.c
> @@ -785,7 +785,7 @@ static void vmid_reference(struct snd_soc_codec *codec)
> WM8994_VMID_RAMP_MASK,
> WM8994_STARTUP_BIAS_ENA |
> WM8994_VMID_BUF_ENA |
> - (0x11 << WM8994_VMID_RAMP_SHIFT));
> + (0x3 << WM8994_VMID_RAMP_SHIFT));
The commit message says 3b, so maybe a typo ?
Liam
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] ASoC: wm8994: Fix typo in VMID ramp setting
2012-02-07 19:17 ` Liam Girdwood
@ 2012-02-07 19:20 ` Mark Brown
0 siblings, 0 replies; 3+ messages in thread
From: Mark Brown @ 2012-02-07 19:20 UTC (permalink / raw)
To: Liam Girdwood; +Cc: alsa-devel, patches
On Tue, Feb 07, 2012 at 07:17:02PM +0000, Liam Girdwood wrote:
> The commit message says 3b, so maybe a typo ?
In the commit message, got the binary and the hex the wrong way round.
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2012-02-07 19:20 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2012-02-07 19:02 [PATCH] ASoC: wm8994: Fix typo in VMID ramp setting Mark Brown
2012-02-07 19:17 ` Liam Girdwood
2012-02-07 19:20 ` Mark Brown
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.