From: Felipe Balbi <balbi@ti.com>
To: Luciano Coelho <coelho@ti.com>
Cc: tony@atomide.com, linux@arm.linux.org.uk,
linux-omap@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org, Tero Kristo <t-kristo@ti.com>
Subject: Re: [PATCH 3.3] OMAP4: PRM: fix build breakage when CONFIG_OF is not defined
Date: Wed, 8 Feb 2012 13:03:18 +0200 [thread overview]
Message-ID: <20120208110318.GC16334@legolas.emea.dhcp.ti.com> (raw)
In-Reply-To: <1328698752-18756-1-git-send-email-coelho@ti.com>
[-- Attachment #1: Type: text/plain, Size: 1440 bytes --]
On Wed, Feb 08, 2012 at 12:59:12PM +0200, Luciano Coelho wrote:
> Since 3.3-rc1, prm44xx.c build breaks if CONFIG_OF is not set:
>
> arch/arm/mach-omap2/prm44xx.c:41: error: 'OMAP44XX_IRQ_PRCM' undeclared here (not in a function)
> make[1]: *** [arch/arm/mach-omap2/prm44xx.o] Error 1
>
> This is because of a missing include, which is added indirectly if
> CONFIG_OF is defined. This problem was introduced in commit
> 2f31b51659c2d8315ea2888ba5b93076febe672b
same as previous patch. Abbreviated commit and commit subject.
> Cc: Tero Kristo <t-kristo@ti.com>
> Signed-off-by: Luciano Coelho <coelho@ti.com>
Reviewed-by: Felipe Balbi <balbi@ti.com>
> ---
> arch/arm/mach-omap2/prm44xx.c | 1 +
> 1 files changed, 1 insertions(+), 0 deletions(-)
>
> diff --git a/arch/arm/mach-omap2/prm44xx.c b/arch/arm/mach-omap2/prm44xx.c
> index 33dd655..f2e06ad 100644
> --- a/arch/arm/mach-omap2/prm44xx.c
> +++ b/arch/arm/mach-omap2/prm44xx.c
> @@ -20,6 +20,7 @@
> #include "common.h"
> #include <plat/cpu.h>
> #include <plat/prcm.h>
> +#include <plat/irqs.h>
>
> #include "vp.h"
> #include "prm44xx.h"
> --
> 1.7.5.4
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
> Please read the FAQ at http://www.tux.org/lkml/
--
balbi
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 836 bytes --]
WARNING: multiple messages have this Message-ID (diff)
From: Felipe Balbi <balbi@ti.com>
To: Luciano Coelho <coelho@ti.com>
Cc: linux@arm.linux.org.uk, tony@atomide.com,
linux-kernel@vger.kernel.org, Tero Kristo <t-kristo@ti.com>,
linux-omap@vger.kernel.org, linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH 3.3] OMAP4: PRM: fix build breakage when CONFIG_OF is not defined
Date: Wed, 8 Feb 2012 13:03:18 +0200 [thread overview]
Message-ID: <20120208110318.GC16334@legolas.emea.dhcp.ti.com> (raw)
In-Reply-To: <1328698752-18756-1-git-send-email-coelho@ti.com>
[-- Attachment #1.1: Type: text/plain, Size: 1440 bytes --]
On Wed, Feb 08, 2012 at 12:59:12PM +0200, Luciano Coelho wrote:
> Since 3.3-rc1, prm44xx.c build breaks if CONFIG_OF is not set:
>
> arch/arm/mach-omap2/prm44xx.c:41: error: 'OMAP44XX_IRQ_PRCM' undeclared here (not in a function)
> make[1]: *** [arch/arm/mach-omap2/prm44xx.o] Error 1
>
> This is because of a missing include, which is added indirectly if
> CONFIG_OF is defined. This problem was introduced in commit
> 2f31b51659c2d8315ea2888ba5b93076febe672b
same as previous patch. Abbreviated commit and commit subject.
> Cc: Tero Kristo <t-kristo@ti.com>
> Signed-off-by: Luciano Coelho <coelho@ti.com>
Reviewed-by: Felipe Balbi <balbi@ti.com>
> ---
> arch/arm/mach-omap2/prm44xx.c | 1 +
> 1 files changed, 1 insertions(+), 0 deletions(-)
>
> diff --git a/arch/arm/mach-omap2/prm44xx.c b/arch/arm/mach-omap2/prm44xx.c
> index 33dd655..f2e06ad 100644
> --- a/arch/arm/mach-omap2/prm44xx.c
> +++ b/arch/arm/mach-omap2/prm44xx.c
> @@ -20,6 +20,7 @@
> #include "common.h"
> #include <plat/cpu.h>
> #include <plat/prcm.h>
> +#include <plat/irqs.h>
>
> #include "vp.h"
> #include "prm44xx.h"
> --
> 1.7.5.4
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
> Please read the FAQ at http://www.tux.org/lkml/
--
balbi
[-- Attachment #1.2: Digital signature --]
[-- Type: application/pgp-signature, Size: 836 bytes --]
[-- Attachment #2: Type: text/plain, Size: 176 bytes --]
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
WARNING: multiple messages have this Message-ID (diff)
From: balbi@ti.com (Felipe Balbi)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 3.3] OMAP4: PRM: fix build breakage when CONFIG_OF is not defined
Date: Wed, 8 Feb 2012 13:03:18 +0200 [thread overview]
Message-ID: <20120208110318.GC16334@legolas.emea.dhcp.ti.com> (raw)
In-Reply-To: <1328698752-18756-1-git-send-email-coelho@ti.com>
On Wed, Feb 08, 2012 at 12:59:12PM +0200, Luciano Coelho wrote:
> Since 3.3-rc1, prm44xx.c build breaks if CONFIG_OF is not set:
>
> arch/arm/mach-omap2/prm44xx.c:41: error: 'OMAP44XX_IRQ_PRCM' undeclared here (not in a function)
> make[1]: *** [arch/arm/mach-omap2/prm44xx.o] Error 1
>
> This is because of a missing include, which is added indirectly if
> CONFIG_OF is defined. This problem was introduced in commit
> 2f31b51659c2d8315ea2888ba5b93076febe672b
same as previous patch. Abbreviated commit and commit subject.
> Cc: Tero Kristo <t-kristo@ti.com>
> Signed-off-by: Luciano Coelho <coelho@ti.com>
Reviewed-by: Felipe Balbi <balbi@ti.com>
> ---
> arch/arm/mach-omap2/prm44xx.c | 1 +
> 1 files changed, 1 insertions(+), 0 deletions(-)
>
> diff --git a/arch/arm/mach-omap2/prm44xx.c b/arch/arm/mach-omap2/prm44xx.c
> index 33dd655..f2e06ad 100644
> --- a/arch/arm/mach-omap2/prm44xx.c
> +++ b/arch/arm/mach-omap2/prm44xx.c
> @@ -20,6 +20,7 @@
> #include "common.h"
> #include <plat/cpu.h>
> #include <plat/prcm.h>
> +#include <plat/irqs.h>
>
> #include "vp.h"
> #include "prm44xx.h"
> --
> 1.7.5.4
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
> the body of a message to majordomo at vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
> Please read the FAQ at http://www.tux.org/lkml/
--
balbi
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 836 bytes
Desc: Digital signature
URL: <http://lists.infradead.org/pipermail/linux-arm-kernel/attachments/20120208/7e7e7f0b/attachment.sig>
next prev parent reply other threads:[~2012-02-08 11:03 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-02-08 10:59 [PATCH 3.3] OMAP4: PRM: fix build breakage when CONFIG_OF is not defined Luciano Coelho
2012-02-08 10:59 ` Luciano Coelho
2012-02-08 11:03 ` Felipe Balbi [this message]
2012-02-08 11:03 ` Felipe Balbi
2012-02-08 11:03 ` Felipe Balbi
2012-02-08 11:05 ` Luciano Coelho
2012-02-08 11:05 ` Luciano Coelho
2012-02-08 11:50 ` Sergei Shtylyov
2012-02-08 11:50 ` Sergei Shtylyov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120208110318.GC16334@legolas.emea.dhcp.ti.com \
--to=balbi@ti.com \
--cc=coelho@ti.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-omap@vger.kernel.org \
--cc=linux@arm.linux.org.uk \
--cc=t-kristo@ti.com \
--cc=tony@atomide.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.