From: Gleb Natapov <gleb@redhat.com>
To: Gerd Hoffmann <kraxel@redhat.com>
Cc: xen-devel@lists.xensource.com, qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH v3 1/6] suspend: add infrastructure
Date: Thu, 9 Feb 2012 13:19:28 +0200 [thread overview]
Message-ID: <20120209111928.GH18866@redhat.com> (raw)
In-Reply-To: <4F33A3C1.1080108@redhat.com>
On Thu, Feb 09, 2012 at 11:45:21AM +0100, Gerd Hoffmann wrote:
> On 02/09/12 09:48, Gleb Natapov wrote:
> > On Wed, Feb 08, 2012 at 12:00:14PM +0100, Gerd Hoffmann wrote:
> >> * qemu_system_wakeup_request is supposed to be called on events which
> >> should wake up the guest.
> >>
> > qemu_system_wakeup_request() should get wakeup source as a parameter.
> > There are ways to report it to a guest.
>
> Can we do that incrementally, when we actually implement the guest
> reporting?
>
What do you mean by "when we actually implement the guest
reporting"? The guest reporting is part of ACPI spec and implemented
by all relevant guests. I think that adding wakeup source parameter to
qemu_system_wakeup_request() and reporting RTC_STS and PWRBTN_STS should
not complicate your patch series to much. I agree that DSDT magic required
by other devices can wait for later.
--
Gleb.
WARNING: multiple messages have this Message-ID (diff)
From: Gleb Natapov <gleb@redhat.com>
To: Gerd Hoffmann <kraxel@redhat.com>
Cc: xen-devel@lists.xensource.com, qemu-devel@nongnu.org
Subject: Re: [PATCH v3 1/6] suspend: add infrastructure
Date: Thu, 9 Feb 2012 13:19:28 +0200 [thread overview]
Message-ID: <20120209111928.GH18866@redhat.com> (raw)
In-Reply-To: <4F33A3C1.1080108@redhat.com>
On Thu, Feb 09, 2012 at 11:45:21AM +0100, Gerd Hoffmann wrote:
> On 02/09/12 09:48, Gleb Natapov wrote:
> > On Wed, Feb 08, 2012 at 12:00:14PM +0100, Gerd Hoffmann wrote:
> >> * qemu_system_wakeup_request is supposed to be called on events which
> >> should wake up the guest.
> >>
> > qemu_system_wakeup_request() should get wakeup source as a parameter.
> > There are ways to report it to a guest.
>
> Can we do that incrementally, when we actually implement the guest
> reporting?
>
What do you mean by "when we actually implement the guest
reporting"? The guest reporting is part of ACPI spec and implemented
by all relevant guests. I think that adding wakeup source parameter to
qemu_system_wakeup_request() and reporting RTC_STS and PWRBTN_STS should
not complicate your patch series to much. I agree that DSDT magic required
by other devices can wait for later.
--
Gleb.
next prev parent reply other threads:[~2012-02-09 11:19 UTC|newest]
Thread overview: 58+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-02-08 11:00 [Qemu-devel] [PATCH v3 0/6] initial suspend support Gerd Hoffmann
2012-02-08 11:00 ` Gerd Hoffmann
2012-02-08 11:00 ` [Qemu-devel] [PATCH v3 1/6] suspend: add infrastructure Gerd Hoffmann
2012-02-08 11:00 ` Gerd Hoffmann
2012-02-09 8:48 ` [Qemu-devel] " Gleb Natapov
2012-02-09 8:48 ` Gleb Natapov
2012-02-09 10:45 ` [Qemu-devel] " Gerd Hoffmann
2012-02-09 10:45 ` Gerd Hoffmann
2012-02-09 11:19 ` Gleb Natapov [this message]
2012-02-09 11:19 ` Gleb Natapov
2012-02-09 12:02 ` [Qemu-devel] " Gerd Hoffmann
2012-02-09 12:02 ` Gerd Hoffmann
2012-02-09 12:37 ` [Qemu-devel] " Gleb Natapov
2012-02-09 12:37 ` Gleb Natapov
2012-02-09 12:46 ` [Qemu-devel] " Gerd Hoffmann
2012-02-09 12:46 ` Gerd Hoffmann
2012-02-09 13:17 ` [Qemu-devel] " Gleb Natapov
2012-02-09 13:17 ` Gleb Natapov
2012-02-09 13:29 ` [Qemu-devel] " Gerd Hoffmann
2012-02-09 13:29 ` Gerd Hoffmann
2012-02-09 16:00 ` [Qemu-devel] " Gerd Hoffmann
2012-02-09 16:00 ` Gerd Hoffmann
2012-02-09 16:05 ` [Qemu-devel] " Gleb Natapov
2012-02-09 16:05 ` Gleb Natapov
2012-02-08 11:00 ` [Qemu-devel] [PATCH v3 2/6] suspend: switch acpi s3 to new infrastructure Gerd Hoffmann
2012-02-08 11:00 ` Gerd Hoffmann
2012-02-09 8:53 ` [Qemu-devel] " Gleb Natapov
2012-02-09 8:53 ` Gleb Natapov
2012-02-09 10:51 ` [Qemu-devel] " Gerd Hoffmann
2012-02-09 10:51 ` Gerd Hoffmann
2012-02-09 11:14 ` [Qemu-devel] " Gleb Natapov
2012-02-09 11:14 ` Gleb Natapov
2012-02-09 11:13 ` [Qemu-devel] [Xen-devel] " Stefano Stabellini
2012-02-09 11:13 ` Stefano Stabellini
2012-02-09 11:17 ` [Qemu-devel] " Paolo Bonzini
2012-02-09 11:17 ` Paolo Bonzini
2012-02-09 12:31 ` [Qemu-devel] " Gleb Natapov
2012-02-09 12:31 ` Gleb Natapov
2012-02-09 12:47 ` [Qemu-devel] " Paolo Bonzini
2012-02-09 12:47 ` Paolo Bonzini
2012-02-09 12:53 ` [Qemu-devel] " Gleb Natapov
2012-02-09 12:53 ` Gleb Natapov
2012-02-08 11:00 ` [Qemu-devel] [PATCH v3 3/6] suspend: add system_wakeup monitor command Gerd Hoffmann
2012-02-08 11:00 ` Gerd Hoffmann
2012-02-09 8:54 ` [Qemu-devel] " Gleb Natapov
2012-02-09 8:54 ` Gleb Natapov
2012-02-08 11:00 ` [Qemu-devel] [PATCH v3 4/6] suspend: make ps/2 devices wakeup the guest Gerd Hoffmann
2012-02-08 11:00 ` Gerd Hoffmann
2012-02-08 11:00 ` [Qemu-devel] [PATCH v3 5/6] suspend: make serial ports " Gerd Hoffmann
2012-02-08 11:00 ` Gerd Hoffmann
2012-02-08 11:00 ` [Qemu-devel] [PATCH v3 6/6] suspend: make rtc alarm " Gerd Hoffmann
2012-02-08 11:00 ` Gerd Hoffmann
2012-02-09 8:56 ` [Qemu-devel] " Gleb Natapov
2012-02-09 8:56 ` Gleb Natapov
2012-02-09 12:00 ` [Qemu-devel] " Gerd Hoffmann
2012-02-09 12:00 ` Gerd Hoffmann
2012-02-09 12:24 ` [Qemu-devel] " Gleb Natapov
2012-02-09 12:24 ` Gleb Natapov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120209111928.GH18866@redhat.com \
--to=gleb@redhat.com \
--cc=kraxel@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=xen-devel@lists.xensource.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.