* Build fail in hugetlbpage.c with linux-next and mpc85xx_defconfig
@ 2012-02-15 23:08 ` Michael Neuling
0 siblings, 0 replies; 21+ messages in thread
From: Michael Neuling @ 2012-02-15 23:08 UTC (permalink / raw)
To: galak, Becky Bruce; +Cc: linux-next, linuxppc-dev
Becky,
This has been broken in linux-next for a while. Looks like a merge
issue but you were the last to touch it...
arch/powerpc/mm/hugetlbpage.c: In function 'reserve_hugetlb_gpages':
arch/powerpc/mm/hugetlbpage.c:313: error: passing argument 5 of 'parse_args' makes integer from pointer without a cast
include/linux/moduleparam.h:317: note: expected 's16' but argument is of type 'int (*)(char *, char *)'
arch/powerpc/mm/hugetlbpage.c:313: error: too few arguments to function 'parse_args'
Mikey
^ permalink raw reply [flat|nested] 21+ messages in thread
* Build fail in hugetlbpage.c with linux-next and mpc85xx_defconfig
@ 2012-02-15 23:08 ` Michael Neuling
0 siblings, 0 replies; 21+ messages in thread
From: Michael Neuling @ 2012-02-15 23:08 UTC (permalink / raw)
To: galak, Becky Bruce; +Cc: linuxppc-dev, linux-next
Becky,
This has been broken in linux-next for a while. Looks like a merge
issue but you were the last to touch it...
arch/powerpc/mm/hugetlbpage.c: In function 'reserve_hugetlb_gpages':
arch/powerpc/mm/hugetlbpage.c:313: error: passing argument 5 of 'parse_args' makes integer from pointer without a cast
include/linux/moduleparam.h:317: note: expected 's16' but argument is of type 'int (*)(char *, char *)'
arch/powerpc/mm/hugetlbpage.c:313: error: too few arguments to function 'parse_args'
Mikey
^ permalink raw reply [flat|nested] 21+ messages in thread
* [PATCH] powerpc/hugepage: Fix missing header file for parse_args
2012-02-15 23:08 ` Michael Neuling
@ 2012-02-15 23:28 ` Matthew McClintock
-1 siblings, 0 replies; 21+ messages in thread
From: Matthew McClintock @ 2012-02-15 23:28 UTC (permalink / raw)
To: linuxppc-dev; +Cc: linux-next
This seems to fix the following issue:
arch/powerpc/mm/hugetlbpage.c: In function 'reserve_hugetlb_gpages':
arch/powerpc/mm/hugetlbpage.c:313: error: passing argument 5 of 'parse_args' makes integer from pointer without a cast
include/linux/moduleparam.h:317: note: expected 's16' but argument is of type 'int (*)(char *, char *)'
arch/powerpc/mm/hugetlbpage.c:313: error: too few arguments to function 'parse_args'
Signed-off-by: Matthew McClintock <msm@freescale.com>
---
arch/powerpc/mm/hugetlbpage.c | 1 +
1 files changed, 1 insertions(+), 0 deletions(-)
diff --git a/arch/powerpc/mm/hugetlbpage.c b/arch/powerpc/mm/hugetlbpage.c
index 79c575d..a8b3cc7 100644
--- a/arch/powerpc/mm/hugetlbpage.c
+++ b/arch/powerpc/mm/hugetlbpage.c
@@ -15,6 +15,7 @@
#include <linux/of_fdt.h>
#include <linux/memblock.h>
#include <linux/bootmem.h>
+#include <linux/moduleparam.h>
#include <asm/pgtable.h>
#include <asm/pgalloc.h>
#include <asm/tlb.h>
--
1.7.6.1
^ permalink raw reply related [flat|nested] 21+ messages in thread
* [PATCH] powerpc/hugepage: Fix missing header file for parse_args
@ 2012-02-15 23:28 ` Matthew McClintock
0 siblings, 0 replies; 21+ messages in thread
From: Matthew McClintock @ 2012-02-15 23:28 UTC (permalink / raw)
To: linuxppc-dev; +Cc: linux-next
This seems to fix the following issue:
arch/powerpc/mm/hugetlbpage.c: In function 'reserve_hugetlb_gpages':
arch/powerpc/mm/hugetlbpage.c:313: error: passing argument 5 of 'parse_args' makes integer from pointer without a cast
include/linux/moduleparam.h:317: note: expected 's16' but argument is of type 'int (*)(char *, char *)'
arch/powerpc/mm/hugetlbpage.c:313: error: too few arguments to function 'parse_args'
Signed-off-by: Matthew McClintock <msm@freescale.com>
---
arch/powerpc/mm/hugetlbpage.c | 1 +
1 files changed, 1 insertions(+), 0 deletions(-)
diff --git a/arch/powerpc/mm/hugetlbpage.c b/arch/powerpc/mm/hugetlbpage.c
index 79c575d..a8b3cc7 100644
--- a/arch/powerpc/mm/hugetlbpage.c
+++ b/arch/powerpc/mm/hugetlbpage.c
@@ -15,6 +15,7 @@
#include <linux/of_fdt.h>
#include <linux/memblock.h>
#include <linux/bootmem.h>
+#include <linux/moduleparam.h>
#include <asm/pgtable.h>
#include <asm/pgalloc.h>
#include <asm/tlb.h>
--
1.7.6.1
^ permalink raw reply related [flat|nested] 21+ messages in thread
* Re: Build fail in hugetlbpage.c with linux-next and mpc85xx_defconfig
2012-02-15 23:08 ` Michael Neuling
@ 2012-02-15 23:32 ` McClintock Matthew-B29882
-1 siblings, 0 replies; 21+ messages in thread
From: McClintock Matthew-B29882 @ 2012-02-15 23:32 UTC (permalink / raw)
To: Michael Neuling; +Cc: galak, Becky Bruce, linuxppc-dev, linux-next
On Wed, Feb 15, 2012 at 11:08 PM, Michael Neuling <mikey@neuling.org> wrote:
> Becky,
>
> This has been broken in linux-next for a while. Looks like a merge
> issue but you were the last to touch it...
>
> arch/powerpc/mm/hugetlbpage.c: In function 'reserve_hugetlb_gpages':
> arch/powerpc/mm/hugetlbpage.c:313: error: passing argument 5 of 'parse_args' makes integer from pointer without a cast
> include/linux/moduleparam.h:317: note: expected 's16' but argument is of type 'int (*)(char *, char *)'
> arch/powerpc/mm/hugetlbpage.c:313: error: too few arguments to function 'parse_args'
A suggest fix has been submitted.
-M
^ permalink raw reply [flat|nested] 21+ messages in thread
* Re: Build fail in hugetlbpage.c with linux-next and mpc85xx_defconfig
@ 2012-02-15 23:32 ` McClintock Matthew-B29882
0 siblings, 0 replies; 21+ messages in thread
From: McClintock Matthew-B29882 @ 2012-02-15 23:32 UTC (permalink / raw)
To: Michael Neuling; +Cc: linuxppc-dev, linux-next
On Wed, Feb 15, 2012 at 11:08 PM, Michael Neuling <mikey@neuling.org> wrote=
:
> Becky,
>
> This has been broken in linux-next for a while. =A0Looks like a merge
> issue but you were the last to touch it...
>
> arch/powerpc/mm/hugetlbpage.c: In function 'reserve_hugetlb_gpages':
> arch/powerpc/mm/hugetlbpage.c:313: error: passing argument 5 of 'parse_ar=
gs' makes integer from pointer without a cast
> include/linux/moduleparam.h:317: note: expected 's16' but argument is of =
type 'int (*)(char *, char *)'
> arch/powerpc/mm/hugetlbpage.c:313: error: too few arguments to function '=
parse_args'
A suggest fix has been submitted.
-M=
^ permalink raw reply [flat|nested] 21+ messages in thread
* Re: Build fail in hugetlbpage.c with linux-next and mpc85xx_defconfig
2012-02-15 23:32 ` McClintock Matthew-B29882
@ 2012-02-15 23:37 ` Michael Neuling
-1 siblings, 0 replies; 21+ messages in thread
From: Michael Neuling @ 2012-02-15 23:37 UTC (permalink / raw)
To: McClintock Matthew-B29882; +Cc: galak, Becky Bruce, linuxppc-dev, linux-next
> > Becky,
> >
> > This has been broken in linux-next for a while. =A0Looks like a merge
> > issue but you were the last to touch it...
> >
> > arch/powerpc/mm/hugetlbpage.c: In function 'reserve_hugetlb_gpages':
> > arch/powerpc/mm/hugetlbpage.c:313: error: passing argument 5 of 'parse_ar=
> gs' makes integer from pointer without a cast
> > include/linux/moduleparam.h:317: note: expected 's16' but argument is of =
> type 'int (*)(char *, char *)'
> > arch/powerpc/mm/hugetlbpage.c:313: error: too few arguments to function '=
> parse_args'
>
> A suggest fix has been submitted.
Do you have a link? Which tree is it going in?
Mikey
^ permalink raw reply [flat|nested] 21+ messages in thread
* Re: Build fail in hugetlbpage.c with linux-next and mpc85xx_defconfig
@ 2012-02-15 23:37 ` Michael Neuling
0 siblings, 0 replies; 21+ messages in thread
From: Michael Neuling @ 2012-02-15 23:37 UTC (permalink / raw)
To: McClintock Matthew-B29882; +Cc: linuxppc-dev, linux-next
> > Becky,
> >
> > This has been broken in linux-next for a while. =A0Looks like a merge
> > issue but you were the last to touch it...
> >
> > arch/powerpc/mm/hugetlbpage.c: In function 'reserve_hugetlb_gpages':
> > arch/powerpc/mm/hugetlbpage.c:313: error: passing argument 5 of 'parse_ar=
> gs' makes integer from pointer without a cast
> > include/linux/moduleparam.h:317: note: expected 's16' but argument is of =
> type 'int (*)(char *, char *)'
> > arch/powerpc/mm/hugetlbpage.c:313: error: too few arguments to function '=
> parse_args'
>
> A suggest fix has been submitted.
Do you have a link? Which tree is it going in?
Mikey
^ permalink raw reply [flat|nested] 21+ messages in thread
* Re: Build fail in hugetlbpage.c with linux-next and mpc85xx_defconfig
2012-02-15 23:37 ` Michael Neuling
@ 2012-02-15 23:40 ` McClintock Matthew-B29882
-1 siblings, 0 replies; 21+ messages in thread
From: McClintock Matthew-B29882 @ 2012-02-15 23:40 UTC (permalink / raw)
To: Michael Neuling; +Cc: McClintock Matthew-B29882, linuxppc-dev, linux-next
On Wed, Feb 15, 2012 at 11:37 PM, Michael Neuling <mikey@neuling.org> wrote:
>> > Becky,
>> >
>> > This has been broken in linux-next for a while. =A0Looks like a merge
>> > issue but you were the last to touch it...
>> >
>> > arch/powerpc/mm/hugetlbpage.c: In function 'reserve_hugetlb_gpages':
>> > arch/powerpc/mm/hugetlbpage.c:313: error: passing argument 5 of 'parse_ar=
>> gs' makes integer from pointer without a cast
>> > include/linux/moduleparam.h:317: note: expected 's16' but argument is of =
>> type 'int (*)(char *, char *)'
>> > arch/powerpc/mm/hugetlbpage.c:313: error: too few arguments to function '=
>> parse_args'
>>
>> A suggest fix has been submitted.
>
> Do you have a link? Which tree is it going in?
http://lists.ozlabs.org/pipermail/linuxppc-dev/2012-February/095903.html
I just sent it. I'm not sure who would pick this up. Ideally it would
go in the next release.
-M
^ permalink raw reply [flat|nested] 21+ messages in thread
* Re: Build fail in hugetlbpage.c with linux-next and mpc85xx_defconfig
@ 2012-02-15 23:40 ` McClintock Matthew-B29882
0 siblings, 0 replies; 21+ messages in thread
From: McClintock Matthew-B29882 @ 2012-02-15 23:40 UTC (permalink / raw)
To: Michael Neuling; +Cc: McClintock Matthew-B29882, linuxppc-dev, linux-next
On Wed, Feb 15, 2012 at 11:37 PM, Michael Neuling <mikey@neuling.org> wrote=
:
>> > Becky,
>> >
>> > This has been broken in linux-next for a while. =3DA0Looks like a merg=
e
>> > issue but you were the last to touch it...
>> >
>> > arch/powerpc/mm/hugetlbpage.c: In function 'reserve_hugetlb_gpages':
>> > arch/powerpc/mm/hugetlbpage.c:313: error: passing argument 5 of 'parse=
_ar=3D
>> gs' makes integer from pointer without a cast
>> > include/linux/moduleparam.h:317: note: expected 's16' but argument is =
of =3D
>> type 'int (*)(char *, char *)'
>> > arch/powerpc/mm/hugetlbpage.c:313: error: too few arguments to functio=
n '=3D
>> parse_args'
>>
>> A suggest fix has been submitted.
>
> Do you have a link? =A0Which tree is it going in?
http://lists.ozlabs.org/pipermail/linuxppc-dev/2012-February/095903.html
I just sent it. I'm not sure who would pick this up. Ideally it would
go in the next release.
-M=
^ permalink raw reply [flat|nested] 21+ messages in thread
* Re: Build fail in hugetlbpage.c with linux-next and mpc85xx_defconfig
2012-02-15 23:08 ` Michael Neuling
@ 2012-02-16 0:15 ` Stephen Rothwell
-1 siblings, 0 replies; 21+ messages in thread
From: Stephen Rothwell @ 2012-02-16 0:15 UTC (permalink / raw)
To: Rusty Russell
Cc: Michael Neuling, Pawel Moll, galak, Becky Bruce, linux-next,
linuxppc-dev, McClintock Matthew-B29882
[-- Attachment #1: Type: text/plain, Size: 1316 bytes --]
Hi Rusty,
On Thu, 16 Feb 2012 10:08:41 +1100 Michael Neuling <mikey@neuling.org> wrote:
>
> This has been broken in linux-next for a while. Looks like a merge
> issue but you were the last to touch it...
>
> arch/powerpc/mm/hugetlbpage.c: In function 'reserve_hugetlb_gpages':
> arch/powerpc/mm/hugetlbpage.c:313: error: passing argument 5 of 'parse_args' makes integer from pointer without a cast
> include/linux/moduleparam.h:317: note: expected 's16' but argument is of type 'int (*)(char *, char *)'
> arch/powerpc/mm/hugetlbpage.c:313: error: too few arguments to function 'parse_args'
This was broken by commit b8076966e8e1 ("params: <level>_initcall-like
kernel parameters") from the rr tree which changed the parse_args() API without fixing all
the callers ....
Please add a fix ...
Grep is your friend:
$ git grep -l '\<parse_args(' v3.3-rc1
v3.3-rc1:Documentation/target/tcm_mod_builder.py
v3.3-rc1:arch/powerpc/mm/hugetlbpage.c
v3.3-rc1:arch/x86/tools/insn_sanity.c
v3.3-rc1:arch/x86/tools/test_get_len.c
v3.3-rc1:include/linux/moduleparam.h
v3.3-rc1:init/main.c
v3.3-rc1:kernel/module.c
v3.3-rc1:kernel/params.c
(The Documentation and x86 ones are a false positives, the powerpc one is real)
--
Cheers,
Stephen Rothwell sfr@canb.auug.org.au
[-- Attachment #2: Type: application/pgp-signature, Size: 836 bytes --]
^ permalink raw reply [flat|nested] 21+ messages in thread
* Re: Build fail in hugetlbpage.c with linux-next and mpc85xx_defconfig
@ 2012-02-16 0:15 ` Stephen Rothwell
0 siblings, 0 replies; 21+ messages in thread
From: Stephen Rothwell @ 2012-02-16 0:15 UTC (permalink / raw)
To: Rusty Russell
Cc: Michael Neuling, Pawel Moll, linuxppc-dev, linux-next,
McClintock Matthew-B29882
[-- Attachment #1: Type: text/plain, Size: 1316 bytes --]
Hi Rusty,
On Thu, 16 Feb 2012 10:08:41 +1100 Michael Neuling <mikey@neuling.org> wrote:
>
> This has been broken in linux-next for a while. Looks like a merge
> issue but you were the last to touch it...
>
> arch/powerpc/mm/hugetlbpage.c: In function 'reserve_hugetlb_gpages':
> arch/powerpc/mm/hugetlbpage.c:313: error: passing argument 5 of 'parse_args' makes integer from pointer without a cast
> include/linux/moduleparam.h:317: note: expected 's16' but argument is of type 'int (*)(char *, char *)'
> arch/powerpc/mm/hugetlbpage.c:313: error: too few arguments to function 'parse_args'
This was broken by commit b8076966e8e1 ("params: <level>_initcall-like
kernel parameters") from the rr tree which changed the parse_args() API without fixing all
the callers ....
Please add a fix ...
Grep is your friend:
$ git grep -l '\<parse_args(' v3.3-rc1
v3.3-rc1:Documentation/target/tcm_mod_builder.py
v3.3-rc1:arch/powerpc/mm/hugetlbpage.c
v3.3-rc1:arch/x86/tools/insn_sanity.c
v3.3-rc1:arch/x86/tools/test_get_len.c
v3.3-rc1:include/linux/moduleparam.h
v3.3-rc1:init/main.c
v3.3-rc1:kernel/module.c
v3.3-rc1:kernel/params.c
(The Documentation and x86 ones are a false positives, the powerpc one is real)
--
Cheers,
Stephen Rothwell sfr@canb.auug.org.au
[-- Attachment #2: Type: application/pgp-signature, Size: 836 bytes --]
^ permalink raw reply [flat|nested] 21+ messages in thread
* Re: Build fail in hugetlbpage.c with linux-next and mpc85xx_defconfig
2012-02-16 0:15 ` Stephen Rothwell
@ 2012-02-16 2:14 ` Stephen Rothwell
-1 siblings, 0 replies; 21+ messages in thread
From: Stephen Rothwell @ 2012-02-16 2:14 UTC (permalink / raw)
To: Rusty Russell
Cc: Michael Neuling, Pawel Moll, galak, Becky Bruce, linux-next,
linuxppc-dev, McClintock Matthew-B29882
[-- Attachment #1: Type: text/plain, Size: 469 bytes --]
Hi Rusty,
On Thu, 16 Feb 2012 11:15:13 +1100 Stephen Rothwell <sfr@canb.auug.org.au> wrote:
>
> This was broken by commit b8076966e8e1 ("params: <level>_initcall-like
> kernel parameters") from the rr tree which changed the parse_args() API without fixing all
> the callers ....
I have reverted the above commit (and the following fix one) for today.
--
Cheers,
Stephen Rothwell sfr@canb.auug.org.au
http://www.canb.auug.org.au/~sfr/
[-- Attachment #2: Type: application/pgp-signature, Size: 836 bytes --]
^ permalink raw reply [flat|nested] 21+ messages in thread
* Re: Build fail in hugetlbpage.c with linux-next and mpc85xx_defconfig
@ 2012-02-16 2:14 ` Stephen Rothwell
0 siblings, 0 replies; 21+ messages in thread
From: Stephen Rothwell @ 2012-02-16 2:14 UTC (permalink / raw)
To: Rusty Russell
Cc: Michael Neuling, Pawel Moll, linuxppc-dev, linux-next,
McClintock Matthew-B29882
[-- Attachment #1: Type: text/plain, Size: 469 bytes --]
Hi Rusty,
On Thu, 16 Feb 2012 11:15:13 +1100 Stephen Rothwell <sfr@canb.auug.org.au> wrote:
>
> This was broken by commit b8076966e8e1 ("params: <level>_initcall-like
> kernel parameters") from the rr tree which changed the parse_args() API without fixing all
> the callers ....
I have reverted the above commit (and the following fix one) for today.
--
Cheers,
Stephen Rothwell sfr@canb.auug.org.au
http://www.canb.auug.org.au/~sfr/
[-- Attachment #2: Type: application/pgp-signature, Size: 836 bytes --]
^ permalink raw reply [flat|nested] 21+ messages in thread
* Re: Build fail in hugetlbpage.c with linux-next and mpc85xx_defconfig
2012-02-15 23:40 ` McClintock Matthew-B29882
(?)
@ 2012-02-16 5:01 ` Michael Neuling
2012-02-16 5:03 ` McClintock Matthew-B29882
-1 siblings, 1 reply; 21+ messages in thread
From: Michael Neuling @ 2012-02-16 5:01 UTC (permalink / raw)
To: McClintock Matthew-B29882; +Cc: linuxppc-dev, linux-next
In message <CAEsOVNfOcH+oaxSqw6Cy1suY_9zVDOhQe+v_e-zTwc0M5Q_Wgg@mail.gmail.com>
you wrote:
> On Wed, Feb 15, 2012 at 11:37 PM, Michael Neuling <mikey@neuling.org> wrote:
> >> > Becky,
> >> >
> >> > This has been broken in linux-next for a while. =3DA0Looks like a merge
> >> > issue but you were the last to touch it...
> >> >
> >> > arch/powerpc/mm/hugetlbpage.c: In function 'reserve_hugetlb_gpages':
> >> > arch/powerpc/mm/hugetlbpage.c:313: error: passing argument 5 of 'parse=
> _ar=3D
> >> gs' makes integer from pointer without a cast
> >> > include/linux/moduleparam.h:317: note: expected 's16' but argument is =
> of =3D
> >> type 'int (*)(char *, char *)'
> >> > arch/powerpc/mm/hugetlbpage.c:313: error: too few arguments to functio=
> n '=3D
> >> parse_args'
> >>
> >> A suggest fix has been submitted.
> >
> > Do you have a link? =A0Which tree is it going in?
>
> http://lists.ozlabs.org/pipermail/linuxppc-dev/2012-February/095903.html
>
> I just sent it. I'm not sure who would pick this up. Ideally it would
> go in the next release.
I think that's a different problem, as that's already in next.
sfr posted where problem patch is
Mikey
^ permalink raw reply [flat|nested] 21+ messages in thread
* Re: Build fail in hugetlbpage.c with linux-next and mpc85xx_defconfig
2012-02-16 5:01 ` Michael Neuling
@ 2012-02-16 5:03 ` McClintock Matthew-B29882
0 siblings, 0 replies; 21+ messages in thread
From: McClintock Matthew-B29882 @ 2012-02-16 5:03 UTC (permalink / raw)
To: Michael Neuling; +Cc: McClintock Matthew-B29882, linuxppc-dev, linux-next
[-- Attachment #1.1: Type: text/plain, Size: 1691 bytes --]
On Feb 15, 2012 9:01 PM, "Michael Neuling" <mikey@neuling.org<mailto:mikey@neuling.org>> wrote:
>
> In message <CAEsOVNfOcH+oaxSqw6Cy1suY_9zVDOhQe+v_e-zTwc0M5Q_Wgg@mail.gmail.com<mailto:CAEsOVNfOcH%2BoaxSqw6Cy1suY_9zVDOhQe%2Bv_e-zTwc0M5Q_Wgg@mail.gmail.com>>
> you wrote:
> > On Wed, Feb 15, 2012 at 11:37 PM, Michael Neuling <mikey@neuling.org<mailto:mikey@neuling.org>> wrote:
> > >> > Becky,
> > >> >
> > >> > This has been broken in linux-next for a while. =3DA0Looks like a merge
> > >> > issue but you were the last to touch it...
> > >> >
> > >> > arch/powerpc/mm/hugetlbpage.c: In function 'reserve_hugetlb_gpages':
> > >> > arch/powerpc/mm/hugetlbpage.c:313: error: passing argument 5 of 'parse=
> > _ar=3D
> > >> gs' makes integer from pointer without a cast
> > >> > include/linux/moduleparam.h:317: note: expected 's16' but argument is =
> > of =3D
> > >> type 'int (*)(char *, char *)'
> > >> > arch/powerpc/mm/hugetlbpage.c:313: error: too few arguments to functio=
> > n '=3D
> > >> parse_args'
> > >>
> > >> A suggest fix has been submitted.
> > >
> > > Do you have a link? =A0Which tree is it going in?
> >
> > http://lists.ozlabs.org/pipermail/linuxppc-dev/2012-February/095903.html
> >
> > I just sent it. I'm not sure who would pick this up. Ideally it would
> > go in the next release.
>
> I think that's a different problem, as that's already in next.
>
> sfr posted where problem patch is
>
Ah got it. Thanks.
-M
> Mikey
> _______________________________________________
> Linuxppc-dev mailing list
> Linuxppc-dev@lists.ozlabs.org<mailto:Linuxppc-dev@lists.ozlabs.org>
> https://lists.ozlabs.org/listinfo/linuxppc-dev
[-- Attachment #1.2: Type: text/html, Size: 2545 bytes --]
[-- Attachment #2: Type: text/plain, Size: 150 bytes --]
_______________________________________________
Linuxppc-dev mailing list
Linuxppc-dev@lists.ozlabs.org
https://lists.ozlabs.org/listinfo/linuxppc-dev
^ permalink raw reply [flat|nested] 21+ messages in thread
* Re: Build fail in hugetlbpage.c with linux-next and mpc85xx_defconfig
@ 2012-02-16 5:03 ` McClintock Matthew-B29882
0 siblings, 0 replies; 21+ messages in thread
From: McClintock Matthew-B29882 @ 2012-02-16 5:03 UTC (permalink / raw)
To: Michael Neuling; +Cc: McClintock Matthew-B29882, linuxppc-dev, linux-next
[-- Attachment #1: Type: text/plain, Size: 1691 bytes --]
On Feb 15, 2012 9:01 PM, "Michael Neuling" <mikey@neuling.org<mailto:mikey@neuling.org>> wrote:
>
> In message <CAEsOVNfOcH+oaxSqw6Cy1suY_9zVDOhQe+v_e-zTwc0M5Q_Wgg@mail.gmail.com<mailto:CAEsOVNfOcH%2BoaxSqw6Cy1suY_9zVDOhQe%2Bv_e-zTwc0M5Q_Wgg@mail.gmail.com>>
> you wrote:
> > On Wed, Feb 15, 2012 at 11:37 PM, Michael Neuling <mikey@neuling.org<mailto:mikey@neuling.org>> wrote:
> > >> > Becky,
> > >> >
> > >> > This has been broken in linux-next for a while. =3DA0Looks like a merge
> > >> > issue but you were the last to touch it...
> > >> >
> > >> > arch/powerpc/mm/hugetlbpage.c: In function 'reserve_hugetlb_gpages':
> > >> > arch/powerpc/mm/hugetlbpage.c:313: error: passing argument 5 of 'parse=
> > _ar=3D
> > >> gs' makes integer from pointer without a cast
> > >> > include/linux/moduleparam.h:317: note: expected 's16' but argument is =
> > of =3D
> > >> type 'int (*)(char *, char *)'
> > >> > arch/powerpc/mm/hugetlbpage.c:313: error: too few arguments to functio=
> > n '=3D
> > >> parse_args'
> > >>
> > >> A suggest fix has been submitted.
> > >
> > > Do you have a link? =A0Which tree is it going in?
> >
> > http://lists.ozlabs.org/pipermail/linuxppc-dev/2012-February/095903.html
> >
> > I just sent it. I'm not sure who would pick this up. Ideally it would
> > go in the next release.
>
> I think that's a different problem, as that's already in next.
>
> sfr posted where problem patch is
>
Ah got it. Thanks.
-M
> Mikey
> _______________________________________________
> Linuxppc-dev mailing list
> Linuxppc-dev@lists.ozlabs.org<mailto:Linuxppc-dev@lists.ozlabs.org>
> https://lists.ozlabs.org/listinfo/linuxppc-dev
[-- Attachment #2: Type: text/html, Size: 2545 bytes --]
^ permalink raw reply [flat|nested] 21+ messages in thread
* [PATCH] params: Fix parse_args() use in PowerPC's reserve_hugetlb_gpages()
2012-02-16 0:15 ` Stephen Rothwell
@ 2012-02-17 16:08 ` Pawel Moll
-1 siblings, 0 replies; 21+ messages in thread
From: Pawel Moll @ 2012-02-17 16:08 UTC (permalink / raw)
To: Rusty Russell
Cc: Michael Neuling, galak, Becky Bruce, linux-next, linuxppc-dev,
McClintock Matthew-B29882, Stephen Rothwell, Pawel Moll
Commit b8076966e8e1 ("params: <level>_initcall-like kernel parameters")
changed the parse_args() API without fixing all the callers. Done now.
Signed-off-by: Pawel Moll <pawel.moll@arm.com>
---
arch/powerpc/mm/hugetlbpage.c | 3 ++-
1 files changed, 2 insertions(+), 1 deletions(-)
diff --git a/arch/powerpc/mm/hugetlbpage.c b/arch/powerpc/mm/hugetlbpage.c
index 57c7465..a3e6287 100644
--- a/arch/powerpc/mm/hugetlbpage.c
+++ b/arch/powerpc/mm/hugetlbpage.c
@@ -310,7 +310,8 @@ void __init reserve_hugetlb_gpages(void)
int i;
strlcpy(cmdline, boot_command_line, COMMAND_LINE_SIZE);
- parse_args("hugetlb gpages", cmdline, NULL, 0, &do_gpage_early_setup);
+ parse_args("hugetlb gpages", cmdline, NULL, 0, 0, 0,
+ &do_gpage_early_setup);
/*
* Walk gpage list in reverse, allocating larger page sizes first.
--
1.7.5.4
^ permalink raw reply related [flat|nested] 21+ messages in thread
* [PATCH] params: Fix parse_args() use in PowerPC's reserve_hugetlb_gpages()
@ 2012-02-17 16:08 ` Pawel Moll
0 siblings, 0 replies; 21+ messages in thread
From: Pawel Moll @ 2012-02-17 16:08 UTC (permalink / raw)
To: Rusty Russell
Cc: Stephen Rothwell, Michael Neuling, Pawel Moll, linuxppc-dev,
linux-next, McClintock Matthew-B29882
Commit b8076966e8e1 ("params: <level>_initcall-like kernel parameters")
changed the parse_args() API without fixing all the callers. Done now.
Signed-off-by: Pawel Moll <pawel.moll@arm.com>
---
arch/powerpc/mm/hugetlbpage.c | 3 ++-
1 files changed, 2 insertions(+), 1 deletions(-)
diff --git a/arch/powerpc/mm/hugetlbpage.c b/arch/powerpc/mm/hugetlbpage.c
index 57c7465..a3e6287 100644
--- a/arch/powerpc/mm/hugetlbpage.c
+++ b/arch/powerpc/mm/hugetlbpage.c
@@ -310,7 +310,8 @@ void __init reserve_hugetlb_gpages(void)
=09int i;
=20
=09strlcpy(cmdline, boot_command_line, COMMAND_LINE_SIZE);
-=09parse_args("hugetlb gpages", cmdline, NULL, 0, &do_gpage_early_setup);
+=09parse_args("hugetlb gpages", cmdline, NULL, 0, 0, 0,
+=09=09=09&do_gpage_early_setup);
=20
=09/*
=09 * Walk gpage list in reverse, allocating larger page sizes first.
--=20
1.7.5.4
^ permalink raw reply related [flat|nested] 21+ messages in thread
* Re: [PATCH] params: Fix parse_args() use in PowerPC's reserve_hugetlb_gpages()
2012-02-17 16:08 ` Pawel Moll
@ 2012-02-20 1:26 ` Rusty Russell
-1 siblings, 0 replies; 21+ messages in thread
From: Rusty Russell @ 2012-02-20 1:26 UTC (permalink / raw)
Cc: Michael Neuling, galak, Becky Bruce, linux-next, linuxppc-dev,
McClintock Matthew-B29882, Stephen Rothwell, Pawel Moll
On Fri, 17 Feb 2012 16:08:36 +0000, Pawel Moll <pawel.moll@arm.com> wrote:
> Commit b8076966e8e1 ("params: <level>_initcall-like kernel parameters")
> changed the parse_args() API without fixing all the callers. Done now.
>
> Signed-off-by: Pawel Moll <pawel.moll@arm.com>
Thanks Stephen, Pawel.
Applied,
Rusty.
^ permalink raw reply [flat|nested] 21+ messages in thread
* Re: [PATCH] params: Fix parse_args() use in PowerPC's reserve_hugetlb_gpages()
@ 2012-02-20 1:26 ` Rusty Russell
0 siblings, 0 replies; 21+ messages in thread
From: Rusty Russell @ 2012-02-20 1:26 UTC (permalink / raw)
To: Pawel Moll
Cc: Stephen Rothwell, Michael Neuling, Pawel Moll, linuxppc-dev,
linux-next, McClintock Matthew-B29882
On Fri, 17 Feb 2012 16:08:36 +0000, Pawel Moll <pawel.moll@arm.com> wrote:
> Commit b8076966e8e1 ("params: <level>_initcall-like kernel parameters")
> changed the parse_args() API without fixing all the callers. Done now.
>
> Signed-off-by: Pawel Moll <pawel.moll@arm.com>
Thanks Stephen, Pawel.
Applied,
Rusty.
^ permalink raw reply [flat|nested] 21+ messages in thread
end of thread, other threads:[~2012-02-20 3:48 UTC | newest]
Thread overview: 21+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2012-02-15 23:08 Build fail in hugetlbpage.c with linux-next and mpc85xx_defconfig Michael Neuling
2012-02-15 23:08 ` Michael Neuling
2012-02-15 23:28 ` [PATCH] powerpc/hugepage: Fix missing header file for parse_args Matthew McClintock
2012-02-15 23:28 ` Matthew McClintock
2012-02-15 23:32 ` Build fail in hugetlbpage.c with linux-next and mpc85xx_defconfig McClintock Matthew-B29882
2012-02-15 23:32 ` McClintock Matthew-B29882
2012-02-15 23:37 ` Michael Neuling
2012-02-15 23:37 ` Michael Neuling
2012-02-15 23:40 ` McClintock Matthew-B29882
2012-02-15 23:40 ` McClintock Matthew-B29882
2012-02-16 5:01 ` Michael Neuling
2012-02-16 5:03 ` McClintock Matthew-B29882
2012-02-16 5:03 ` McClintock Matthew-B29882
2012-02-16 0:15 ` Stephen Rothwell
2012-02-16 0:15 ` Stephen Rothwell
2012-02-16 2:14 ` Stephen Rothwell
2012-02-16 2:14 ` Stephen Rothwell
2012-02-17 16:08 ` [PATCH] params: Fix parse_args() use in PowerPC's reserve_hugetlb_gpages() Pawel Moll
2012-02-17 16:08 ` Pawel Moll
2012-02-20 1:26 ` Rusty Russell
2012-02-20 1:26 ` Rusty Russell
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.