* [PATCH -next] ext4: get rid of compile warning
@ 2012-02-20 12:56 Heiko Carstens
2012-02-20 16:00 ` Randy Dunlap
0 siblings, 1 reply; 3+ messages in thread
From: Heiko Carstens @ 2012-02-20 12:56 UTC (permalink / raw)
To: Theodore Ts'o; +Cc: linux-next
Get rid of this one:
fs/ext4/balloc.c: In function 'ext4_wait_block_bitmap':
fs/ext4/balloc.c:405:3: warning: format '%llu' expects argument of
type 'long long unsigned int', but argument 6 has type 'sector_t' [-Wformat]
Happens because sector_t is u64 (unsigned long long) or unsigned long
dependent on CONFIG_64BIT.
Signed-off-by: Heiko Carstens <heiko.carstens@de.ibm.com>
---
fs/ext4/balloc.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/fs/ext4/balloc.c b/fs/ext4/balloc.c
index 95c87ab..c355890 100644
--- a/fs/ext4/balloc.c
+++ b/fs/ext4/balloc.c
@@ -404,7 +404,7 @@ int ext4_wait_block_bitmap(struct super_block *sb, ext4_group_t block_group,
if (!buffer_uptodate(bh)) {
ext4_error(sb, "Cannot read block bitmap - "
"block_group = %u, block_bitmap = %llu",
- block_group, bh->b_blocknr);
+ block_group, (unsigned long long) bh->b_blocknr);
return 1;
}
/* Panic or remount fs read-only if block bitmap is invalid */
--
1.7.9.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH -next] ext4: get rid of compile warning
2012-02-20 12:56 [PATCH -next] ext4: get rid of compile warning Heiko Carstens
@ 2012-02-20 16:00 ` Randy Dunlap
2012-02-21 3:13 ` Ted Ts'o
0 siblings, 1 reply; 3+ messages in thread
From: Randy Dunlap @ 2012-02-20 16:00 UTC (permalink / raw)
To: Heiko Carstens; +Cc: Theodore Ts'o, linux-next
On 02/20/2012 04:56 AM, Heiko Carstens wrote:
> Get rid of this one:
>
> fs/ext4/balloc.c: In function 'ext4_wait_block_bitmap':
> fs/ext4/balloc.c:405:3: warning: format '%llu' expects argument of
> type 'long long unsigned int', but argument 6 has type 'sector_t' [-Wformat]
>
> Happens because sector_t is u64 (unsigned long long) or unsigned long
> dependent on CONFIG_64BIT.
>
> Signed-off-by: Heiko Carstens<heiko.carstens@de.ibm.com>
I sent the same patch on Jan. 30. I wonder what happened to it?
Acked-by: Randy Dunlap <rdunlap@xenotime.net>
Thanks.
> ---
> fs/ext4/balloc.c | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/fs/ext4/balloc.c b/fs/ext4/balloc.c
> index 95c87ab..c355890 100644
> --- a/fs/ext4/balloc.c
> +++ b/fs/ext4/balloc.c
> @@ -404,7 +404,7 @@ int ext4_wait_block_bitmap(struct super_block *sb, ext4_group_t block_group,
> if (!buffer_uptodate(bh)) {
> ext4_error(sb, "Cannot read block bitmap - "
> "block_group = %u, block_bitmap = %llu",
> - block_group, bh->b_blocknr);
> + block_group, (unsigned long long) bh->b_blocknr);
> return 1;
> }
> /* Panic or remount fs read-only if block bitmap is invalid */
--
~Randy
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH -next] ext4: get rid of compile warning
2012-02-20 16:00 ` Randy Dunlap
@ 2012-02-21 3:13 ` Ted Ts'o
0 siblings, 0 replies; 3+ messages in thread
From: Ted Ts'o @ 2012-02-21 3:13 UTC (permalink / raw)
To: Randy Dunlap; +Cc: Heiko Carstens, linux-next
On Mon, Feb 20, 2012 at 08:00:05AM -0800, Randy Dunlap wrote:
> On 02/20/2012 04:56 AM, Heiko Carstens wrote:
> >Get rid of this one:
> >
> >fs/ext4/balloc.c: In function 'ext4_wait_block_bitmap':
> >fs/ext4/balloc.c:405:3: warning: format '%llu' expects argument of
> > type 'long long unsigned int', but argument 6 has type 'sector_t' [-Wformat]
> >
> >Happens because sector_t is u64 (unsigned long long) or unsigned long
> >dependent on CONFIG_64BIT.
> >
> >Signed-off-by: Heiko Carstens<heiko.carstens@de.ibm.com>
>
> I sent the same patch on Jan. 30. I wonder what happened to it?
>
> Acked-by: Randy Dunlap <rdunlap@xenotime.net>
Applied, thanks. Sorry, Randy for not getting to your patch before
this. I tend to review and apply patches in a fairly bursty fashion.
- Ted
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2012-02-21 3:13 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2012-02-20 12:56 [PATCH -next] ext4: get rid of compile warning Heiko Carstens
2012-02-20 16:00 ` Randy Dunlap
2012-02-21 3:13 ` Ted Ts'o
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.