[PATCH] hda - add id for Atom Cedar Trail HDMI codec

[PATCH] hda - add id for Atom Cedar Trail HDMI codec

[Wu Fengguang]

Signed-off-by: Wu Fengguang <fengguang.wu@intel.com>
---
 sound/pci/hda/patch_hdmi.c |    2 ++
 1 file changed, 2 insertions(+)

--- sound.orig/sound/pci/hda/patch_hdmi.c	2012-02-23 14:51:19.562540743 +0800
+++ sound/sound/pci/hda/patch_hdmi.c	2012-02-23 15:05:51.774522844 +0800
@@ -1913,6 +1913,7 @@ static const struct hda_codec_preset snd
 { .id = 0x80862805, .name = "CougarPoint HDMI",	.patch = patch_generic_hdmi },
 { .id = 0x80862806, .name = "PantherPoint HDMI", .patch = patch_generic_hdmi },
 { .id = 0x808629fb, .name = "Crestline HDMI",	.patch = patch_generic_hdmi },
+{ .id = 0x80862880, .name = "CedarTrail HDMI",	.patch = patch_generic_hdmi },
 {} /* terminator */
 };
 
@@ -1959,6 +1960,7 @@ MODULE_ALIAS("snd-hda-codec-id:80862804"
 MODULE_ALIAS("snd-hda-codec-id:80862805");
 MODULE_ALIAS("snd-hda-codec-id:80862806");
 MODULE_ALIAS("snd-hda-codec-id:808629fb");
+MODULE_ALIAS("snd-hda-codec-id:80862880");
 
 MODULE_LICENSE("GPL");
 MODULE_DESCRIPTION("HDMI HD-audio codec");

Re: [PATCH] hda - add id for Atom Cedar Trail HDMI codec

[Takashi Iwai]

At Thu, 23 Feb 2012 15:07:44 +0800,
Wu Fengguang wrote:
> 
> 
> Signed-off-by: Wu Fengguang <fengguang.wu@intel.com>

Applied, but I sorted the order.  CedarTrail's id is less than
Crestline's id number.


thanks,

Takashi


> ---
>  sound/pci/hda/patch_hdmi.c |    2 ++
>  1 file changed, 2 insertions(+)
> 
> --- sound.orig/sound/pci/hda/patch_hdmi.c	2012-02-23 14:51:19.562540743 +0800
> +++ sound/sound/pci/hda/patch_hdmi.c	2012-02-23 15:05:51.774522844 +0800
> @@ -1913,6 +1913,7 @@ static const struct hda_codec_preset snd
>  { .id = 0x80862805, .name = "CougarPoint HDMI",	.patch = patch_generic_hdmi },
>  { .id = 0x80862806, .name = "PantherPoint HDMI", .patch = patch_generic_hdmi },
>  { .id = 0x808629fb, .name = "Crestline HDMI",	.patch = patch_generic_hdmi },
> +{ .id = 0x80862880, .name = "CedarTrail HDMI",	.patch = patch_generic_hdmi },
>  {} /* terminator */
>  };
>  
> @@ -1959,6 +1960,7 @@ MODULE_ALIAS("snd-hda-codec-id:80862804"
>  MODULE_ALIAS("snd-hda-codec-id:80862805");
>  MODULE_ALIAS("snd-hda-codec-id:80862806");
>  MODULE_ALIAS("snd-hda-codec-id:808629fb");
> +MODULE_ALIAS("snd-hda-codec-id:80862880");
>  
>  MODULE_LICENSE("GPL");
>  MODULE_DESCRIPTION("HDMI HD-audio codec");
> 

Re: [PATCH] hda - add id for Atom Cedar Trail HDMI codec

[Wu Fengguang]

On Thu, Feb 23, 2012 at 09:50:57AM +0100, Takashi Iwai wrote:
> At Thu, 23 Feb 2012 15:07:44 +0800,
> Wu Fengguang wrote:
> > 
> > 
> > Signed-off-by: Wu Fengguang <fengguang.wu@intel.com>
> 
> Applied, but I sorted the order.  CedarTrail's id is less than
> Crestline's id number.

Thank you, that's obviously good change.

Re: [PATCH] hda - add id for Atom Cedar Trail HDMI codec

[Paul Menzel]

[-- Attachment #1.1: Type: text/plain, Size: 1799 bytes --]

Dear Fengguang,


Am Donnerstag, den 23.02.2012, 15:07 +0800 schrieb Wu Fengguang:
> Signed-off-by: Wu Fengguang <fengguang.wu@intel.com>

as always I am confused what is your first name and what is the surname.

Intel email messages seem to be <$fristname.$lastname@intel.com>. So if
Wu is your last name you should put a »,« behind Wu in your Mutt
configuration and adapt your Git configuration with the following
command.

    git config --global user.name "Fengguang Wu"

> ---
>  sound/pci/hda/patch_hdmi.c |    2 ++
>  1 file changed, 2 insertions(+)
> 
> --- sound.orig/sound/pci/hda/patch_hdmi.c	2012-02-23 14:51:19.562540743 +0800
> +++ sound/sound/pci/hda/patch_hdmi.c	2012-02-23 15:05:51.774522844 +0800
> @@ -1913,6 +1913,7 @@ static const struct hda_codec_preset snd
>  { .id = 0x80862805, .name = "CougarPoint HDMI",	.patch = patch_generic_hdmi },
>  { .id = 0x80862806, .name = "PantherPoint HDMI", .patch = patch_generic_hdmi },
>  { .id = 0x808629fb, .name = "Crestline HDMI",	.patch = patch_generic_hdmi },
> +{ .id = 0x80862880, .name = "CedarTrail HDMI",	.patch = patch_generic_hdmi },
>  {} /* terminator */
>  };
>  
> @@ -1959,6 +1960,7 @@ MODULE_ALIAS("snd-hda-codec-id:80862804"
>  MODULE_ALIAS("snd-hda-codec-id:80862805");
>  MODULE_ALIAS("snd-hda-codec-id:80862806");
>  MODULE_ALIAS("snd-hda-codec-id:808629fb");
> +MODULE_ALIAS("snd-hda-codec-id:80862880");
>  
>  MODULE_LICENSE("GPL");
>  MODULE_DESCRIPTION("HDMI HD-audio codec");

Thank you for your patch.

Next time it would be nice, if you could add some test information to
the commit message.


Thanks,

Paul


[1] http://cn.linkedin.com/pub/fengguang-wu/2b/587/b18
[2] http://www.igi-global.com/chapter/advanced-operating-systems-kernel-applications/37951

[-- Attachment #1.2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 198 bytes --]

[-- Attachment #2: Type: text/plain, Size: 0 bytes --]

Re: [PATCH] hda - add id for Atom Cedar Trail HDMI codec

[Fengguang Wu]

Dear Paul,

On Thu, Feb 23, 2012 at 11:31:45AM +0100, Paul Menzel wrote:
> Dear Fengguang,
> 
> 
> Am Donnerstag, den 23.02.2012, 15:07 +0800 schrieb Wu Fengguang:
> > Signed-off-by: Wu Fengguang <fengguang.wu@intel.com>
> 
> as always I am confused what is your first name and what is the surname.

Sorry about that... It's sure confusing. According to

https://en.wikipedia.org/wiki/Chinese_name#Chinese_names_in_English

"Chinese people, except for those traveling or living outside of
China, rarely reverse their names to the western naming order (given
name, then family name). Western publications usually preserve the
Chinese naming order, with the family name first, followed by the
given name."

However it does look worthwhile to fit the western order in English
since the majority LKML readers are accustomed to that. The good news
is, whether or not "Fengguang Wu" or "Wu Fengguang" is used, Chinese
people can always recognize "Wu" as my family name, instantly.

> Intel email messages seem to be <$fristname.$lastname@intel.com>. So if
> Wu is your last name you should put a »,« behind Wu in your Mutt
> configuration and adapt your Git configuration with the following
> command.
> 
>     git config --global user.name "Fengguang Wu"

Done. Thanks for the tip!

Fengguang Wu
_______________________________________________
Alsa-devel mailing list
Alsa-devel@alsa-project.org
http://mailman.alsa-project.org/mailman/listinfo/alsa-devel