* [SPI/MFD] Fix build/section mismatch warnings in da9052-spi.c
@ 2012-02-13 9:51 Russell King - ARM Linux
2012-02-13 18:53 ` Grant Likely
2012-02-23 15:28 ` Samuel Ortiz
0 siblings, 2 replies; 3+ messages in thread
From: Russell King - ARM Linux @ 2012-02-13 9:51 UTC (permalink / raw)
To: linux-arm-kernel
From: Russell King <rmk+kernel@arm.linux.org.uk>
drivers/mfd/da9052-spi.c:65: warning: 'da9052_spi_remove' defined but not used
and:
WARNING: drivers/mfd/built-in.o(.text+0xb818): Section mismatch in reference from the function da9052_spi_probe() to the function .devinit.text:da9052_device_init()
The function da9052_spi_probe() references
the function __devinit da9052_device_init().
This is often because da9052_spi_probe lacks a __devinit
annotation or the annotation of da9052_device_init is wrong.
where found during an ARM randconfig build. Fix these warnings by
adding the annotations.
Signed-off-by: Russell King <rmk+kernel@arm.linux.org.uk>
---
drivers/mfd/da9052-spi.c | 4 ++--
1 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/mfd/da9052-spi.c b/drivers/mfd/da9052-spi.c
index cdbc7ca..2693c87 100644
--- a/drivers/mfd/da9052-spi.c
+++ b/drivers/mfd/da9052-spi.c
@@ -21,7 +21,7 @@
#include <linux/mfd/da9052/da9052.h>
-static int da9052_spi_probe(struct spi_device *spi)
+static int __devinit da9052_spi_probe(struct spi_device *spi)
{
int ret;
const struct spi_device_id *id = spi_get_device_id(spi);
@@ -61,7 +61,7 @@ static int da9052_spi_probe(struct spi_device *spi)
return ret;
}
-static int da9052_spi_remove(struct spi_device *spi)
+static int __devexit da9052_spi_remove(struct spi_device *spi)
{
struct da9052 *da9052 = dev_get_drvdata(&spi->dev);
^ permalink raw reply related [flat|nested] 3+ messages in thread
* [SPI/MFD] Fix build/section mismatch warnings in da9052-spi.c
2012-02-13 9:51 [SPI/MFD] Fix build/section mismatch warnings in da9052-spi.c Russell King - ARM Linux
@ 2012-02-13 18:53 ` Grant Likely
2012-02-23 15:28 ` Samuel Ortiz
1 sibling, 0 replies; 3+ messages in thread
From: Grant Likely @ 2012-02-13 18:53 UTC (permalink / raw)
To: linux-arm-kernel
On Mon, Feb 13, 2012 at 09:51:01AM +0000, Russell King - ARM Linux wrote:
> From: Russell King <rmk+kernel@arm.linux.org.uk>
>
> drivers/mfd/da9052-spi.c:65: warning: 'da9052_spi_remove' defined but not used
>
> and:
>
> WARNING: drivers/mfd/built-in.o(.text+0xb818): Section mismatch in reference from the function da9052_spi_probe() to the function .devinit.text:da9052_device_init()
> The function da9052_spi_probe() references
> the function __devinit da9052_device_init().
> This is often because da9052_spi_probe lacks a __devinit
> annotation or the annotation of da9052_device_init is wrong.
>
> where found during an ARM randconfig build. Fix these warnings by
> adding the annotations.
>
> Signed-off-by: Russell King <rmk+kernel@arm.linux.org.uk>
Acked-by: Grant Likely <grant.likely@secretlab.ca>
This is in the mfd directory, so I'll let Samuel merge it.
g.
> ---
> drivers/mfd/da9052-spi.c | 4 ++--
> 1 files changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/mfd/da9052-spi.c b/drivers/mfd/da9052-spi.c
> index cdbc7ca..2693c87 100644
> --- a/drivers/mfd/da9052-spi.c
> +++ b/drivers/mfd/da9052-spi.c
> @@ -21,7 +21,7 @@
>
> #include <linux/mfd/da9052/da9052.h>
>
> -static int da9052_spi_probe(struct spi_device *spi)
> +static int __devinit da9052_spi_probe(struct spi_device *spi)
> {
> int ret;
> const struct spi_device_id *id = spi_get_device_id(spi);
> @@ -61,7 +61,7 @@ static int da9052_spi_probe(struct spi_device *spi)
> return ret;
> }
>
> -static int da9052_spi_remove(struct spi_device *spi)
> +static int __devexit da9052_spi_remove(struct spi_device *spi)
> {
> struct da9052 *da9052 = dev_get_drvdata(&spi->dev);
>
>
> _______________________________________________
> linux-arm-kernel mailing list
> linux-arm-kernel at lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 3+ messages in thread
* [SPI/MFD] Fix build/section mismatch warnings in da9052-spi.c
2012-02-13 9:51 [SPI/MFD] Fix build/section mismatch warnings in da9052-spi.c Russell King - ARM Linux
2012-02-13 18:53 ` Grant Likely
@ 2012-02-23 15:28 ` Samuel Ortiz
1 sibling, 0 replies; 3+ messages in thread
From: Samuel Ortiz @ 2012-02-23 15:28 UTC (permalink / raw)
To: linux-arm-kernel
Hi Russell,
On Mon, Feb 13, 2012 at 09:51:01AM +0000, Russell King - ARM Linux wrote:
> From: Russell King <rmk+kernel@arm.linux.org.uk>
>
> drivers/mfd/da9052-spi.c:65: warning: 'da9052_spi_remove' defined but not used
A similar patch has been sent by Axel Lin, and applied to my for-next branch.
Cheers,
Samuel.
--
Intel Open Source Technology Centre
http://oss.intel.com/
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2012-02-23 15:28 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2012-02-13 9:51 [SPI/MFD] Fix build/section mismatch warnings in da9052-spi.c Russell King - ARM Linux
2012-02-13 18:53 ` Grant Likely
2012-02-23 15:28 ` Samuel Ortiz
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.