From: Andi Kleen <ak@linux.intel.com>
To: Andrew Morton <akpm@linux-foundation.org>
Cc: Rusty Russell <rusty@rustcorp.com.au>,
Nick Piggin <npiggin@kernel.dk>,
linux-kernel <linux-kernel@vger.kernel.org>,
Alexander Viro <viro@zeniv.linux.org.uk>,
"Srivatsa S. Bhat" <srivatsa.bhat@linux.vnet.ibm.com>,
linux-fsdevel@vger.kernel.org
Subject: Re: [PATCH] cpumask: fix lg_lock/br_lock.
Date: Tue, 28 Feb 2012 03:24:22 -0800 [thread overview]
Message-ID: <20120228112422.GC11324@alboin.amr.corp.intel.com> (raw)
In-Reply-To: <20120227155338.7b5110cd.akpm@linux-foundation.org>
On Mon, Feb 27, 2012 at 03:53:38PM -0800, Andrew Morton wrote:
> On Tue, 28 Feb 2012 09:52:30 +1030
> Rusty Russell <rusty@rustcorp.com.au> wrote:
>
> > Use a cpumask_var_t instead of cpumask_t. We're doing plenty of
> > allocations here anyway, so it's not really an issue, and it sets a
> > good example.
> >
> > (cpumask_t is obsolescent, as are the cpus_* functions).
>
> Congratulations to yourself and Andi:
Well the only way to avoid that problem is to merge it ASAP.
The patch -- like most code movement patches -- is totally unsuitable for
keeping around for months in trees.
Usually I found the best way to do merges with code movement patches
is to edit the patches itself if possible.
Maybe some day we'll get patch like tools that can deal with this stuff
better.
Rusty: you should probably have cocci rules for this stuff, not manual
patches.
-Andi
next prev parent reply other threads:[~2012-02-28 11:24 UTC|newest]
Thread overview: 45+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-02-27 23:22 [PATCH] cpumask: fix lg_lock/br_lock Rusty Russell
2012-02-27 23:53 ` Andrew Morton
2012-02-27 23:53 ` Andrew Morton
2012-02-28 8:43 ` Ingo Molnar
2012-02-28 11:25 ` Andi Kleen
2012-02-28 12:51 ` Ingo Molnar
2012-02-28 21:27 ` Andrew Morton
2012-02-29 5:44 ` Srivatsa S. Bhat
2012-02-29 9:17 ` Ingo Molnar
2012-02-29 11:12 ` Srivatsa S. Bhat
2012-03-01 7:38 ` Ingo Molnar
2012-03-01 9:15 ` Srivatsa S. Bhat
2012-03-01 9:45 ` Ingo Molnar
2012-03-01 9:56 ` Srivatsa S. Bhat
2012-03-01 8:12 ` Srivatsa S. Bhat
2012-03-01 8:24 ` Srivatsa S. Bhat
2012-03-01 8:12 ` Srivatsa S. Bhat
2012-03-01 8:15 ` [PATCH 1/3] CPU hotplug: Fix issues with callback registration Srivatsa S. Bhat
2012-03-01 8:27 ` Srivatsa S. Bhat
2012-03-01 8:15 ` Srivatsa S. Bhat
2012-03-01 8:16 ` [PATCH 2/3] CPU hotplug, arch/powerpc: Fix CPU hotplug " Srivatsa S. Bhat
2012-03-01 8:28 ` Srivatsa S. Bhat
2012-03-01 8:16 ` Srivatsa S. Bhat
2012-03-01 8:18 ` [PATCH 3/3] CPU hotplug, arch/sparc: " Srivatsa S. Bhat
2012-03-01 8:30 ` Srivatsa S. Bhat
2012-03-01 8:18 ` Srivatsa S. Bhat
2012-02-29 8:29 ` [PATCH] cpumask: fix lg_lock/br_lock Ingo Molnar
2012-02-29 8:58 ` Peter Zijlstra
2012-02-29 9:32 ` Ingo Molnar
2012-02-28 11:24 ` Andi Kleen [this message]
2012-03-05 7:02 ` Rusty Russell
2012-03-05 7:03 ` [PATCH 1/3] lglock: remove online variants of lock Rusty Russell
2012-04-20 11:12 ` Nick Piggin
2012-03-05 7:04 ` [PATCH 2/3] brlocks/lglocks: API cleanups Rusty Russell
2012-03-05 7:05 ` [PATCH 3/3] brlocks/lglocks: turn into functions Rusty Russell
2012-04-20 11:21 ` Nick Piggin
2012-05-07 3:39 ` Rusty Russell
2012-05-07 5:46 ` Al Viro
2012-05-08 3:59 ` [PATCH 1/3] lglock: remove online variants of lock Rusty Russell
2012-05-08 4:50 ` Al Viro
2012-05-08 6:12 ` Rusty Russell
2012-05-08 4:02 ` [PATCH 2/3] brlocks/lglocks: API cleanups Rusty Russell
2012-05-08 4:02 ` [PATCH 3/3] brlocks/lglocks: turn into functions Rusty Russell
2012-05-09 7:35 ` Nick Piggin
2012-05-09 7:35 ` Nick Piggin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120228112422.GC11324@alboin.amr.corp.intel.com \
--to=ak@linux.intel.com \
--cc=akpm@linux-foundation.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=npiggin@kernel.dk \
--cc=rusty@rustcorp.com.au \
--cc=srivatsa.bhat@linux.vnet.ibm.com \
--cc=viro@zeniv.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.