* [PATCH] r8169: corrupted IP fragments fix for large mtu.
@ 2012-03-02 14:43 Francois Romieu
2012-03-03 0:10 ` David Miller
0 siblings, 1 reply; 2+ messages in thread
From: Francois Romieu @ 2012-03-02 14:43 UTC (permalink / raw)
To: David S. Miller; +Cc: netdev, Nick Bowler, Hayes Wang
Noticed with the 8168d (-vb-gr, aka RTL_GIGA_MAC_VER_26).
ConfigX registers should only be written while the Config9346 lock
is held.
Signed-off-by: Francois Romieu <romieu@fr.zoreil.com>
Reported-by: Nick Bowler <nbowler@elliptictech.com>
Cc: Hayes Wang <hayeswang@realtek.com>
---
drivers/net/ethernet/realtek/r8169.c | 8 ++++++++
1 files changed, 8 insertions(+), 0 deletions(-)
diff --git a/drivers/net/ethernet/realtek/r8169.c b/drivers/net/ethernet/realtek/r8169.c
index 7a0c800..1adf177 100644
--- a/drivers/net/ethernet/realtek/r8169.c
+++ b/drivers/net/ethernet/realtek/r8169.c
@@ -3781,12 +3781,20 @@ static void rtl8169_init_ring_indexes(struct rtl8169_private *tp)
static void rtl_hw_jumbo_enable(struct rtl8169_private *tp)
{
+ void __iomem *ioaddr = tp->mmio_addr;
+
+ RTL_W8(Cfg9346, Cfg9346_Unlock);
rtl_generic_op(tp, tp->jumbo_ops.enable);
+ RTL_W8(Cfg9346, Cfg9346_Lock);
}
static void rtl_hw_jumbo_disable(struct rtl8169_private *tp)
{
+ void __iomem *ioaddr = tp->mmio_addr;
+
+ RTL_W8(Cfg9346, Cfg9346_Unlock);
rtl_generic_op(tp, tp->jumbo_ops.disable);
+ RTL_W8(Cfg9346, Cfg9346_Lock);
}
static void r8168c_hw_jumbo_enable(struct rtl8169_private *tp)
--
1.7.7.6
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] r8169: corrupted IP fragments fix for large mtu.
2012-03-02 14:43 [PATCH] r8169: corrupted IP fragments fix for large mtu Francois Romieu
@ 2012-03-03 0:10 ` David Miller
0 siblings, 0 replies; 2+ messages in thread
From: David Miller @ 2012-03-03 0:10 UTC (permalink / raw)
To: romieu; +Cc: netdev, nbowler, hayeswang
From: Francois Romieu <romieu@fr.zoreil.com>
Date: Fri, 2 Mar 2012 15:43:14 +0100
> Noticed with the 8168d (-vb-gr, aka RTL_GIGA_MAC_VER_26).
>
> ConfigX registers should only be written while the Config9346 lock
> is held.
>
> Signed-off-by: Francois Romieu <romieu@fr.zoreil.com>
> Reported-by: Nick Bowler <nbowler@elliptictech.com>
> Cc: Hayes Wang <hayeswang@realtek.com>
Applied and queued up for -stable, thanks a lot.
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2012-03-03 0:12 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2012-03-02 14:43 [PATCH] r8169: corrupted IP fragments fix for large mtu Francois Romieu
2012-03-03 0:10 ` David Miller
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.