From: Grant Likely <grant.likely@secretlab.ca> To: Andrew Morton <akpm@linux-foundation.org>, "Cousson, Benoit" <b-cousson@ti.com> Cc: linux-kernel@vger.kernel.org, devicetree-discuss@lists.ozlabs.org, Samuel Ortiz <sameo@linux.intel.com> Subject: Re: [PATCH] devicetree: Add empty of_platform_populate() for !CONFIG_OF_ADDRESS (sparc) Date: Fri, 02 Mar 2012 21:09:30 -0700 [thread overview] Message-ID: <20120303040930.1E9283E190C@localhost> (raw) In-Reply-To: <20120302170715.9f0a67ef.akpm@linux-foundation.org> On Fri, 2 Mar 2012 17:07:15 -0800, Andrew Morton <akpm@linux-foundation.org> wrote: > On Fri, 2 Mar 2012 22:20:16 +0100 > "Cousson, Benoit" <b-cousson@ti.com> wrote: > > > Hi Grant, > > > > In fact this patch is not working for build without CONFIG_OF like x86. > > > > On 2/24/2012 11:06 PM, Grant Likely wrote: > > > --- a/include/linux/of_platform.h > > > +++ b/include/linux/of_platform.h > > > @@ -81,7 +81,7 @@ extern struct platform_device *of_device_alloc(struct device_node *np, > > > struct device *parent); > > > extern struct platform_device *of_find_device_by_node(struct device_node *np); > > > > > > -#if !defined(CONFIG_SPARC) /* SPARC has its own device registration method */ > > > +#ifdef CONFIG_OF_ADDRESS /* device reg helpers depend on OF_ADDRESS */ > > > /* Platform devices and busses creation */ > > > extern struct platform_device *of_platform_device_create(struct device_node *np, > > > const char *bus_id, > > > @@ -94,7 +94,15 @@ extern int of_platform_populate(struct device_node *root, > > > const struct of_device_id *matches, > > > const struct of_dev_auxdata *lookup, > > > struct device *parent); > > > -#endif /* !CONFIG_SPARC */ > > > +#else > > > +static inline int of_platform_populate(struct device_node *root, > > > + const struct of_device_id *matches, > > > + const struct of_dev_auxdata *lookup, > > > + struct device *parent) > > > +{ > > > + return -ENODEV; > > > +} > > > +#endif /* !CONFIG_OF_ADDRESS */ > > > > > > #endif /* CONFIG_OF_DEVICE */ > > > > Because if CONFIG_OF_DEVICE is not defined, then the stub for > > of_platform_populate will not be defined either. It should exist for any > > config without CONFIG_OF. > > > > Building twl4030 for x86 is actually broken. > > > > All twl is broken. i386 allmodconfig with this monring's linux-next: > > drivers/mfd/twl-core.c: In function 'twl_probe': > drivers/mfd/twl-core.c:1357: error: implicit declaration of function 'of_platform_populate' > This patch seems to solve it finally against irqdomain/next. Benoit, with your ack I'll push it out. g. --- commit 679946dfdbf990d3e75418fdaf92f3981ff1f4db Author: Grant Likely <grant.likely@secretlab.ca> Date: Fri Mar 2 21:05:31 2012 -0700 dt: fix twl4030 for non-dt compile on x86 twl4030 still doesn't build correctly for x86 allmodconfig. This fix solves the missing symbol errors. Signed-off-by: Grant Likely <grant.likely@secretlab.ca> diff --git a/drivers/mfd/twl-core.c b/drivers/mfd/twl-core.c index 4970d43..54727ef 100644 --- a/drivers/mfd/twl-core.c +++ b/drivers/mfd/twl-core.c @@ -38,6 +38,7 @@ #include <linux/of.h> #include <linux/of_irq.h> #include <linux/of_platform.h> +#include <linux/irq.h> #include <linux/irqdomain.h> #include <linux/regulator/machine.h> diff --git a/include/linux/of_platform.h b/include/linux/of_platform.h index 242fa35..b47d204 100644 --- a/include/linux/of_platform.h +++ b/include/linux/of_platform.h @@ -94,7 +94,12 @@ extern int of_platform_populate(struct device_node *root, const struct of_device_id *matches, const struct of_dev_auxdata *lookup, struct device *parent); -#else +#endif /* CONFIG_OF_ADDRESS */ + +#endif /* CONFIG_OF_DEVICE */ + +#if !defined(CONFIG_OF_ADDRESS) +struct of_dev_auxdata; static inline int of_platform_populate(struct device_node *root, const struct of_device_id *matches, const struct of_dev_auxdata *lookup, @@ -104,6 +109,4 @@ static inline int of_platform_populate(struct device_node *root, } #endif /* !CONFIG_OF_ADDRESS */ -#endif /* CONFIG_OF_DEVICE */ - #endif /* _LINUX_OF_PLATFORM_H */ -- email sent from notmuch.vim plugin
WARNING: multiple messages have this Message-ID (diff)
From: Grant Likely <grant.likely-s3s/WqlpOiPyB63q8FvJNQ@public.gmane.org> To: Andrew Morton <akpm-de/tnXTf+JLsfHDXvbKv3WD2FQJk+8+b@public.gmane.org>, "Cousson, Benoit" <b-cousson-l0cyMroinI0@public.gmane.org> Cc: devicetree-discuss-uLR06cmDAlY/bJ5BZ2RsiQ@public.gmane.org, linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, Samuel Ortiz <sameo-VuQAYsv1563Yd54FQh9/CA@public.gmane.org> Subject: Re: [PATCH] devicetree: Add empty of_platform_populate() for !CONFIG_OF_ADDRESS (sparc) Date: Fri, 02 Mar 2012 21:09:30 -0700 [thread overview] Message-ID: <20120303040930.1E9283E190C@localhost> (raw) In-Reply-To: <20120302170715.9f0a67ef.akpm-de/tnXTf+JLsfHDXvbKv3WD2FQJk+8+b@public.gmane.org> On Fri, 2 Mar 2012 17:07:15 -0800, Andrew Morton <akpm-de/tnXTf+JLsfHDXvbKv3WD2FQJk+8+b@public.gmane.org> wrote: > On Fri, 2 Mar 2012 22:20:16 +0100 > "Cousson, Benoit" <b-cousson-l0cyMroinI0@public.gmane.org> wrote: > > > Hi Grant, > > > > In fact this patch is not working for build without CONFIG_OF like x86. > > > > On 2/24/2012 11:06 PM, Grant Likely wrote: > > > --- a/include/linux/of_platform.h > > > +++ b/include/linux/of_platform.h > > > @@ -81,7 +81,7 @@ extern struct platform_device *of_device_alloc(struct device_node *np, > > > struct device *parent); > > > extern struct platform_device *of_find_device_by_node(struct device_node *np); > > > > > > -#if !defined(CONFIG_SPARC) /* SPARC has its own device registration method */ > > > +#ifdef CONFIG_OF_ADDRESS /* device reg helpers depend on OF_ADDRESS */ > > > /* Platform devices and busses creation */ > > > extern struct platform_device *of_platform_device_create(struct device_node *np, > > > const char *bus_id, > > > @@ -94,7 +94,15 @@ extern int of_platform_populate(struct device_node *root, > > > const struct of_device_id *matches, > > > const struct of_dev_auxdata *lookup, > > > struct device *parent); > > > -#endif /* !CONFIG_SPARC */ > > > +#else > > > +static inline int of_platform_populate(struct device_node *root, > > > + const struct of_device_id *matches, > > > + const struct of_dev_auxdata *lookup, > > > + struct device *parent) > > > +{ > > > + return -ENODEV; > > > +} > > > +#endif /* !CONFIG_OF_ADDRESS */ > > > > > > #endif /* CONFIG_OF_DEVICE */ > > > > Because if CONFIG_OF_DEVICE is not defined, then the stub for > > of_platform_populate will not be defined either. It should exist for any > > config without CONFIG_OF. > > > > Building twl4030 for x86 is actually broken. > > > > All twl is broken. i386 allmodconfig with this monring's linux-next: > > drivers/mfd/twl-core.c: In function 'twl_probe': > drivers/mfd/twl-core.c:1357: error: implicit declaration of function 'of_platform_populate' > This patch seems to solve it finally against irqdomain/next. Benoit, with your ack I'll push it out. g. --- commit 679946dfdbf990d3e75418fdaf92f3981ff1f4db Author: Grant Likely <grant.likely-s3s/WqlpOiPyB63q8FvJNQ@public.gmane.org> Date: Fri Mar 2 21:05:31 2012 -0700 dt: fix twl4030 for non-dt compile on x86 twl4030 still doesn't build correctly for x86 allmodconfig. This fix solves the missing symbol errors. Signed-off-by: Grant Likely <grant.likely-s3s/WqlpOiPyB63q8FvJNQ@public.gmane.org> diff --git a/drivers/mfd/twl-core.c b/drivers/mfd/twl-core.c index 4970d43..54727ef 100644 --- a/drivers/mfd/twl-core.c +++ b/drivers/mfd/twl-core.c @@ -38,6 +38,7 @@ #include <linux/of.h> #include <linux/of_irq.h> #include <linux/of_platform.h> +#include <linux/irq.h> #include <linux/irqdomain.h> #include <linux/regulator/machine.h> diff --git a/include/linux/of_platform.h b/include/linux/of_platform.h index 242fa35..b47d204 100644 --- a/include/linux/of_platform.h +++ b/include/linux/of_platform.h @@ -94,7 +94,12 @@ extern int of_platform_populate(struct device_node *root, const struct of_device_id *matches, const struct of_dev_auxdata *lookup, struct device *parent); -#else +#endif /* CONFIG_OF_ADDRESS */ + +#endif /* CONFIG_OF_DEVICE */ + +#if !defined(CONFIG_OF_ADDRESS) +struct of_dev_auxdata; static inline int of_platform_populate(struct device_node *root, const struct of_device_id *matches, const struct of_dev_auxdata *lookup, @@ -104,6 +109,4 @@ static inline int of_platform_populate(struct device_node *root, } #endif /* !CONFIG_OF_ADDRESS */ -#endif /* CONFIG_OF_DEVICE */ - #endif /* _LINUX_OF_PLATFORM_H */ -- email sent from notmuch.vim plugin
next prev parent reply other threads:[~2012-03-03 4:09 UTC|newest] Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top 2012-02-24 22:06 [PATCH] devicetree: Add empty of_platform_populate() for !CONFIG_OF_ADDRESS (sparc) Grant Likely 2012-02-27 10:39 ` Samuel Ortiz 2012-02-27 13:56 ` Grant Likely 2012-03-02 21:20 ` Cousson, Benoit 2012-03-02 21:20 ` Cousson, Benoit 2012-03-03 1:07 ` Andrew Morton 2012-03-03 1:07 ` Andrew Morton 2012-03-03 4:09 ` Grant Likely [this message] 2012-03-03 4:09 ` Grant Likely 2012-03-05 13:30 ` Cousson, Benoit 2012-03-05 13:30 ` Cousson, Benoit 2012-03-05 15:10 ` Grant Likely
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20120303040930.1E9283E190C@localhost \ --to=grant.likely@secretlab.ca \ --cc=akpm@linux-foundation.org \ --cc=b-cousson@ti.com \ --cc=devicetree-discuss@lists.ozlabs.org \ --cc=linux-kernel@vger.kernel.org \ --cc=sameo@linux.intel.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.