* [PATCH] ext4: ignore ext3/ext2 only mount options
@ 2012-02-25 13:37 Tom Gundersen
2012-02-25 18:56 ` Andreas Dilger
2012-03-05 2:41 ` Ted Ts'o
0 siblings, 2 replies; 4+ messages in thread
From: Tom Gundersen @ 2012-02-25 13:37 UTC (permalink / raw)
To: linux-ext4
Cc: Tom Gundersen, Thomas Baechler, Tobias Powalowski, Dave Reisner
There is a regression when using the ext4 module to mount
ext2 or ext3 filesystems: When mountoptions are used that are
supported by ext2 or ext3, but not by ext4 the mount fails.
This patch changes the failure into a warning. The case when
the ext4 module is not used for ext2/3 support is unchanged.
Report: https://bbs.archlinux.org/profile.php?id=33804
Signed-off-by: Tom Gundersen <teg@jklm.no>
Cc: Thomas Baechler <thomas@archlinux.org>
Cc: Tobias Powalowski <tobias.powalowski@googlemail.com>
Cc: Dave Reisner <d@falconindy.com>
---
fs/ext4/super.c | 15 +++++++++++++++
1 file changed, 15 insertions(+)
diff --git a/fs/ext4/super.c b/fs/ext4/super.c
index 502c61f..30de9cd 100644
--- a/fs/ext4/super.c
+++ b/fs/ext4/super.c
@@ -1333,6 +1333,7 @@ enum {
Opt_inode_readahead_blks, Opt_journal_ioprio,
Opt_dioread_nolock, Opt_dioread_lock,
Opt_discard, Opt_nodiscard, Opt_init_itable, Opt_noinit_itable,
+ Opt_nocheck, Opt_reservation, Opt_noreservation, Opt_journal_inum,
};
static const match_table_t tokens = {
@@ -1408,6 +1409,10 @@ static const match_table_t tokens = {
{Opt_init_itable, "init_itable=%u"},
{Opt_init_itable, "init_itable"},
{Opt_noinit_itable, "noinit_itable"},
+ {Opt_nocheck, "nocheck"},
+ {Opt_reservation, "reservation"},
+ {Opt_noreservation, "noreservation"},
+ {Opt_journal_inum, "journal=%u"},
{Opt_err, NULL},
};
@@ -1904,6 +1909,16 @@ set_qf_format:
case Opt_noinit_itable:
clear_opt(sb, INIT_INODE_TABLE);
break;
+#ifdef CONFIG_EXT4_USE_FOR_EXT23
+ case Opt_nocheck:
+ case Opt_reservation:
+ case Opt_noreservation:
+ case Opt_journal_inum:
+ ext4_msg(sb, KERN_WARNING,
+ "ext3 mount option \"%s\" ignored "
+ "by ext4 module", p);
+ break;
+#endif
default:
ext4_msg(sb, KERN_ERR,
"Unrecognized mount option \"%s\" "
--
1.7.9.2
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH] ext4: ignore ext3/ext2 only mount options
2012-02-25 13:37 [PATCH] ext4: ignore ext3/ext2 only mount options Tom Gundersen
@ 2012-02-25 18:56 ` Andreas Dilger
2012-03-05 2:41 ` Ted Ts'o
1 sibling, 0 replies; 4+ messages in thread
From: Andreas Dilger @ 2012-02-25 18:56 UTC (permalink / raw)
To: Tom Gundersen, Ted Ts'o
Cc: linux-ext4, Tom Gundersen, Thomas Baechler, Tobias Powalowski,
Dave Reisner
On 2012-02-25, at 6:37, Tom Gundersen <teg@jklm.no> wrote:
> There is a regression when using the ext4 module to mount
> ext2 or ext3 filesystems: When mountoptions are used that are
> supported by ext2 or ext3, but not by ext4 the mount fails.
>
> This patch changes the failure into a warning. The case when
> the ext4 module is not used for ext2/3 support is unchanged.
>
> Report: https://bbs.archlinux.org/profile.php?id=33804
> Signed-off-by: Tom Gundersen <teg@jklm.no>
> Cc: Thomas Baechler <thomas@archlinux.org>
> Cc: Tobias Powalowski <tobias.powalowski@googlemail.com>
> Cc: Dave Reisner <d@falconindy.com>
Looks reasonable. Thanks for submitting the patch.
Reviewed-by: Andreas Dilger <adilger@dilger.ca>
> fs/ext4/super.c | 15 +++++++++++++++
> 1 file changed, 15 insertions(+)
>
> diff --git a/fs/ext4/super.c b/fs/ext4/super.c
> index 502c61f..30de9cd 100644
> --- a/fs/ext4/super.c
> +++ b/fs/ext4/super.c
> @@ -1333,6 +1333,7 @@ enum {
> Opt_inode_readahead_blks, Opt_journal_ioprio,
> Opt_dioread_nolock, Opt_dioread_lock,
> Opt_discard, Opt_nodiscard, Opt_init_itable, Opt_noinit_itable,
> + Opt_nocheck, Opt_reservation, Opt_noreservation, Opt_journal_inum,
> };
>
> static const match_table_t tokens = {
> @@ -1408,6 +1409,10 @@ static const match_table_t tokens = {
> {Opt_init_itable, "init_itable=%u"},
> {Opt_init_itable, "init_itable"},
> {Opt_noinit_itable, "noinit_itable"},
> + {Opt_nocheck, "nocheck"},
> + {Opt_reservation, "reservation"},
> + {Opt_noreservation, "noreservation"},
> + {Opt_journal_inum, "journal=%u"},
> {Opt_err, NULL},
> };
>
> @@ -1904,6 +1909,16 @@ set_qf_format:
> case Opt_noinit_itable:
> clear_opt(sb, INIT_INODE_TABLE);
> break;
> +#ifdef CONFIG_EXT4_USE_FOR_EXT23
> + case Opt_nocheck:
> + case Opt_reservation:
> + case Opt_noreservation:
> + case Opt_journal_inum:
> + ext4_msg(sb, KERN_WARNING,
> + "ext3 mount option \"%s\" ignored "
> + "by ext4 module", p);
> + break;
> +#endif
> default:
> ext4_msg(sb, KERN_ERR,
> "Unrecognized mount option \"%s\" "
> --
> 1.7.9.2
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-ext4" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] ext4: ignore ext3/ext2 only mount options
2012-02-25 13:37 [PATCH] ext4: ignore ext3/ext2 only mount options Tom Gundersen
2012-02-25 18:56 ` Andreas Dilger
@ 2012-03-05 2:41 ` Ted Ts'o
2012-03-05 3:16 ` Ted Ts'o
1 sibling, 1 reply; 4+ messages in thread
From: Ted Ts'o @ 2012-03-05 2:41 UTC (permalink / raw)
To: Tom Gundersen
Cc: linux-ext4, Thomas Baechler, Tobias Powalowski, Dave Reisner
On Sat, Feb 25, 2012 at 02:37:01PM +0100, Tom Gundersen wrote:
> There is a regression when using the ext4 module to mount
> ext2 or ext3 filesystems: When mountoptions are used that are
> supported by ext2 or ext3, but not by ext4 the mount fails.
>
> This patch changes the failure into a warning. The case when
> the ext4 module is not used for ext2/3 support is unchanged.
>
> Report: https://bbs.archlinux.org/profile.php?id=33804
> Signed-off-by: Tom Gundersen <teg@jklm.no>
> Cc: Thomas Baechler <thomas@archlinux.org>
> Cc: Tobias Powalowski <tobias.powalowski@googlemail.com>
> Cc: Dave Reisner <d@falconindy.com>
Thanks. This patch will be slightly modified due to some cleanup and
refactorization in ext4's mount option handling code that I've been
doing.
- Ted
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] ext4: ignore ext3/ext2 only mount options
2012-03-05 2:41 ` Ted Ts'o
@ 2012-03-05 3:16 ` Ted Ts'o
0 siblings, 0 replies; 4+ messages in thread
From: Ted Ts'o @ 2012-03-05 3:16 UTC (permalink / raw)
To: Tom Gundersen
Cc: linux-ext4, Thomas Baechler, Tobias Powalowski, Dave Reisner
On Sun, Mar 04, 2012 at 09:41:04PM -0500, Ted Ts'o wrote:
> Thanks. This patch will be slightly modified due to some cleanup and
> refactorization in ext4's mount option handling code that I've been
> doing.
Note: the entire patch series can be found here, for those people who
are not subscribed to the linux-ext4 list.
http://thread.gmane.org/gmane.comp.file-systems.ext4/31094
- Ted
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2012-03-05 3:16 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2012-02-25 13:37 [PATCH] ext4: ignore ext3/ext2 only mount options Tom Gundersen
2012-02-25 18:56 ` Andreas Dilger
2012-03-05 2:41 ` Ted Ts'o
2012-03-05 3:16 ` Ted Ts'o
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.