* [Buildroot] [PATCH v2 1/3] Add target to print buildroot version
@ 2012-03-04 13:03 Arnout Vandecappelle
2012-03-04 13:03 ` [Buildroot] [PATCH v2 2/3] config: make it possible to specify which config file to use for 'make defconfig' Arnout Vandecappelle
` (4 more replies)
0 siblings, 5 replies; 15+ messages in thread
From: Arnout Vandecappelle @ 2012-03-04 13:03 UTC (permalink / raw)
To: buildroot
From: "Arnout Vandecappelle (Essensium/Mind)" <arnout@mind.be>
It's convenient to have a target to print the buildroot version, for use
in external scripts calling buildroot.
Signed-off-by: Arnout Vandecappelle (Essensium/Mind) <arnout@mind.be>
---
.topdeps | 1 +
.topmsg | 7 +++++++
Makefile | 5 ++++-
3 files changed, 12 insertions(+), 1 deletions(-)
create mode 100644 .topdeps
create mode 100644 .topmsg
diff --git a/.topdeps b/.topdeps
new file mode 100644
index 0000000..1f7391f
--- /dev/null
+++ b/.topdeps
@@ -0,0 +1 @@
+master
diff --git a/.topmsg b/.topmsg
new file mode 100644
index 0000000..b431fc4
--- /dev/null
+++ b/.topmsg
@@ -0,0 +1,7 @@
+From: Arnout Vandecappelle (Essensium/Mind) <arnout@mind.be>
+Subject: [PATCH] Add target to print buildroot version
+
+It's convenient to have a target to print the buildroot version, for use
+in external scripts calling buildroot.
+
+Signed-off-by: Arnout Vandecappelle (Essensium/Mind) <arnout@mind.be>
diff --git a/Makefile b/Makefile
index d508888..30099d9 100644
--- a/Makefile
+++ b/Makefile
@@ -48,7 +48,7 @@ export BR2_VERSION_FULL:=$(BR2_VERSION)$(shell $(TOPDIR)/support/scripts/setloca
noconfig_targets:=menuconfig nconfig gconfig xconfig config oldconfig randconfig \
defconfig %_defconfig savedefconfig allyesconfig allnoconfig silentoldconfig release \
randpackageconfig allyespackageconfig allnopackageconfig \
- source-check
+ source-check print-version
# Strip quotes and then whitespaces
qstrip=$(strip $(subst ",,$(1)))
@@ -721,6 +721,9 @@ release:
bzip2 -9 -c < $(OUT).tar > $(OUT).tar.bz2
rm -rf $(OUT) $(OUT).tar
+print-version:
+ @echo $(BR2_VERSION_FULL)
+
################################################################################
# GENDOC -- generates the make targets needed to build a specific type of
# asciidoc documentation.
--
1.7.9.1
^ permalink raw reply related [flat|nested] 15+ messages in thread
* [Buildroot] [PATCH v2 2/3] config: make it possible to specify which config file to use for 'make defconfig'
2012-03-04 13:03 [Buildroot] [PATCH v2 1/3] Add target to print buildroot version Arnout Vandecappelle
@ 2012-03-04 13:03 ` Arnout Vandecappelle
2012-03-05 9:37 ` Thomas Petazzoni
` (2 more replies)
2012-03-04 13:03 ` [Buildroot] [PATCH v2 3/3] Add test infrastructure Arnout Vandecappelle
` (3 subsequent siblings)
4 siblings, 3 replies; 15+ messages in thread
From: Arnout Vandecappelle @ 2012-03-04 13:03 UTC (permalink / raw)
To: buildroot
From: "Arnout Vandecappelle (Essensium/Mind)" <arnout@mind.be>
So that this works:
% make defconfig DEFCONFIG=~/busybox-defconfig
Right now we have to do:
% cp ~/busybox-defconfig configs/busybox_defconfig
% make busybox_defconfig
That would dirty the buildroot tree and requires it to be writable.
Signed-off-by: Felipe Contreras <felipe.contreras@gmail.com>
Signed-off-by: Arnout Vandecappelle (Essensium/Mind) <arnout@mind.be>
---
Makefile | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/Makefile b/Makefile
index 30099d9..b450b8f 100644
--- a/Makefile
+++ b/Makefile
@@ -602,7 +602,7 @@ silentoldconfig: $(BUILD_DIR)/buildroot-config/conf outputmakefile
defconfig: $(BUILD_DIR)/buildroot-config/conf outputmakefile
@mkdir -p $(BUILD_DIR)/buildroot-config
- @$(COMMON_CONFIG_ENV) $< --defconfig $(CONFIG_CONFIG_IN)
+ @$(COMMON_CONFIG_ENV) $< --defconfig$(patsubst %,=%,$(BR2_DEFCONFIG)) $(CONFIG_CONFIG_IN)
%_defconfig: $(BUILD_DIR)/buildroot-config/conf $(TOPDIR)/configs/%_defconfig outputmakefile
@mkdir -p $(BUILD_DIR)/buildroot-config
--
1.7.9.1
^ permalink raw reply related [flat|nested] 15+ messages in thread
* [Buildroot] [PATCH v2 3/3] Add test infrastructure
2012-03-04 13:03 [Buildroot] [PATCH v2 1/3] Add target to print buildroot version Arnout Vandecappelle
2012-03-04 13:03 ` [Buildroot] [PATCH v2 2/3] config: make it possible to specify which config file to use for 'make defconfig' Arnout Vandecappelle
@ 2012-03-04 13:03 ` Arnout Vandecappelle
2012-03-04 13:22 ` Arnout Vandecappelle
2012-03-05 9:39 ` Thomas Petazzoni
2012-03-04 13:05 ` [Buildroot] [PATCH v2 1/3] Add target to print buildroot version Arnout Vandecappelle
` (2 subsequent siblings)
4 siblings, 2 replies; 15+ messages in thread
From: Arnout Vandecappelle @ 2012-03-04 13:03 UTC (permalink / raw)
To: buildroot
From: "Arnout Vandecappelle (Essensium/Mind)" <arnout@mind.be>
The test infrastructure is a script and a list of tests to be run.
Additional test configurations can be added later to the test directory.
Signed-off-by: Arnout Vandecappelle (Essensium/Mind) <arnout@mind.be>
---
.topdeps | 3 +-
.topmsg | 13 ++++-
test/runtests.sh | 122 ++++++++++++++++++++++++++++++++++++++++++++++++++++++
test/testspecs | 24 +++++++++++
4 files changed, 158 insertions(+), 4 deletions(-)
create mode 100755 test/runtests.sh
create mode 100644 test/testspecs
diff --git a/.topdeps b/.topdeps
index 1f7391f..bbe331b 100644
--- a/.topdeps
+++ b/.topdeps
@@ -1 +1,2 @@
-master
+t/print-version
+t/defconfig
diff --git a/.topmsg b/.topmsg
index b431fc4..3a90662 100644
--- a/.topmsg
+++ b/.topmsg
@@ -1,7 +1,14 @@
From: Arnout Vandecappelle (Essensium/Mind) <arnout@mind.be>
-Subject: [PATCH] Add target to print buildroot version
+Subject: [PATCH] Add test infrastructure
-It's convenient to have a target to print the buildroot version, for use
-in external scripts calling buildroot.
+The test infrastructure is a script and a list of tests to be run.
+Additional test configurations can be added later to the test directory.
Signed-off-by: Arnout Vandecappelle (Essensium/Mind) <arnout@mind.be>
+---
+Changes v2:
+ - Fixed support for defconfig and *packageconfig
+ - This now depends on the BR2_DEFCONFIG patch
+ - Use printf instead of echo (feedback from Yann)
+ - Use ${...} for all variable references (feedback from Yann)
+ - Put quotes around everything (feedback from Yann)
diff --git a/test/runtests.sh b/test/runtests.sh
new file mode 100755
index 0000000..6a4af2d
--- /dev/null
+++ b/test/runtests.sh
@@ -0,0 +1,122 @@
+#! /bin/sh
+# Run test builds of buildroot
+# runtest.sh <testspec>...
+#
+# testspec: <baseconfig>[=<type>,...]
+# A testspec is a config file name (relative to the buildroot top dir),
+# optionally followed by a comma-separated list of config types.
+# Config types are: def, rand, allyes, allno, randpackage, allyespackage,
+# allnopackage
+# If config types are not given, it is taken from a line containing
+# CONFIGTYPES= in the baseconfig. If that is also not present, def
+# and randpackage are tried.
+#
+# If no arguments are given, the testspecs are taken from the testspecs
+# file in the current directory. If that file doesn't exist, the testspecs
+# file in the test directory is taken.
+#
+# The output goes into the current directory.
+
+testdir="$(dirname ${0})"
+topdir="$(cd ${testdir}/..; pwd)"
+
+configdir="${PWD}/gen-config"
+brversion="$(make -C ${topdir} --no-print-directory print-version)"
+
+printf 'Running tests for %s\n' "${brversion}"
+
+# Run build for config $1 with type $2
+function runbuild() {
+ baseconfig="${1}"
+ configtype="${2}"
+
+ printf 'Building %s %sconfig\n' "${baseconfig}" "${configtype}"
+
+ # Interprete baseconfig relative to topdir
+ if [ "${baseconfig:0:1}" = / ]; then
+ baseconfigfile="${baseconfig}"
+ else
+ baseconfigfile="${topdir}/${baseconfig}"
+ fi
+
+ if [ ! -r "${baseconfigfile}" ]; then
+ printf ' *** %s not found\n' "${baseconfig}"
+ return 1
+ fi
+
+ configname="${brversion}-$(basename ${baseconfig})"
+ hostdir="${PWD}/${configname}.hostdir"
+
+ # Create the configtype from baseconfig.
+ # defconfig is a special case because it needs to be passed in
+ # a different way. *packageconfig are also special, because
+ # they need a complete config (not just defconfig) as input, otherwise
+ # the package hack doesn't work, so we need to run make defconfig first.
+ mkdir -p "${configdir}"
+ cp "${baseconfigfile}" "${configdir}/.config.in"
+ printf 'BR2_HOST_DIR="%s"\n' "${hostdir}" >> "${configdir}/.config.in"
+ if [ "${configtype}" = "def" -o "${configtype%*package}" != "${configtype}" ]; then
+ make -C "${topdir}" O="${configdir}" defconfig BR2_DEFCONFIG="${configdir}/.config.in" > "${configdir}.log" || {
+ printf ' *** make defconfig failed for %s\n' "${baseconfig}"
+ return 1
+ }
+ else
+ mv "${configdir}/.config.in" "${configdir}/.config"
+ fi
+ if [ "${configtype}" != "def" ]; then
+ make -C "${topdir}" O="${configdir}" "${configtype}config" > "${configdir}.log" || {
+ printf ' *** make %sconfig failed for %s\n' "${configtype}" "${baseconfig}"
+ return 1
+ }
+ fi
+
+ # Add the sha of the config file to its name, so we can uniquely
+ # identify it. This allows us to remove duplicates, e.g. defconfig
+ # and allnoconfig.
+ fullconfigname="${configname}-$(sha1sum "${configdir}/.config" | cut -c -40)"
+ if [ -e "${fullconfigname}.success" ]; then
+ printf ' %s already built successfully; skipping\n' "${fullconfigname}"
+ return 0
+ fi
+ printf ' Generated %s\n' "${fullconfigname}"
+
+ # Save the defconfig of this config for future reference.
+ make -C "${topdir}" --no-print-directory O="${configdir}" savedefconfig > /dev/null || {
+ printf ' *** Failed savedefconfig for %s\n' "${fullconfigname}"
+ return 1
+ }
+ cp "${configdir}/defconfig" "${fullconfigname}.defconfig"
+
+ outdir="${PWD}/${fullconfigname}.output"
+ logfile="${fullconfigname}.log"
+ mkdir -p "${outdir}"
+ cp "${configdir}/.config" "${outdir}"
+ make -C "${topdir}" O="${outdir}" > "${logfile}" 2>&1 || {
+ printf ' *** Failed %s - see log file for details\n' "${fullconfigname}"
+ touch "${fullconfigname}.failed"
+ #rm -rf ${outdir}
+ return 1
+ }
+
+ printf ' Successfully built %s %sconfig\n' "${baseconfig}" "${configtype}"
+ touch "${fullconfigname}.success"
+ rm -rf "${outdir}"
+ bzip2 "${logfile}"
+}
+
+
+if [ "${1}" ]; then
+ testspecs="$*"
+elif [ -r testspecs ]; then
+ testspecs="$(cat testspecs)"
+else
+ testspecs="$(cat ${testdir}/testspecs)"
+fi
+
+for testspec in ${testspecs}; do
+ baseconfig="${testspec%=*}"
+ configtypes="${testspec#*=}"
+ for configtype in ${configtypes//,/ }; do
+ runbuild "${baseconfig}" "${configtype}"
+ done
+done
diff --git a/test/testspecs b/test/testspecs
new file mode 100644
index 0000000..2e3be3d
--- /dev/null
+++ b/test/testspecs
@@ -0,0 +1,24 @@
+configs/armadeus_apf9328_defconfig=def,randpackage
+configs/at91rm9200df_defconfig=def,randpackage
+configs/at91sam9260dfc_defconfig=def,randpackage
+configs/at91sam9261ek_defconfig=def,randpackage
+configs/at91sam9263ek_defconfig=def,randpackage
+configs/at91sam9g20dfc_defconfig=def,randpackage
+configs/atngw100_defconfig=def,randpackage
+configs/atstk100x_defconfig=def,randpackage
+configs/ea3250_defconfig=def,randpackage
+configs/fdi3250_defconfig=def,randpackage
+configs/integrator926_defconfig=def,randpackage
+configs/kb9202_defconfig=def,randpackage
+configs/mini2440_defconfig=def,randpackage
+configs/mx53loco_defconfig=def,randpackage
+configs/phy3250_defconfig=def,randpackage
+configs/qemu_arm_versatile_defconfig=def,randpackage
+configs/qemu_mips_malta_defconfig=def,randpackage
+configs/qemu_mipsel_malta_defconfig=def,randpackage
+configs/qemu_ppc_g3beige_defconfig=def,randpackage
+configs/qemu_sh4_r2d_defconfig=def,randpackage
+configs/qemu_sparc_ss10_defconfig=def,randpackage
+configs/qemu_x86_64_defconfig=def,randpackage
+configs/qemu_x86_defconfig=def,randpackage
+configs/sheevaplug_defconfig=def,randpackage
--
1.7.9.1
^ permalink raw reply related [flat|nested] 15+ messages in thread
* [Buildroot] [PATCH v2 1/3] Add target to print buildroot version
2012-03-04 13:03 [Buildroot] [PATCH v2 1/3] Add target to print buildroot version Arnout Vandecappelle
2012-03-04 13:03 ` [Buildroot] [PATCH v2 2/3] config: make it possible to specify which config file to use for 'make defconfig' Arnout Vandecappelle
2012-03-04 13:03 ` [Buildroot] [PATCH v2 3/3] Add test infrastructure Arnout Vandecappelle
@ 2012-03-04 13:05 ` Arnout Vandecappelle
2012-03-05 9:29 ` Luca Ceresoli
2012-03-05 9:34 ` Thomas Petazzoni
2012-03-05 9:33 ` Thomas Petazzoni
2012-03-05 9:57 ` Luca Ceresoli
4 siblings, 2 replies; 15+ messages in thread
From: Arnout Vandecappelle @ 2012-03-04 13:05 UTC (permalink / raw)
To: buildroot
On Sunday 04 March 2012 14:03:14 Arnout Vandecappelle (Essensium/Mind) wrote:
> From: "Arnout Vandecappelle (Essensium/Mind)" <arnout@mind.be>
Slightly off-topic: does anyone know how I get rid of this redundant
From: line?
Regards,
Arnout
--
Arnout Vandecappelle arnout at mind be
Senior Embedded Software Architect +32-16-286540
Essensium/Mind http://www.mind.be
G.Geenslaan 9, 3001 Leuven, Belgium BE 872 984 063 RPR Leuven
LinkedIn profile: http://www.linkedin.com/in/arnoutvandecappelle
GPG fingerprint: 7CB5 E4CC 6C2E EFD4 6E3D A754 F963 ECAB 2450 2F1F
^ permalink raw reply [flat|nested] 15+ messages in thread
* [Buildroot] [PATCH v2 3/3] Add test infrastructure
2012-03-04 13:03 ` [Buildroot] [PATCH v2 3/3] Add test infrastructure Arnout Vandecappelle
@ 2012-03-04 13:22 ` Arnout Vandecappelle
2012-03-05 9:39 ` Thomas Petazzoni
1 sibling, 0 replies; 15+ messages in thread
From: Arnout Vandecappelle @ 2012-03-04 13:22 UTC (permalink / raw)
To: buildroot
On Sunday 04 March 2012 14:03:16 Arnout Vandecappelle (Essensium/Mind) wrote:
> + cp "${baseconfigfile}" "${configdir}/.config.in"
> + printf 'BR2_HOST_DIR="%s"\n' "${hostdir}" >> "${configdir}/.config.in"
The purpose of this non-default hostdir was to be able to reuse the
toolchain for several tests. That doesn't work the way it's done now,
of course - it will still be rebuilt.
What I would need to do is:
1. build the toolchain using this config
2. change the config to use the external toolchain in ${hostdir}
3. run randpackageconfig
4. build with that randpackageconfig
I'm not sure how to do steps 1 and 2, though.
For step 1, I don't think there is a target for building the
toolchain, is there? For the internal toolchain it's a long list of
targets, for an external or crosstool-NG toolchain it's 'uclibc'.
For step 2, how can I reliably change the config file to reflect the
external toolchain? I'd need to remove a lot of symbols but also add
the external toolchain configuration options... Maybe we should create
a piece of .config that sets all this when an internal or crosstool-NG
toolchain is built?
Regards,
Arnout
--
Arnout Vandecappelle arnout at mind be
Senior Embedded Software Architect +32-16-286540
Essensium/Mind http://www.mind.be
G.Geenslaan 9, 3001 Leuven, Belgium BE 872 984 063 RPR Leuven
LinkedIn profile: http://www.linkedin.com/in/arnoutvandecappelle
GPG fingerprint: 7CB5 E4CC 6C2E EFD4 6E3D A754 F963 ECAB 2450 2F1F
^ permalink raw reply [flat|nested] 15+ messages in thread
* [Buildroot] [PATCH v2 1/3] Add target to print buildroot version
2012-03-04 13:05 ` [Buildroot] [PATCH v2 1/3] Add target to print buildroot version Arnout Vandecappelle
@ 2012-03-05 9:29 ` Luca Ceresoli
2012-03-06 7:11 ` Arnout Vandecappelle
2012-03-05 9:34 ` Thomas Petazzoni
1 sibling, 1 reply; 15+ messages in thread
From: Luca Ceresoli @ 2012-03-05 9:29 UTC (permalink / raw)
To: buildroot
Hi Arnout,
Arnout Vandecappelle wrote:
> On Sunday 04 March 2012 14:03:14 Arnout Vandecappelle (Essensium/Mind) wrote:
>> From: "Arnout Vandecappelle (Essensium/Mind)"<arnout@mind.be>
> Slightly off-topic: does anyone know how I get rid of this redundant
> From: line?
In your patches I also see .topdeps and .topmsg files, so may this
be is a topgit issue? I'm sorry I don't use it, so I cannot help.
I don't have this problem using plain git format-patch +
git send-mail.
Luca
^ permalink raw reply [flat|nested] 15+ messages in thread
* [Buildroot] [PATCH v2 1/3] Add target to print buildroot version
2012-03-04 13:03 [Buildroot] [PATCH v2 1/3] Add target to print buildroot version Arnout Vandecappelle
` (2 preceding siblings ...)
2012-03-04 13:05 ` [Buildroot] [PATCH v2 1/3] Add target to print buildroot version Arnout Vandecappelle
@ 2012-03-05 9:33 ` Thomas Petazzoni
2012-03-05 9:57 ` Luca Ceresoli
4 siblings, 0 replies; 15+ messages in thread
From: Thomas Petazzoni @ 2012-03-05 9:33 UTC (permalink / raw)
To: buildroot
Le Sun, 4 Mar 2012 14:03:14 +0100,
"Arnout Vandecappelle (Essensium/Mind)" <arnout@mind.be> a ?crit :
> From: "Arnout Vandecappelle (Essensium/Mind)" <arnout@mind.be>
>
> It's convenient to have a target to print the buildroot version, for use
> in external scripts calling buildroot.
>
> Signed-off-by: Arnout Vandecappelle (Essensium/Mind) <arnout@mind.be>
> ---
> .topdeps | 1 +
> .topmsg | 7 +++++++
Are you sure about these?
Thomas
--
Thomas Petazzoni, Free Electrons
Kernel, drivers, real-time and embedded Linux
development, consulting, training and support.
http://free-electrons.com
^ permalink raw reply [flat|nested] 15+ messages in thread
* [Buildroot] [PATCH v2 1/3] Add target to print buildroot version
2012-03-04 13:05 ` [Buildroot] [PATCH v2 1/3] Add target to print buildroot version Arnout Vandecappelle
2012-03-05 9:29 ` Luca Ceresoli
@ 2012-03-05 9:34 ` Thomas Petazzoni
1 sibling, 0 replies; 15+ messages in thread
From: Thomas Petazzoni @ 2012-03-05 9:34 UTC (permalink / raw)
To: buildroot
Le Sun, 4 Mar 2012 14:05:35 +0100,
Arnout Vandecappelle <arnout@mind.be> a ?crit :
> Slightly off-topic: does anyone know how I get rid of this redundant
> From: line?
I'm not sure how you generate your patches, but I never have this From:
line on my patches.
Thomas
--
Thomas Petazzoni, Free Electrons
Kernel, drivers, real-time and embedded Linux
development, consulting, training and support.
http://free-electrons.com
^ permalink raw reply [flat|nested] 15+ messages in thread
* [Buildroot] [PATCH v2 2/3] config: make it possible to specify which config file to use for 'make defconfig'
2012-03-04 13:03 ` [Buildroot] [PATCH v2 2/3] config: make it possible to specify which config file to use for 'make defconfig' Arnout Vandecappelle
@ 2012-03-05 9:37 ` Thomas Petazzoni
2012-03-05 9:58 ` Luca Ceresoli
2012-03-05 21:58 ` Felipe Contreras
2 siblings, 0 replies; 15+ messages in thread
From: Thomas Petazzoni @ 2012-03-05 9:37 UTC (permalink / raw)
To: buildroot
Le Sun, 4 Mar 2012 14:03:15 +0100,
"Arnout Vandecappelle (Essensium/Mind)" <arnout@mind.be> a ?crit :
> From: "Arnout Vandecappelle (Essensium/Mind)" <arnout@mind.be>
>
> So that this works:
>
> % make defconfig DEFCONFIG=~/busybox-defconfig
>
> Right now we have to do:
>
> % cp ~/busybox-defconfig configs/busybox_defconfig
> % make busybox_defconfig
>
> That would dirty the buildroot tree and requires it to be writable.
>
> Signed-off-by: Felipe Contreras <felipe.contreras@gmail.com>
> Signed-off-by: Arnout Vandecappelle (Essensium/Mind) <arnout@mind.be>
Please change "busybox" to "buildroot" in the commit log. Otherwise,
it's confusing since one might think you're talking about the Busybox
configuration file.
> + @$(COMMON_CONFIG_ENV) $< --defconfig$(patsubst %,=%,$(BR2_DEFCONFIG)) $(CONFIG_CONFIG_IN)
I'm not sure I understand why patsubst is used here. Something like:
$(if $(BR2_DEFCONFIG),=$(BR2_DEFCONFIG))
would look more natural to me. Unless I'm missing something, of course.
Thomas
--
Thomas Petazzoni, Free Electrons
Kernel, drivers, real-time and embedded Linux
development, consulting, training and support.
http://free-electrons.com
^ permalink raw reply [flat|nested] 15+ messages in thread
* [Buildroot] [PATCH v2 3/3] Add test infrastructure
2012-03-04 13:03 ` [Buildroot] [PATCH v2 3/3] Add test infrastructure Arnout Vandecappelle
2012-03-04 13:22 ` Arnout Vandecappelle
@ 2012-03-05 9:39 ` Thomas Petazzoni
2012-03-06 7:09 ` Arnout Vandecappelle
1 sibling, 1 reply; 15+ messages in thread
From: Thomas Petazzoni @ 2012-03-05 9:39 UTC (permalink / raw)
To: buildroot
Le Sun, 4 Mar 2012 14:03:16 +0100,
"Arnout Vandecappelle (Essensium/Mind)" <arnout@mind.be> a ?crit :
> The test infrastructure is a script and a list of tests to be run.
> Additional test configurations can be added later to the test directory.
I know Peter has some test scripts as well, and so I have. Maybe we
should first share what we have, and see what we can factorize?
In any case, this test infrastructure discussion should really be part
of a separate set of patches. While your first two patches can be
merged without much discussion, this third patch really requires some
discussion. I don't want this test infrastructure to be the thing used
only by one person, it needs to be used and usable by others.
Regards,
Thomas
--
Thomas Petazzoni, Free Electrons
Kernel, drivers, real-time and embedded Linux
development, consulting, training and support.
http://free-electrons.com
^ permalink raw reply [flat|nested] 15+ messages in thread
* [Buildroot] [PATCH v2 1/3] Add target to print buildroot version
2012-03-04 13:03 [Buildroot] [PATCH v2 1/3] Add target to print buildroot version Arnout Vandecappelle
` (3 preceding siblings ...)
2012-03-05 9:33 ` Thomas Petazzoni
@ 2012-03-05 9:57 ` Luca Ceresoli
4 siblings, 0 replies; 15+ messages in thread
From: Luca Ceresoli @ 2012-03-05 9:57 UTC (permalink / raw)
To: buildroot
Arnout Vandecappelle (Essensium/Mind) wrote:
> From: "Arnout Vandecappelle (Essensium/Mind)"<arnout@mind.be>
>
> It's convenient to have a target to print the buildroot version, for use
> in external scripts calling buildroot.
>
> Signed-off-by: Arnout Vandecappelle (Essensium/Mind)<arnout@mind.be>
> ---
> .topdeps | 1 +
> .topmsg | 7 +++++++
Apart from these files (and possibly the unneeded From: line),
Acked-by: Luca Ceresoli <luca@lucaceresoli.net>
^ permalink raw reply [flat|nested] 15+ messages in thread
* [Buildroot] [PATCH v2 2/3] config: make it possible to specify which config file to use for 'make defconfig'
2012-03-04 13:03 ` [Buildroot] [PATCH v2 2/3] config: make it possible to specify which config file to use for 'make defconfig' Arnout Vandecappelle
2012-03-05 9:37 ` Thomas Petazzoni
@ 2012-03-05 9:58 ` Luca Ceresoli
2012-03-05 21:58 ` Felipe Contreras
2 siblings, 0 replies; 15+ messages in thread
From: Luca Ceresoli @ 2012-03-05 9:58 UTC (permalink / raw)
To: buildroot
Arnout Vandecappelle (Essensium/Mind) wrote:
> From: "Arnout Vandecappelle (Essensium/Mind)"<arnout@mind.be>
>
> So that this works:
>
> % make defconfig DEFCONFIG=~/busybox-defconfig
>
> Right now we have to do:
>
> % cp ~/busybox-defconfig configs/busybox_defconfig
> % make busybox_defconfig
>
> That would dirty the buildroot tree and requires it to be writable.
>
> Signed-off-by: Felipe Contreras<felipe.contreras@gmail.com>
> Signed-off-by: Arnout Vandecappelle (Essensium/Mind)<arnout@mind.be>
> ---
> Makefile | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/Makefile b/Makefile
> index 30099d9..b450b8f 100644
> --- a/Makefile
> +++ b/Makefile
> @@ -602,7 +602,7 @@ silentoldconfig: $(BUILD_DIR)/buildroot-config/conf outputmakefile
>
> defconfig: $(BUILD_DIR)/buildroot-config/conf outputmakefile
> @mkdir -p $(BUILD_DIR)/buildroot-config
> - @$(COMMON_CONFIG_ENV) $< --defconfig $(CONFIG_CONFIG_IN)
> + @$(COMMON_CONFIG_ENV) $< --defconfig$(patsubst %,=%,$(BR2_DEFCONFIG)) $(CONFIG_CONFIG_IN)
>
> %_defconfig: $(BUILD_DIR)/buildroot-config/conf $(TOPDIR)/configs/%_defconfig outputmakefile
> @mkdir -p $(BUILD_DIR)/buildroot-config
Acked-by: Luca Ceresoli <luca@lucaceresoli.net>
^ permalink raw reply [flat|nested] 15+ messages in thread
* [Buildroot] [PATCH v2 2/3] config: make it possible to specify which config file to use for 'make defconfig'
2012-03-04 13:03 ` [Buildroot] [PATCH v2 2/3] config: make it possible to specify which config file to use for 'make defconfig' Arnout Vandecappelle
2012-03-05 9:37 ` Thomas Petazzoni
2012-03-05 9:58 ` Luca Ceresoli
@ 2012-03-05 21:58 ` Felipe Contreras
2 siblings, 0 replies; 15+ messages in thread
From: Felipe Contreras @ 2012-03-05 21:58 UTC (permalink / raw)
To: buildroot
On Sun, Mar 4, 2012 at 3:03 PM, Arnout Vandecappelle (Essensium/Mind)
<arnout@mind.be> wrote:
> From: "Arnout Vandecappelle (Essensium/Mind)" <arnout@mind.be>
Is this really from you?
> So that this works:
>
> ?% make defconfig DEFCONFIG=~/busybox-defconfig
> - ? ? ? @$(COMMON_CONFIG_ENV) $< --defconfig $(CONFIG_CONFIG_IN)
> + ? ? ? @$(COMMON_CONFIG_ENV) $< --defconfig$(patsubst %,=%,$(BR2_DEFCONFIG)) $(CONFIG_CONFIG_IN)
Looks like an inconsistency there. AFAICS, it would be 'make defconfig
BR2_DEFCONFIG=foo'.
Cheers.
--
Felipe Contreras
^ permalink raw reply [flat|nested] 15+ messages in thread
* [Buildroot] [PATCH v2 3/3] Add test infrastructure
2012-03-05 9:39 ` Thomas Petazzoni
@ 2012-03-06 7:09 ` Arnout Vandecappelle
0 siblings, 0 replies; 15+ messages in thread
From: Arnout Vandecappelle @ 2012-03-06 7:09 UTC (permalink / raw)
To: buildroot
On Monday 05 March 2012 10:39:58 Thomas Petazzoni wrote:
> Le Sun, 4 Mar 2012 14:03:16 +0100,
> "Arnout Vandecappelle (Essensium/Mind)" <arnout@mind.be> a ?crit :
>
> > The test infrastructure is a script and a list of tests to be run.
> > Additional test configurations can be added later to the test directory.
>
> I know Peter has some test scripts as well, and so I have. Maybe we
> should first share what we have, and see what we can factorize?
I was hoping that this patch would spur you guys on to do exactly that :-)
> In any case, this test infrastructure discussion should really be part
> of a separate set of patches. While your first two patches can be
> merged without much discussion, this third patch really requires some
> discussion. I don't want this test infrastructure to be the thing used
> only by one person, it needs to be used and usable by others.
Agreed. But the third patch depends on the other two, that's why I send
it as a single series. Peter usually does pick up individual patches from
a series so I don't see a problem with that.
Regards,
Arnout
--
Arnout Vandecappelle arnout at mind be
Senior Embedded Software Architect +32-16-286540
Essensium/Mind http://www.mind.be
G.Geenslaan 9, 3001 Leuven, Belgium BE 872 984 063 RPR Leuven
LinkedIn profile: http://www.linkedin.com/in/arnoutvandecappelle
GPG fingerprint: 7CB5 E4CC 6C2E EFD4 6E3D A754 F963 ECAB 2450 2F1F
^ permalink raw reply [flat|nested] 15+ messages in thread
* [Buildroot] [PATCH v2 1/3] Add target to print buildroot version
2012-03-05 9:29 ` Luca Ceresoli
@ 2012-03-06 7:11 ` Arnout Vandecappelle
0 siblings, 0 replies; 15+ messages in thread
From: Arnout Vandecappelle @ 2012-03-06 7:11 UTC (permalink / raw)
To: buildroot
On Monday 05 March 2012 10:29:29 Luca Ceresoli wrote:
> Hi Arnout,
>
> Arnout Vandecappelle wrote:
> > On Sunday 04 March 2012 14:03:14 Arnout Vandecappelle (Essensium/Mind) wrote:
> >> From: "Arnout Vandecappelle (Essensium/Mind)"<arnout@mind.be>
> > Slightly off-topic: does anyone know how I get rid of this redundant
> > From: line?
>
> In your patches I also see .topdeps and .topmsg files, so may this
> be is a topgit issue? I'm sorry I don't use it, so I cannot help.
I didn't even notice those myself :-) I just playing with topgit, so
that's not the cause.
> I don't have this problem using plain git format-patch +
> git send-mail.
I use git send-mail directly. Maybe that's it...
Regards,
Arnout
--
Arnout Vandecappelle arnout at mind be
Senior Embedded Software Architect +32-16-286540
Essensium/Mind http://www.mind.be
G.Geenslaan 9, 3001 Leuven, Belgium BE 872 984 063 RPR Leuven
LinkedIn profile: http://www.linkedin.com/in/arnoutvandecappelle
GPG fingerprint: 7CB5 E4CC 6C2E EFD4 6E3D A754 F963 ECAB 2450 2F1F
^ permalink raw reply [flat|nested] 15+ messages in thread
end of thread, other threads:[~2012-03-06 7:11 UTC | newest]
Thread overview: 15+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2012-03-04 13:03 [Buildroot] [PATCH v2 1/3] Add target to print buildroot version Arnout Vandecappelle
2012-03-04 13:03 ` [Buildroot] [PATCH v2 2/3] config: make it possible to specify which config file to use for 'make defconfig' Arnout Vandecappelle
2012-03-05 9:37 ` Thomas Petazzoni
2012-03-05 9:58 ` Luca Ceresoli
2012-03-05 21:58 ` Felipe Contreras
2012-03-04 13:03 ` [Buildroot] [PATCH v2 3/3] Add test infrastructure Arnout Vandecappelle
2012-03-04 13:22 ` Arnout Vandecappelle
2012-03-05 9:39 ` Thomas Petazzoni
2012-03-06 7:09 ` Arnout Vandecappelle
2012-03-04 13:05 ` [Buildroot] [PATCH v2 1/3] Add target to print buildroot version Arnout Vandecappelle
2012-03-05 9:29 ` Luca Ceresoli
2012-03-06 7:11 ` Arnout Vandecappelle
2012-03-05 9:34 ` Thomas Petazzoni
2012-03-05 9:33 ` Thomas Petazzoni
2012-03-05 9:57 ` Luca Ceresoli
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.