All of lore.kernel.org
 help / color / mirror / Atom feed
From: Michal Hocko <mhocko@suse.cz>
To: Glauber Costa <glommer@parallels.com>
Cc: KAMEZAWA Hiroyuki <kamezawa.hiroyu@jp.fujitsu.com>,
	linux-mm@kvack.org, cgroups@vger.kernel.org,
	Johannes Weiner <hannes@cmpxchg.org>,
	Hugh Dickins <hughd@google.com>, Han Ying <yinghan@google.com>,
	"Aneesh Kumar K.V" <aneesh.kumar@linux.vnet.ibm.com>,
	Andrew Morton <akpm@linux-foundation.org>,
	suleiman@google.com, n-horiguchi@ah.jp.nec.com,
	khlebnikov@openvz.org, Tejun Heo <tj@kernel.org>
Subject: Re: [RFC][PATCH 1/3] memcg: add methods to access pc->mem_cgroup
Date: Mon, 19 Mar 2012 16:33:35 +0100	[thread overview]
Message-ID: <20120319153334.GC31213@tiehlicka.suse.cz> (raw)
In-Reply-To: <4F671138.3000508@parallels.com>

On Mon 19-03-12 14:58:00, Glauber Costa wrote:
> On 03/19/2012 11:59 AM, KAMEZAWA Hiroyuki wrote:
> > In order to encode pc->mem_cgroup and pc->flags to be in a word,
> > access function to pc->mem_cgroup is required.
> > 
> > This patch replaces access to pc->mem_cgroup with
> >   pc_to_mem_cgroup(pc)          : pc->mem_cgroup
> >   pc_set_mem_cgroup(pc, memcg)  : pc->mem_cgroup = memcg
> > 
> > Following patch will remove pc->mem_cgroup.
> > 
> > Signed-off-by: KAMEZAWA Hiroyuki<kamezawa.hiroyu@jp.fujitsu.com>
> Kame,
> 
> I can't see a reason not to merge this patch right now, regardless of
> the other ones.
 
I am not so sure about that. The patch doesn't do much on its own and
reference to the "following patch" might be confusing. Does it actually
help to rush it now?
-- 
Michal Hocko
SUSE Labs
SUSE LINUX s.r.o.
Lihovarska 1060/12
190 00 Praha 9    
Czech Republic

--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org.  For more info on Linux MM,
see: http://www.linux-mm.org/ .
Fight unfair telecom internet charges in Canada: sign http://stopthemeter.ca/
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>

WARNING: multiple messages have this Message-ID (diff)
From: Michal Hocko <mhocko-AlSwsSmVLrQ@public.gmane.org>
To: Glauber Costa <glommer-bzQdu9zFT3WakBO8gow8eQ@public.gmane.org>
Cc: KAMEZAWA Hiroyuki
	<kamezawa.hiroyu-+CUm20s59erQFUHtdCDX3A@public.gmane.org>,
	linux-mm-Bw31MaZKKs3YtjvyW6yDsg@public.gmane.org,
	cgroups-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
	Johannes Weiner <hannes-druUgvl0LCNAfugRpC6u6w@public.gmane.org>,
	Hugh Dickins <hughd-hpIqsD4AKlfQT0dZR+AlfA@public.gmane.org>,
	Han Ying <yinghan-hpIqsD4AKlfQT0dZR+AlfA@public.gmane.org>,
	"Aneesh Kumar K.V"
	<aneesh.kumar-23VcF4HTsmIX0ybBhKVfKdBPR1lH4CV8@public.gmane.org>,
	Andrew Morton
	<akpm-de/tnXTf+JLsfHDXvbKv3WD2FQJk+8+b@public.gmane.org>,
	suleiman-hpIqsD4AKlfQT0dZR+AlfA@public.gmane.org,
	n-horiguchi-PaJj6Psr51x8UrSeD/g0lQ@public.gmane.org,
	khlebnikov-GEFAQzZX7r8dnm+yROfE0A@public.gmane.org,
	Tejun Heo <tj-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>
Subject: Re: [RFC][PATCH 1/3] memcg: add methods to access pc->mem_cgroup
Date: Mon, 19 Mar 2012 16:33:35 +0100	[thread overview]
Message-ID: <20120319153334.GC31213@tiehlicka.suse.cz> (raw)
In-Reply-To: <4F671138.3000508-bzQdu9zFT3WakBO8gow8eQ@public.gmane.org>

On Mon 19-03-12 14:58:00, Glauber Costa wrote:
> On 03/19/2012 11:59 AM, KAMEZAWA Hiroyuki wrote:
> > In order to encode pc->mem_cgroup and pc->flags to be in a word,
> > access function to pc->mem_cgroup is required.
> > 
> > This patch replaces access to pc->mem_cgroup with
> >   pc_to_mem_cgroup(pc)          : pc->mem_cgroup
> >   pc_set_mem_cgroup(pc, memcg)  : pc->mem_cgroup = memcg
> > 
> > Following patch will remove pc->mem_cgroup.
> > 
> > Signed-off-by: KAMEZAWA Hiroyuki<kamezawa.hiroyu-+CUm20s59erQFUHtdCDX3A@public.gmane.org>
> Kame,
> 
> I can't see a reason not to merge this patch right now, regardless of
> the other ones.
 
I am not so sure about that. The patch doesn't do much on its own and
reference to the "following patch" might be confusing. Does it actually
help to rush it now?
-- 
Michal Hocko
SUSE Labs
SUSE LINUX s.r.o.
Lihovarska 1060/12
190 00 Praha 9    
Czech Republic

  parent reply	other threads:[~2012-03-19 15:33 UTC|newest]

Thread overview: 32+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-03-19  7:56 [RFC][PATCH 0/3] page cgroup diet KAMEZAWA Hiroyuki
2012-03-19  7:59 ` [RFC][PATCH 1/3] memcg: add methods to access pc->mem_cgroup KAMEZAWA Hiroyuki
2012-03-19 10:58   ` Glauber Costa
2012-03-19 12:11     ` KAMEZAWA Hiroyuki
2012-03-19 12:11       ` KAMEZAWA Hiroyuki
2012-03-19 12:29       ` Glauber Costa
2012-03-19 15:33     ` Michal Hocko [this message]
2012-03-19 15:33       ` Michal Hocko
2012-03-19 15:34       ` Glauber Costa
2012-03-21  1:06       ` KAMEZAWA Hiroyuki
2012-03-21  1:06         ` KAMEZAWA Hiroyuki
2012-03-22 13:11   ` Michal Hocko
2012-03-22 13:11     ` Michal Hocko
2012-03-19  8:01 ` [RFC][PATCH 2/3] memcg: reduce size of struct page_cgroup KAMEZAWA Hiroyuki
2012-03-19 22:20   ` Suleiman Souhlal
2012-03-21  0:47     ` KAMEZAWA Hiroyuki
2012-03-21  0:47       ` KAMEZAWA Hiroyuki
2012-03-22 13:11   ` Michal Hocko
2012-03-22 13:11     ` Michal Hocko
2012-03-19  8:03 ` [RFC][PATCH 3/3] memcg: atomic update of memcg pointer and other bits KAMEZAWA Hiroyuki
2012-03-19  8:03   ` KAMEZAWA Hiroyuki
2012-03-22 13:38   ` Michal Hocko
2012-03-23  1:03     ` KAMEZAWA Hiroyuki
2012-03-23  8:54       ` Michal Hocko
2012-03-19 19:59 ` [RFC][PATCH 0/3] page cgroup diet Konstantin Khlebnikov
2012-03-19 19:59   ` Konstantin Khlebnikov
2012-03-21  1:02   ` KAMEZAWA Hiroyuki
2012-03-21  1:02     ` KAMEZAWA Hiroyuki
2012-03-21  6:13     ` Konstantin Khlebnikov
2012-03-21  6:13       ` Konstantin Khlebnikov
2012-03-21  6:30       ` KAMEZAWA Hiroyuki
2012-03-21  6:30         ` KAMEZAWA Hiroyuki

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20120319153334.GC31213@tiehlicka.suse.cz \
    --to=mhocko@suse.cz \
    --cc=akpm@linux-foundation.org \
    --cc=aneesh.kumar@linux.vnet.ibm.com \
    --cc=cgroups@vger.kernel.org \
    --cc=glommer@parallels.com \
    --cc=hannes@cmpxchg.org \
    --cc=hughd@google.com \
    --cc=kamezawa.hiroyu@jp.fujitsu.com \
    --cc=khlebnikov@openvz.org \
    --cc=linux-mm@kvack.org \
    --cc=n-horiguchi@ah.jp.nec.com \
    --cc=suleiman@google.com \
    --cc=tj@kernel.org \
    --cc=yinghan@google.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.