All of lore.kernel.org
 help / color / mirror / Atom feed
From: Nikolaus Voss <n.voss@weinmann.de>
To: linux-arm-kernel@lists.infradead.org,
	linux-kernel@vger.kernel.org, linux-i2c@vger.kernel.org
Cc: nicolas.ferre@atmel.com, ben-linux@fluff.org, balbi@ti.com,
	<h.feurstein@gmail.com>, <rmallon@gmail.com>
Subject: [PATCH v9 4/4] G45 TWI: remove open drain setting for twi function gpios
Date: Tue, 8 Nov 2011 12:11:03 +0100	[thread overview]
Message-ID: <201203191534.q2JFYmKl012749@gatekeeper.vosshq.de> (raw)
In-Reply-To: <cover.1322479017a.git.n.voss@weinmann.de>

The G45 datasheets explicitly states that setting the open drain property
on peripheral function gpios is not allowed. (How about other A91 chips?)

Signed-off-by: Nikolaus Voss <n.voss@weinmann.de>
---
 arch/arm/mach-at91/at91sam9g45_devices.c |    6 ------
 1 files changed, 0 insertions(+), 6 deletions(-)

diff --git a/arch/arm/mach-at91/at91sam9g45_devices.c b/arch/arm/mach-at91/at91sam9g45_devices.c
index 96e2adc..050e6e2 100644
--- a/arch/arm/mach-at91/at91sam9g45_devices.c
+++ b/arch/arm/mach-at91/at91sam9g45_devices.c
@@ -685,18 +685,12 @@ void __init at91_add_device_i2c(short i2c_id, struct i2c_board_info *devices, in
 	/* pins used for TWI interface */
 	if (i2c_id == 0) {
 		at91_set_A_periph(AT91_PIN_PA20, 0);		/* TWD */
-		at91_set_multi_drive(AT91_PIN_PA20, 1);
-
 		at91_set_A_periph(AT91_PIN_PA21, 0);		/* TWCK */
-		at91_set_multi_drive(AT91_PIN_PA21, 1);
 
 		platform_device_register(&at91sam9g45_twi0_device);
 	} else {
 		at91_set_A_periph(AT91_PIN_PB10, 0);		/* TWD */
-		at91_set_multi_drive(AT91_PIN_PB10, 1);
-
 		at91_set_A_periph(AT91_PIN_PB11, 0);		/* TWCK */
-		at91_set_multi_drive(AT91_PIN_PB11, 1);
 
 		platform_device_register(&at91sam9g45_twi1_device);
 	}
-- 
1.7.5.4


WARNING: multiple messages have this Message-ID (diff)
From: Nikolaus Voss <n.voss@weinmann.de>
To: linux-arm-kernel@lists.infradead.org,
	linux-kernel@vger.kernel.org, linux-i2c@vger.kernel.org
Cc: nicolas.ferre@atmel.com, ben-linux@fluff.org, balbi@ti.com,
	h.feurstein@gmail.com, rmallon@gmail.com
Subject: [PATCH v9 4/4] G45 TWI: remove open drain setting for twi function gpios
Date: Tue, 8 Nov 2011 12:11:03 +0100	[thread overview]
Message-ID: <201203191534.q2JFYmKl012749@gatekeeper.vosshq.de> (raw)
In-Reply-To: <cover.1322479017a.git.n.voss@weinmann.de>

The G45 datasheets explicitly states that setting the open drain property
on peripheral function gpios is not allowed. (How about other A91 chips?)

Signed-off-by: Nikolaus Voss <n.voss@weinmann.de>
---
 arch/arm/mach-at91/at91sam9g45_devices.c |    6 ------
 1 files changed, 0 insertions(+), 6 deletions(-)

diff --git a/arch/arm/mach-at91/at91sam9g45_devices.c b/arch/arm/mach-at91/at91sam9g45_devices.c
index 96e2adc..050e6e2 100644
--- a/arch/arm/mach-at91/at91sam9g45_devices.c
+++ b/arch/arm/mach-at91/at91sam9g45_devices.c
@@ -685,18 +685,12 @@ void __init at91_add_device_i2c(short i2c_id, struct i2c_board_info *devices, in
 	/* pins used for TWI interface */
 	if (i2c_id == 0) {
 		at91_set_A_periph(AT91_PIN_PA20, 0);		/* TWD */
-		at91_set_multi_drive(AT91_PIN_PA20, 1);
-
 		at91_set_A_periph(AT91_PIN_PA21, 0);		/* TWCK */
-		at91_set_multi_drive(AT91_PIN_PA21, 1);
 
 		platform_device_register(&at91sam9g45_twi0_device);
 	} else {
 		at91_set_A_periph(AT91_PIN_PB10, 0);		/* TWD */
-		at91_set_multi_drive(AT91_PIN_PB10, 1);
-
 		at91_set_A_periph(AT91_PIN_PB11, 0);		/* TWCK */
-		at91_set_multi_drive(AT91_PIN_PB11, 1);
 
 		platform_device_register(&at91sam9g45_twi1_device);
 	}
-- 
1.7.5.4

  parent reply	other threads:[~2012-03-19 15:47 UTC|newest]

Thread overview: 39+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-03-19 15:07 [PATCH v9 0/4] AT91: replace broken TWI driver i2c-at91.c Nikolaus Voss
2012-03-19 15:07 ` Nikolaus Voss
2011-11-08 10:49 ` [PATCH v9 1/4] drivers/i2c/busses/i2c-at91.c: remove broken driver Nikolaus Voss
2011-11-08 10:49   ` Nikolaus Voss
2011-11-08 10:49 ` [PATCH v9 3/4] drivers/i2c/busses/i2c-at91.c: add new driver Nikolaus Voss
2011-11-08 10:49   ` Nikolaus Voss
2012-04-13 10:17   ` Hubert Feurstein
2012-04-13 10:17     ` Hubert Feurstein
2012-04-13 10:17     ` Hubert Feurstein
2012-04-13 10:39     ` Felipe Balbi
2012-04-13 10:39       ` Felipe Balbi
2012-04-13 10:39       ` Felipe Balbi
2012-04-13 11:44       ` [PATCH] i2c-at91: fix data-loss issue Hubert Feurstein
2012-04-13 11:44         ` Hubert Feurstein
2012-04-13 11:44         ` Hubert Feurstein
2012-04-13 22:06         ` Ryan Mallon
2012-04-13 22:06           ` Ryan Mallon
2012-04-13 22:06           ` Ryan Mallon
2012-04-16  7:30         ` Voss, Nikolaus
2012-04-16  7:30           ` Voss, Nikolaus
2012-04-16  7:30           ` Voss, Nikolaus
2012-04-16  9:27           ` Hubert Feurstein
2012-04-16  9:27             ` Hubert Feurstein
2012-04-16  9:27             ` Hubert Feurstein
2012-04-18 14:39           ` Wolfram Sang
2012-04-18 14:39             ` Wolfram Sang
2012-04-18 14:39             ` Wolfram Sang
2012-04-21 19:33             ` Adrian Yanes
2012-04-23  5:39               ` Voss, Nikolaus
2012-04-23  5:39                 ` Voss, Nikolaus
2012-04-23  5:39                 ` Voss, Nikolaus
2012-04-23  6:24                 ` Adrian Yanes
2012-04-23  6:24                   ` Adrian Yanes
2012-04-23  6:24                   ` Adrian Yanes
2012-04-25  5:26                   ` Adrian Yanes
2011-11-08 11:09 ` [PATCH v9 2/4] Replace clk_lookup.con_id with clk_lookup.dev_id entries for twi clk Nikolaus Voss
2011-11-08 11:09   ` Nikolaus Voss
2011-11-08 11:11 ` Nikolaus Voss [this message]
2011-11-08 11:11   ` [PATCH v9 4/4] G45 TWI: remove open drain setting for twi function gpios Nikolaus Voss

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=201203191534.q2JFYmKl012749@gatekeeper.vosshq.de \
    --to=n.voss@weinmann.de \
    --cc=balbi@ti.com \
    --cc=ben-linux@fluff.org \
    --cc=h.feurstein@gmail.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-i2c@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=nicolas.ferre@atmel.com \
    --cc=rmallon@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.