From: Greg KH <gregkh@linuxfoundation.org> To: Kent Yoder <key@linux.vnet.ibm.com> Cc: linux-kernel@vger.kernel.org, linux-crypto@vger.kernel.org, rcj@linux.vnet.ibm.com, benh@kernel.crashing.org, linuxppc-dev@lists.ozlabs.org Subject: Re: [PATCH 15/17] powerpc: crypto: sysfs routines and docs for the nx device driver Date: Wed, 21 Mar 2012 15:11:22 -0700 [thread overview] Message-ID: <20120321221122.GA30748@kroah.com> (raw) In-Reply-To: <1332366080.3858.52.camel@key-ThinkPad-W510> On Wed, Mar 21, 2012 at 04:41:20PM -0500, Kent Yoder wrote: > These routines add sysfs files supporting the Power7+ in-Nest encryption > accelerator driver. > > Signed-off-by: Kent Yoder <key@linux.vnet.ibm.com> > --- > Documentation/powerpc/pfo-nx-crypto.txt | 52 ++++++++ Please put sysfs file information in Documentation/ABI/ where it belongs. > arch/powerpc/crypto/nx/nx_sysfs.c | 194 +++++++++++++++++++++++++++++++ > 2 files changed, 246 insertions(+), 0 deletions(-) > create mode 100644 Documentation/powerpc/pfo-nx-crypto.txt > create mode 100644 arch/powerpc/crypto/nx/nx_sysfs.c > > diff --git a/Documentation/powerpc/pfo-nx-crypto.txt b/Documentation/powerpc/pfo-nx-crypto.txt > new file mode 100644 > index 0000000..63440d3 > --- /dev/null > +++ b/Documentation/powerpc/pfo-nx-crypto.txt > @@ -0,0 +1,52 @@ > + > +Documentation for the sysfs interfaces provided by the nx-crypto driver, built > +in arch/powerpc/crypto/nx. > + > +The driver provides 2 sets of sysfs files, 1 for confirming that the device is > +actually being used and 1 for error detection. Shouldn't the first just be debugfs files, as no "normal" user will ever care about such a thing? Actually, why are these sysfs files at all, how about all of this going into debugfs? > +Error Detection > +=============== <snip> What can anyone do with any of these files? What use are they to users? > +Device Use > +========== Again, what does a user care about these items for? > +int > +nx_sysfs_init(struct device_driver *drv) > +{ > + int rc; > + > + rc = driver_create_file(drv, &driver_attr_aes_ops); > + if (rc) > + goto out; <snip> Oh, ${DIETY}, no. Please don't create files one by one, we do have functions that do all of this for you automatically, why aren't you using them? > +void > +nx_sysfs_fini(struct device_driver *drv) > +{ > + driver_remove_file(drv, &driver_attr_sync_ops); > + driver_remove_file(drv, &driver_attr_aes_bytes); > + driver_remove_file(drv, &driver_attr_aes_ops); > + driver_remove_file(drv, &driver_attr_sha256_bytes); > + driver_remove_file(drv, &driver_attr_sha256_ops); > + driver_remove_file(drv, &driver_attr_sha512_bytes); > + driver_remove_file(drv, &driver_attr_sha512_ops); Same here, don't do this, do it all at once. > +} Who is calling these functions? Where in the device lifecycle are the files being created? Did you just race userspace with how they are created, or are you doing it "properly"? (hint, odds are, as you are trying to manually create and remove these by hand, you aren't doing it properly...) thanks, greg k-h
WARNING: multiple messages have this Message-ID (diff)
From: Greg KH <gregkh@linuxfoundation.org> To: Kent Yoder <key@linux.vnet.ibm.com> Cc: rcj@linux.vnet.ibm.com, linuxppc-dev@lists.ozlabs.org, linux-kernel@vger.kernel.org, linux-crypto@vger.kernel.org Subject: Re: [PATCH 15/17] powerpc: crypto: sysfs routines and docs for the nx device driver Date: Wed, 21 Mar 2012 15:11:22 -0700 [thread overview] Message-ID: <20120321221122.GA30748@kroah.com> (raw) In-Reply-To: <1332366080.3858.52.camel@key-ThinkPad-W510> On Wed, Mar 21, 2012 at 04:41:20PM -0500, Kent Yoder wrote: > These routines add sysfs files supporting the Power7+ in-Nest encryption > accelerator driver. > > Signed-off-by: Kent Yoder <key@linux.vnet.ibm.com> > --- > Documentation/powerpc/pfo-nx-crypto.txt | 52 ++++++++ Please put sysfs file information in Documentation/ABI/ where it belongs. > arch/powerpc/crypto/nx/nx_sysfs.c | 194 +++++++++++++++++++++++++++++++ > 2 files changed, 246 insertions(+), 0 deletions(-) > create mode 100644 Documentation/powerpc/pfo-nx-crypto.txt > create mode 100644 arch/powerpc/crypto/nx/nx_sysfs.c > > diff --git a/Documentation/powerpc/pfo-nx-crypto.txt b/Documentation/powerpc/pfo-nx-crypto.txt > new file mode 100644 > index 0000000..63440d3 > --- /dev/null > +++ b/Documentation/powerpc/pfo-nx-crypto.txt > @@ -0,0 +1,52 @@ > + > +Documentation for the sysfs interfaces provided by the nx-crypto driver, built > +in arch/powerpc/crypto/nx. > + > +The driver provides 2 sets of sysfs files, 1 for confirming that the device is > +actually being used and 1 for error detection. Shouldn't the first just be debugfs files, as no "normal" user will ever care about such a thing? Actually, why are these sysfs files at all, how about all of this going into debugfs? > +Error Detection > +=============== <snip> What can anyone do with any of these files? What use are they to users? > +Device Use > +========== Again, what does a user care about these items for? > +int > +nx_sysfs_init(struct device_driver *drv) > +{ > + int rc; > + > + rc = driver_create_file(drv, &driver_attr_aes_ops); > + if (rc) > + goto out; <snip> Oh, ${DIETY}, no. Please don't create files one by one, we do have functions that do all of this for you automatically, why aren't you using them? > +void > +nx_sysfs_fini(struct device_driver *drv) > +{ > + driver_remove_file(drv, &driver_attr_sync_ops); > + driver_remove_file(drv, &driver_attr_aes_bytes); > + driver_remove_file(drv, &driver_attr_aes_ops); > + driver_remove_file(drv, &driver_attr_sha256_bytes); > + driver_remove_file(drv, &driver_attr_sha256_ops); > + driver_remove_file(drv, &driver_attr_sha512_bytes); > + driver_remove_file(drv, &driver_attr_sha512_ops); Same here, don't do this, do it all at once. > +} Who is calling these functions? Where in the device lifecycle are the files being created? Did you just race userspace with how they are created, or are you doing it "properly"? (hint, odds are, as you are trying to manually create and remove these by hand, you aren't doing it properly...) thanks, greg k-h
next prev parent reply other threads:[~2012-03-21 22:11 UTC|newest] Thread overview: 60+ messages / expand[flat|nested] mbox.gz Atom feed top 2012-03-21 21:28 [PATCH 00/17] Platform Facilities Option and crypto accelerator driver Kent Yoder 2012-03-21 21:28 ` Kent Yoder 2012-03-21 21:37 ` [PATCH 01/17] powerpc: Add new hvcall constants to support PFO Kent Yoder 2012-03-21 21:37 ` Kent Yoder 2012-03-21 21:38 ` [PATCH 02/17] powerpc: Add pseries update notifier for OFDT prop changes Kent Yoder 2012-03-21 21:38 ` Kent Yoder 2012-03-21 21:38 ` [PATCH 03/17] powerpc: Add PFO support to the VIO bus Kent Yoder 2012-03-21 21:38 ` Kent Yoder 2012-03-21 21:38 ` [PATCH 04/17] hwrng: pseries - PFO-based hwrng driver Kent Yoder 2012-03-21 21:38 ` Kent Yoder 2012-03-21 21:39 ` [PATCH 05/17] pseries: Enabled the PFO-based RNG accelerator Kent Yoder 2012-03-21 21:39 ` Kent Yoder 2012-03-22 9:55 ` Anton Blanchard 2012-03-22 9:55 ` Anton Blanchard 2012-03-21 21:39 ` [PATCH 06/17] powerpc: crypto: AES-CBC mode routines for nx encryption Kent Yoder 2012-03-21 21:39 ` Kent Yoder 2012-03-21 21:39 ` [PATCH 07/17] powerpc: crypto: AES-CCM " Kent Yoder 2012-03-21 21:39 ` Kent Yoder 2012-03-21 21:40 ` [PATCH 08/17] powerpc: crypto: AES-CTR " Kent Yoder 2012-03-21 21:40 ` Kent Yoder 2012-03-21 21:40 ` [PATCH 09/17] powerpc: crypto: AES-ECB " Kent Yoder 2012-03-21 21:40 ` Kent Yoder 2012-03-21 21:40 ` [PATCH 10/17] powerpc: crypto: AES-GCM " Kent Yoder 2012-03-21 21:40 ` Kent Yoder 2012-03-21 21:40 ` [PATCH 11/17] powerpc: crypto: AES-XCBC " Kent Yoder 2012-03-21 21:40 ` Kent Yoder 2012-03-21 21:40 ` [PATCH 12/17] powerpc: crypto: SHA256 hash " Kent Yoder 2012-03-21 21:40 ` Kent Yoder 2012-03-21 21:40 ` [PATCH 13/17] powerpc: crypto: SHA512 " Kent Yoder 2012-03-21 21:40 ` Kent Yoder 2012-03-21 21:41 ` [PATCH 14/17] powerpc: crypto: nx driver code supporting " Kent Yoder 2012-03-21 21:41 ` Kent Yoder 2012-03-21 22:15 ` Greg KH 2012-03-21 22:15 ` Greg KH 2012-03-22 1:50 ` Benjamin Herrenschmidt 2012-03-22 1:50 ` Benjamin Herrenschmidt 2012-03-22 2:57 ` Benjamin Herrenschmidt 2012-03-22 2:57 ` Benjamin Herrenschmidt 2012-03-22 3:39 ` Greg KH 2012-03-22 3:39 ` Greg KH 2012-03-22 5:39 ` Benjamin Herrenschmidt 2012-03-22 5:39 ` Benjamin Herrenschmidt 2012-03-21 21:41 ` [PATCH 15/17] powerpc: crypto: sysfs routines and docs for the nx device driver Kent Yoder 2012-03-21 21:41 ` Kent Yoder 2012-03-21 22:11 ` Greg KH [this message] 2012-03-21 22:11 ` Greg KH 2012-03-21 22:46 ` Kent Yoder 2012-03-21 22:46 ` Kent Yoder 2012-03-21 21:41 ` [PATCH 16/17] powerpc: crypto: Build files " Kent Yoder 2012-03-21 21:41 ` Kent Yoder 2012-03-21 21:41 ` [PATCH 17/17] powerpc: crypto: enable the PFO-based encryption device Kent Yoder 2012-03-21 21:41 ` Kent Yoder 2012-03-22 17:17 ` [PATCH 00/17] Platform Facilities Option and crypto accelerator driver Kumar Gala 2012-03-22 17:17 ` Kumar Gala 2012-03-22 19:08 ` Kent Yoder 2012-03-22 19:08 ` Kent Yoder 2012-03-23 16:06 ` Kumar Gala 2012-03-23 16:06 ` Kumar Gala 2012-03-26 16:10 ` Kent Yoder 2012-03-26 16:10 ` Kent Yoder
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20120321221122.GA30748@kroah.com \ --to=gregkh@linuxfoundation.org \ --cc=benh@kernel.crashing.org \ --cc=key@linux.vnet.ibm.com \ --cc=linux-crypto@vger.kernel.org \ --cc=linux-kernel@vger.kernel.org \ --cc=linuxppc-dev@lists.ozlabs.org \ --cc=rcj@linux.vnet.ibm.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.