All of lore.kernel.org
 help / color / mirror / Atom feed
From: Andrew Morton <akpm@linux-foundation.org>
To: KAMEZAWA Hiroyuki <kamezawa.hiroyu@jp.fujitsu.com>
Cc: "linux-mm@kvack.org" <linux-mm@kvack.org>,
	Linux Kernel <linux-kernel@vger.kernel.org>,
	"cgroups@vger.kernel.org" <cgroups@vger.kernel.org>,
	Hugh Dickins <hughd@google.com>,
	"n-horiguchi@ah.jp.nec.com" <n-horiguchi@ah.jp.nec.com>,
	Johannes Weiner <hannes@cmpxchg.org>,
	Michal Hocko <mhocko@suse.cz>,
	Glauber Costa <glommer@parallels.com>
Subject: Re: [PATCH] memcg: change behavior of moving charges at task move
Date: Thu, 22 Mar 2012 17:30:00 -0700	[thread overview]
Message-ID: <20120322173000.f078a43f.akpm@linux-foundation.org> (raw)
In-Reply-To: <4F6BC166.80407@jp.fujitsu.com>

On Fri, 23 Mar 2012 09:18:46 +0900 KAMEZAWA Hiroyuki <kamezawa.hiroyu@jp.fujitsu.com> wrote:

> >> +#ifdef CONFIG_SWAP
> >> +	/*
> >> +	 * Avoid lookup_swap_cache() not to update statistics.
> >> +	 */
> > 
> > I don't understand this comment - what is it trying to tell us?
> > 
> 
> 
> High Dickins advised me to use find_get_page() rather than lookup_swap_cache()
> because lookup_swap_cache() has some statistics with swap.

ah.

--- a/mm/memcontrol.c~memcg-change-behavior-of-moving-charges-at-task-move-fix
+++ a/mm/memcontrol.c
@@ -5137,7 +5137,8 @@ static struct page *mc_handle_swap_pte(s
 		return NULL;
 #ifdef CONFIG_SWAP
 	/*
-	 * Avoid lookup_swap_cache() not to update statistics.
+	 * Use find_get_page() rather than lookup_swap_cache() because the
+	 * latter alters statistics.
 	 */
 	page = find_get_page(&swapper_space, ent.val);
 #endif

> >> +	page = find_get_page(&swapper_space, ent.val);
> > 
> > The code won't even compile if CONFIG_SWAP=n?
> > 
> 
> mm/built-in.o: In function `mc_handle_swap_pte':
> /home/kamezawa/Kernel/next/linux/mm/memcontrol.c:5172: undefined reference to `swapper_space'
> make: *** [.tmp_vmlinux1] Error 1
> 
> Ah...but I think this function (mc_handle_swap_pte) itself should be under CONFIG_SWAP.
> I'll post v2.

Confused.  The new reference to swapper_space is already inside #ifdef
CONFIG_SWAP.

WARNING: multiple messages have this Message-ID (diff)
From: Andrew Morton <akpm@linux-foundation.org>
To: KAMEZAWA Hiroyuki <kamezawa.hiroyu@jp.fujitsu.com>
Cc: "linux-mm@kvack.org" <linux-mm@kvack.org>,
	Linux Kernel <linux-kernel@vger.kernel.org>,
	"cgroups@vger.kernel.org" <cgroups@vger.kernel.org>,
	Hugh Dickins <hughd@google.com>,
	"n-horiguchi@ah.jp.nec.com" <n-horiguchi@ah.jp.nec.com>,
	Johannes Weiner <hannes@cmpxchg.org>,
	Michal Hocko <mhocko@suse.cz>,
	Glauber Costa <glommer@parallels.com>
Subject: Re: [PATCH] memcg: change behavior of moving charges at task move
Date: Thu, 22 Mar 2012 17:30:00 -0700	[thread overview]
Message-ID: <20120322173000.f078a43f.akpm@linux-foundation.org> (raw)
In-Reply-To: <4F6BC166.80407@jp.fujitsu.com>

On Fri, 23 Mar 2012 09:18:46 +0900 KAMEZAWA Hiroyuki <kamezawa.hiroyu@jp.fujitsu.com> wrote:

> >> +#ifdef CONFIG_SWAP
> >> +	/*
> >> +	 * Avoid lookup_swap_cache() not to update statistics.
> >> +	 */
> > 
> > I don't understand this comment - what is it trying to tell us?
> > 
> 
> 
> High Dickins advised me to use find_get_page() rather than lookup_swap_cache()
> because lookup_swap_cache() has some statistics with swap.

ah.

--- a/mm/memcontrol.c~memcg-change-behavior-of-moving-charges-at-task-move-fix
+++ a/mm/memcontrol.c
@@ -5137,7 +5137,8 @@ static struct page *mc_handle_swap_pte(s
 		return NULL;
 #ifdef CONFIG_SWAP
 	/*
-	 * Avoid lookup_swap_cache() not to update statistics.
+	 * Use find_get_page() rather than lookup_swap_cache() because the
+	 * latter alters statistics.
 	 */
 	page = find_get_page(&swapper_space, ent.val);
 #endif

> >> +	page = find_get_page(&swapper_space, ent.val);
> > 
> > The code won't even compile if CONFIG_SWAP=n?
> > 
> 
> mm/built-in.o: In function `mc_handle_swap_pte':
> /home/kamezawa/Kernel/next/linux/mm/memcontrol.c:5172: undefined reference to `swapper_space'
> make: *** [.tmp_vmlinux1] Error 1
> 
> Ah...but I think this function (mc_handle_swap_pte) itself should be under CONFIG_SWAP.
> I'll post v2.

Confused.  The new reference to swapper_space is already inside #ifdef
CONFIG_SWAP.

--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org.  For more info on Linux MM,
see: http://www.linux-mm.org/ .
Fight unfair telecom internet charges in Canada: sign http://stopthemeter.ca/
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>

  reply	other threads:[~2012-03-23  0:26 UTC|newest]

Thread overview: 26+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-03-21  9:52 [PATCH] memcg: change behavior of moving charges at task move KAMEZAWA Hiroyuki
2012-03-21  9:52 ` KAMEZAWA Hiroyuki
2012-03-22 15:17 ` Naoya Horiguchi
2012-03-22 15:17   ` Naoya Horiguchi
2012-03-22 21:29 ` Andrew Morton
2012-03-22 21:29   ` Andrew Morton
2012-03-23  0:05   ` KAMEZAWA Hiroyuki
2012-03-23  0:05     ` KAMEZAWA Hiroyuki
2012-03-22 21:36 ` Andrew Morton
2012-03-22 21:36   ` Andrew Morton
2012-03-22 21:36   ` Andrew Morton
2012-03-23  0:18   ` KAMEZAWA Hiroyuki
2012-03-23  0:18     ` KAMEZAWA Hiroyuki
2012-03-23  0:30     ` Andrew Morton [this message]
2012-03-23  0:30       ` Andrew Morton
2012-03-23  0:52       ` KAMEZAWA Hiroyuki
2012-03-23  0:52         ` KAMEZAWA Hiroyuki
2012-03-23  0:52         ` KAMEZAWA Hiroyuki
2012-03-23  8:53         ` Johannes Weiner
2012-03-23  8:53           ` Johannes Weiner
2012-03-23  9:00           ` KAMEZAWA Hiroyuki
2012-03-23  9:00             ` KAMEZAWA Hiroyuki
2012-03-23  9:00             ` KAMEZAWA Hiroyuki
2012-03-23  9:45             ` Michal Hocko
2012-03-23  9:45               ` Michal Hocko
2012-03-23  9:45               ` Michal Hocko

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20120322173000.f078a43f.akpm@linux-foundation.org \
    --to=akpm@linux-foundation.org \
    --cc=cgroups@vger.kernel.org \
    --cc=glommer@parallels.com \
    --cc=hannes@cmpxchg.org \
    --cc=hughd@google.com \
    --cc=kamezawa.hiroyu@jp.fujitsu.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    --cc=mhocko@suse.cz \
    --cc=n-horiguchi@ah.jp.nec.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.