From: Konstantin Khlebnikov <khlebnikov@openvz.org> To: linux-mm@kvack.org, Andrew Morton <akpm@linux-foundation.org>, linux-kernel@vger.kernel.org Subject: [PATCH v6 4/7] mm: mark mm-inline functions as __always_inline Date: Fri, 23 Mar 2012 01:56:31 +0400 [thread overview] Message-ID: <20120322215631.27814.14533.stgit@zurg> (raw) In-Reply-To: <20120322214944.27814.42039.stgit@zurg> GCC sometimes ignores "inline" directives even for small and simple functions. This supposed to be fixed in gcc 4.7, but it was released only yesterday. Signed-off-by: Konstantin Khlebnikov <khlebnikov@openvz.org> --- add/remove: 0/0 grow/shrink: 1/5 up/down: 3/-57 (-54) function old new delta mem_cgroup_charge_common 253 256 +3 lru_deactivate_fn 500 498 -2 lru_add_page_tail 364 361 -3 mem_cgroup_usage_unregister_event 501 493 -8 mem_cgroup_lru_del 73 65 -8 __mem_cgroup_commit_charge 676 640 -36 --- include/linux/mm_inline.h | 8 ++++---- 1 files changed, 4 insertions(+), 4 deletions(-) diff --git a/include/linux/mm_inline.h b/include/linux/mm_inline.h index 227fd3e..16d45d9 100644 --- a/include/linux/mm_inline.h +++ b/include/linux/mm_inline.h @@ -21,7 +21,7 @@ static inline int page_is_file_cache(struct page *page) return !PageSwapBacked(page); } -static inline void +static __always_inline void add_page_to_lru_list(struct zone *zone, struct page *page, enum lru_list lru) { struct lruvec *lruvec; @@ -31,7 +31,7 @@ add_page_to_lru_list(struct zone *zone, struct page *page, enum lru_list lru) __mod_zone_page_state(zone, NR_LRU_BASE + lru, hpage_nr_pages(page)); } -static inline void +static __always_inline void del_page_from_lru_list(struct zone *zone, struct page *page, enum lru_list lru) { mem_cgroup_lru_del_list(page, lru); @@ -61,7 +61,7 @@ static inline enum lru_list page_lru_base_type(struct page *page) * Returns the LRU list a page was on, as an index into the array of LRU * lists; and clears its Unevictable or Active flags, ready for freeing. */ -static inline enum lru_list page_off_lru(struct page *page) +static __always_inline enum lru_list page_off_lru(struct page *page) { enum lru_list lru; @@ -85,7 +85,7 @@ static inline enum lru_list page_off_lru(struct page *page) * Returns the LRU list a page should be on, as an index * into the array of LRU lists. */ -static inline enum lru_list page_lru(struct page *page) +static __always_inline enum lru_list page_lru(struct page *page) { enum lru_list lru;
WARNING: multiple messages have this Message-ID (diff)
From: Konstantin Khlebnikov <khlebnikov@openvz.org> To: linux-mm@kvack.org, Andrew Morton <akpm@linux-foundation.org>, linux-kernel@vger.kernel.org Subject: [PATCH v6 4/7] mm: mark mm-inline functions as __always_inline Date: Fri, 23 Mar 2012 01:56:31 +0400 [thread overview] Message-ID: <20120322215631.27814.14533.stgit@zurg> (raw) In-Reply-To: <20120322214944.27814.42039.stgit@zurg> GCC sometimes ignores "inline" directives even for small and simple functions. This supposed to be fixed in gcc 4.7, but it was released only yesterday. Signed-off-by: Konstantin Khlebnikov <khlebnikov@openvz.org> --- add/remove: 0/0 grow/shrink: 1/5 up/down: 3/-57 (-54) function old new delta mem_cgroup_charge_common 253 256 +3 lru_deactivate_fn 500 498 -2 lru_add_page_tail 364 361 -3 mem_cgroup_usage_unregister_event 501 493 -8 mem_cgroup_lru_del 73 65 -8 __mem_cgroup_commit_charge 676 640 -36 --- include/linux/mm_inline.h | 8 ++++---- 1 files changed, 4 insertions(+), 4 deletions(-) diff --git a/include/linux/mm_inline.h b/include/linux/mm_inline.h index 227fd3e..16d45d9 100644 --- a/include/linux/mm_inline.h +++ b/include/linux/mm_inline.h @@ -21,7 +21,7 @@ static inline int page_is_file_cache(struct page *page) return !PageSwapBacked(page); } -static inline void +static __always_inline void add_page_to_lru_list(struct zone *zone, struct page *page, enum lru_list lru) { struct lruvec *lruvec; @@ -31,7 +31,7 @@ add_page_to_lru_list(struct zone *zone, struct page *page, enum lru_list lru) __mod_zone_page_state(zone, NR_LRU_BASE + lru, hpage_nr_pages(page)); } -static inline void +static __always_inline void del_page_from_lru_list(struct zone *zone, struct page *page, enum lru_list lru) { mem_cgroup_lru_del_list(page, lru); @@ -61,7 +61,7 @@ static inline enum lru_list page_lru_base_type(struct page *page) * Returns the LRU list a page was on, as an index into the array of LRU * lists; and clears its Unevictable or Active flags, ready for freeing. */ -static inline enum lru_list page_off_lru(struct page *page) +static __always_inline enum lru_list page_off_lru(struct page *page) { enum lru_list lru; @@ -85,7 +85,7 @@ static inline enum lru_list page_off_lru(struct page *page) * Returns the LRU list a page should be on, as an index * into the array of LRU lists. */ -static inline enum lru_list page_lru(struct page *page) +static __always_inline enum lru_list page_lru(struct page *page) { enum lru_list lru; -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Fight unfair telecom internet charges in Canada: sign http://stopthemeter.ca/ Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2012-03-22 21:57 UTC|newest] Thread overview: 42+ messages / expand[flat|nested] mbox.gz Atom feed top 2012-03-22 21:56 [PATCH v6 0/7] mm: some simple cleanups Konstantin Khlebnikov 2012-03-22 21:56 ` Konstantin Khlebnikov 2012-03-22 21:56 ` [PATCH v6 1/7] mm/memcg: scanning_global_lru means mem_cgroup_disabled Konstantin Khlebnikov 2012-03-22 21:56 ` Konstantin Khlebnikov 2012-03-26 15:04 ` Michal Hocko 2012-03-26 15:04 ` Michal Hocko 2012-03-26 15:18 ` Johannes Weiner 2012-03-26 15:18 ` Johannes Weiner 2012-03-26 15:31 ` Michal Hocko 2012-03-26 15:31 ` Michal Hocko 2012-03-26 21:39 ` Hugh Dickins 2012-03-26 21:39 ` Hugh Dickins 2012-03-27 7:46 ` Michal Hocko 2012-03-27 7:46 ` Michal Hocko 2012-03-22 21:56 ` [PATCH v6 2/7] mm/memcg: move reclaim_stat into lruvec Konstantin Khlebnikov 2012-03-22 21:56 ` Konstantin Khlebnikov 2012-03-26 15:16 ` Michal Hocko 2012-03-26 15:16 ` Michal Hocko 2012-03-22 21:56 ` [PATCH v6 3/7] mm: push lru index into shrink_[in]active_list() Konstantin Khlebnikov 2012-03-22 21:56 ` Konstantin Khlebnikov 2012-03-23 4:48 ` Minchan Kim 2012-03-23 4:48 ` Minchan Kim 2012-03-26 15:39 ` Michal Hocko 2012-03-26 15:39 ` Michal Hocko 2012-03-22 21:56 ` Konstantin Khlebnikov [this message] 2012-03-22 21:56 ` [PATCH v6 4/7] mm: mark mm-inline functions as __always_inline Konstantin Khlebnikov 2012-03-22 21:56 ` [PATCH v6 5/7] mm: remove lru type checks from __isolate_lru_page() Konstantin Khlebnikov 2012-03-22 21:56 ` Konstantin Khlebnikov 2012-03-23 1:46 ` KAMEZAWA Hiroyuki 2012-03-23 1:46 ` KAMEZAWA Hiroyuki 2012-03-22 21:56 ` [PATCH v6 6/7] mm/memcg: kill mem_cgroup_lru_del() Konstantin Khlebnikov 2012-03-22 21:56 ` Konstantin Khlebnikov 2012-03-23 1:48 ` KAMEZAWA Hiroyuki 2012-03-23 1:48 ` KAMEZAWA Hiroyuki 2012-03-26 15:23 ` Michal Hocko 2012-03-26 15:23 ` Michal Hocko 2012-03-26 16:05 ` Konstantin Khlebnikov 2012-03-26 16:05 ` Konstantin Khlebnikov 2012-03-22 21:56 ` [PATCH v6 7/7] mm/memcg: use vm_swappiness from target memory cgroup Konstantin Khlebnikov 2012-03-22 21:56 ` Konstantin Khlebnikov 2012-03-26 15:59 ` Michal Hocko 2012-03-26 15:59 ` Michal Hocko
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20120322215631.27814.14533.stgit@zurg \ --to=khlebnikov@openvz.org \ --cc=akpm@linux-foundation.org \ --cc=linux-kernel@vger.kernel.org \ --cc=linux-mm@kvack.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.