From: HATAYAMA Daisuke <d.hatayama@jp.fujitsu.com>
To: wency@cn.fujitsu.com
Cc: jan.kiszka@siemens.com, qemu-devel@nongnu.org,
lcapitulino@redhat.com, anderson@redhat.com,
anthony@codemonkey.ws, eblake@redhat.com
Subject: Re: [Qemu-devel] [PATCH 11/11 v10] introduce a new monitor command 'dump-guest-memory' to dump guest's memory
Date: Fri, 23 Mar 2012 18:00:23 +0900 ( ) [thread overview]
Message-ID: <20120323.180023.276755898.d.hatayama@jp.fujitsu.com> (raw)
In-Reply-To: <4F680037.9090101@cn.fujitsu.com>
From: Wen Congyang <wency@cn.fujitsu.com>
Subject: [PATCH 11/11 v10] introduce a new monitor command 'dump-guest-memory' to dump guest's memory
Date: Tue, 20 Mar 2012 11:57:43 +0800
> +static int write_elf64_header(DumpState *s)
> +{
> + Elf64_Ehdr elf_header;
> + int ret;
> + int endian = s->dump_info.d_endian;
> +
> + memset(&elf_header, 0, sizeof(Elf64_Ehdr));
> + memcpy(&elf_header, ELFMAG, 4);
Use SELFMAG instead of 4.
> + elf_header.e_ident[EI_CLASS] = ELFCLASS64;
> + elf_header.e_ident[EI_DATA] = s->dump_info.d_endian;
> + elf_header.e_ident[EI_VERSION] = EV_CURRENT;
> + elf_header.e_type = cpu_convert_to_target16(ET_CORE, endian);
> + elf_header.e_machine = cpu_convert_to_target16(s->dump_info.d_machine,
> + endian);
> + elf_header.e_version = cpu_convert_to_target32(EV_CURRENT, endian);
> + elf_header.e_ehsize = cpu_convert_to_target16(sizeof(elf_header), endian);
> + elf_header.e_phoff = cpu_convert_to_target64(sizeof(Elf64_Ehdr), endian);
> + elf_header.e_phentsize = cpu_convert_to_target16(sizeof(Elf64_Phdr),
> + endian);
> + elf_header.e_phnum = cpu_convert_to_target16(s->phdr_num, endian);
> + if (s->have_section) {
> + uint64_t shoff = sizeof(Elf64_Ehdr) + sizeof(Elf64_Phdr) * s->sh_info;
> +
> + elf_header.e_shoff = cpu_convert_to_target64(shoff, endian);
> + elf_header.e_shentsize = cpu_convert_to_target16(sizeof(Elf64_Shdr),
> + endian);
> + elf_header.e_shnum = cpu_convert_to_target16(1, endian);
> + }
> +
> + ret = s->f(0, &elf_header, sizeof(elf_header), s->opaque);
> + if (ret < 0) {
> + dump_error(s, "dump: failed to write elf header.\n");
> + return -1;
> + }
> +
> + return 0;
> +}
> +
> +static int write_elf32_header(DumpState *s)
> +{
> + Elf32_Ehdr elf_header;
> + int ret;
> + int endian = s->dump_info.d_endian;
> +
> + memset(&elf_header, 0, sizeof(Elf32_Ehdr));
> + memcpy(&elf_header, ELFMAG, 4);
Also.
> + elf_header.e_ident[EI_CLASS] = ELFCLASS32;
> + elf_header.e_ident[EI_DATA] = endian;
> + elf_header.e_ident[EI_VERSION] = EV_CURRENT;
> + elf_header.e_type = cpu_convert_to_target16(ET_CORE, endian);
> + elf_header.e_machine = cpu_convert_to_target16(s->dump_info.d_machine,
> + endian);
> + elf_header.e_version = cpu_convert_to_target32(EV_CURRENT, endian);
> + elf_header.e_ehsize = cpu_convert_to_target16(sizeof(elf_header), endian);
> + elf_header.e_phoff = cpu_convert_to_target32(sizeof(Elf32_Ehdr), endian);
> + elf_header.e_phentsize = cpu_convert_to_target16(sizeof(Elf32_Phdr),
> + endian);
> + elf_header.e_phnum = cpu_convert_to_target16(s->phdr_num, endian);
> + if (s->have_section) {
> + uint32_t shoff = sizeof(Elf32_Ehdr) + sizeof(Elf32_Phdr) * s->sh_info;
> +
> + elf_header.e_shoff = cpu_convert_to_target32(shoff, endian);
> + elf_header.e_shentsize = cpu_convert_to_target16(sizeof(Elf32_Shdr),
> + endian);
> + elf_header.e_shnum = cpu_convert_to_target16(1, endian);
> + }
> +
> + ret = s->f(0, &elf_header, sizeof(elf_header), s->opaque);
> + if (ret < 0) {
> + dump_error(s, "dump: failed to write elf header.\n");
> + return -1;
> + }
> +
> + return 0;
> +}
Thanks.
HATAYAMA, Daisuke
next prev parent reply other threads:[~2012-03-23 9:00 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-03-20 3:57 [Qemu-devel] [PATCH 11/11 v10] introduce a new monitor command 'dump-guest-memory' to dump guest's memory Wen Congyang
2012-03-23 8:06 ` HATAYAMA Daisuke
2012-03-23 17:07 ` Luiz Capitulino
2012-03-26 2:00 ` Wen Congyang
2012-03-23 9:00 ` HATAYAMA Daisuke [this message]
2012-03-26 1:43 ` Wen Congyang
2012-03-23 9:40 ` HATAYAMA Daisuke
2012-03-26 1:39 ` Wen Congyang
2012-03-26 3:22 ` HATAYAMA Daisuke
2012-03-23 17:19 ` Luiz Capitulino
2012-03-26 1:53 ` Wen Congyang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120323.180023.276755898.d.hatayama@jp.fujitsu.com \
--to=d.hatayama@jp.fujitsu.com \
--cc=anderson@redhat.com \
--cc=anthony@codemonkey.ws \
--cc=eblake@redhat.com \
--cc=jan.kiszka@siemens.com \
--cc=lcapitulino@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=wency@cn.fujitsu.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.