From: Luiz Capitulino <lcapitulino@redhat.com>
To: HATAYAMA Daisuke <d.hatayama@jp.fujitsu.com>
Cc: jan.kiszka@siemens.com, qemu-devel@nongnu.org,
anderson@redhat.com, anthony@codemonkey.ws, eblake@redhat.com
Subject: Re: [Qemu-devel] [PATCH 11/11 v10] introduce a new monitor command 'dump-guest-memory' to dump guest's memory
Date: Fri, 23 Mar 2012 14:07:37 -0300 [thread overview]
Message-ID: <20120323140737.28265fae@doriath.home> (raw)
In-Reply-To: <20120323.170622.115912902.d.hatayama@jp.fujitsu.com>
On Fri, 23 Mar 2012 17:06:22 +0900 ( )
HATAYAMA Daisuke <d.hatayama@jp.fujitsu.com> wrote:
> From: Wen Congyang <wency@cn.fujitsu.com>
> Subject: [PATCH 11/11 v10] introduce a new monitor command 'dump-guest-memory' to dump guest's memory
> Date: Tue, 20 Mar 2012 11:57:43 +0800
>
> <cut>
>
> > +typedef struct DumpState {
> > + ArchDumpInfo dump_info;
> > + MemoryMappingList list;
> > + uint16_t phdr_num;
> > + uint32_t sh_info;
> > + bool have_section;
> > + bool resume;
> > + target_phys_addr_t memory_offset;
> > + write_core_dump_function f;
>
> f() is so general. Type information is meaningless enough, but there's
> no explicit occurence of the function call of f(). Could you consider
> renaming?
Agreed. I actually don't see why this indirection is needed.
next prev parent reply other threads:[~2012-03-23 17:07 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-03-20 3:57 [Qemu-devel] [PATCH 11/11 v10] introduce a new monitor command 'dump-guest-memory' to dump guest's memory Wen Congyang
2012-03-23 8:06 ` HATAYAMA Daisuke
2012-03-23 17:07 ` Luiz Capitulino [this message]
2012-03-26 2:00 ` Wen Congyang
2012-03-23 9:00 ` HATAYAMA Daisuke
2012-03-26 1:43 ` Wen Congyang
2012-03-23 9:40 ` HATAYAMA Daisuke
2012-03-26 1:39 ` Wen Congyang
2012-03-26 3:22 ` HATAYAMA Daisuke
2012-03-23 17:19 ` Luiz Capitulino
2012-03-26 1:53 ` Wen Congyang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120323140737.28265fae@doriath.home \
--to=lcapitulino@redhat.com \
--cc=anderson@redhat.com \
--cc=anthony@codemonkey.ws \
--cc=d.hatayama@jp.fujitsu.com \
--cc=eblake@redhat.com \
--cc=jan.kiszka@siemens.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.