* [PATCH] drm/i915: Initialise GTT MTRR to -1
@ 2012-03-23 17:38 Chris Wilson
2012-03-23 17:43 ` Adam Jackson
2012-03-23 18:45 ` Ben Widawsky
0 siblings, 2 replies; 5+ messages in thread
From: Chris Wilson @ 2012-03-23 17:38 UTC (permalink / raw)
To: intel-gfx; +Cc: Ben Widawsky
Fixes a regression from 9e984bc1 (drm/i915: Don't do MTRR setup if PAT
is enabled) where we left the MTRR as 0 and so tried to free a MTRR we
did not own during unload.
Reported-by: Ben Widawsky <ben@bwidawsk.net>
Cc: Ben Widawsky <ben@bwidawsk.net>
Cc: Adam Jackson <ajax@redhat.com>
Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
---
drivers/gpu/drm/i915/i915_dma.c | 2 ++
1 files changed, 2 insertions(+), 0 deletions(-)
diff --git a/drivers/gpu/drm/i915/i915_dma.c b/drivers/gpu/drm/i915/i915_dma.c
index 67946fa..32d5793 100644
--- a/drivers/gpu/drm/i915/i915_dma.c
+++ b/drivers/gpu/drm/i915/i915_dma.c
@@ -1928,6 +1928,8 @@ static void
i915_mtrr_setup(struct drm_i915_private *dev_priv, unsigned long base,
unsigned long size)
{
+ dev_priv->mm.gtt_mtrr = -1;
+
#if defined(CONFIG_X86_PAT)
if (cpu_has_pat)
return;
--
1.7.9.1
^ permalink raw reply related [flat|nested] 5+ messages in thread
* Re: [PATCH] drm/i915: Initialise GTT MTRR to -1
2012-03-23 17:38 [PATCH] drm/i915: Initialise GTT MTRR to -1 Chris Wilson
@ 2012-03-23 17:43 ` Adam Jackson
2012-03-23 18:45 ` Ben Widawsky
1 sibling, 0 replies; 5+ messages in thread
From: Adam Jackson @ 2012-03-23 17:43 UTC (permalink / raw)
To: Chris Wilson; +Cc: intel-gfx, Ben Widawsky
On 3/23/12 1:38 PM, Chris Wilson wrote:
> Fixes a regression from 9e984bc1 (drm/i915: Don't do MTRR setup if PAT
> is enabled) where we left the MTRR as 0 and so tried to free a MTRR we
> did not own during unload.
>
> Reported-by: Ben Widawsky <ben@bwidawsk.net>
> Cc: Ben Widawsky <ben@bwidawsk.net>
> Cc: Adam Jackson <ajax@redhat.com>
> Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
Brown-paper-bag-by: Adam Jackson <ajax@redhat.com>
Also reviewed-by. Thanks!
- ajax
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] drm/i915: Initialise GTT MTRR to -1
2012-03-23 17:38 [PATCH] drm/i915: Initialise GTT MTRR to -1 Chris Wilson
2012-03-23 17:43 ` Adam Jackson
@ 2012-03-23 18:45 ` Ben Widawsky
2012-03-27 22:05 ` Ben Widawsky
1 sibling, 1 reply; 5+ messages in thread
From: Ben Widawsky @ 2012-03-23 18:45 UTC (permalink / raw)
To: Chris Wilson; +Cc: intel-gfx
On Fri, 23 Mar 2012 17:38:49 +0000
Chris Wilson <chris@chris-wilson.co.uk> wrote:
> Fixes a regression from 9e984bc1 (drm/i915: Don't do MTRR setup if PAT
> is enabled) where we left the MTRR as 0 and so tried to free a MTRR we
> did not own during unload.
>
> Reported-by: Ben Widawsky <ben@bwidawsk.net>
> Cc: Ben Widawsky <ben@bwidawsk.net>
> Cc: Adam Jackson <ajax@redhat.com>
> Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
Reported-and-tested-by: Ben Widawsky <ben@bwidawsk.net>
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] drm/i915: Initialise GTT MTRR to -1
2012-03-23 18:45 ` Ben Widawsky
@ 2012-03-27 22:05 ` Ben Widawsky
2012-03-28 20:09 ` Daniel Vetter
0 siblings, 1 reply; 5+ messages in thread
From: Ben Widawsky @ 2012-03-27 22:05 UTC (permalink / raw)
To: Daniel Vetter; +Cc: intel-gfx
On Fri, 23 Mar 2012 11:45:57 -0700
Ben Widawsky <ben@bwidawsk.net> wrote:
> On Fri, 23 Mar 2012 17:38:49 +0000
> Chris Wilson <chris@chris-wilson.co.uk> wrote:
>
> > Fixes a regression from 9e984bc1 (drm/i915: Don't do MTRR setup if
> > PAT is enabled) where we left the MTRR as 0 and so tried to free a
> > MTRR we did not own during unload.
> >
> > Reported-by: Ben Widawsky <ben@bwidawsk.net>
> > Cc: Ben Widawsky <ben@bwidawsk.net>
> > Cc: Adam Jackson <ajax@redhat.com>
> > Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
>
> Reported-and-tested-by: Ben Widawsky <ben@bwidawsk.net>
Daniel, can you please pick this one up.
Ben
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] drm/i915: Initialise GTT MTRR to -1
2012-03-27 22:05 ` Ben Widawsky
@ 2012-03-28 20:09 ` Daniel Vetter
0 siblings, 0 replies; 5+ messages in thread
From: Daniel Vetter @ 2012-03-28 20:09 UTC (permalink / raw)
To: Ben Widawsky; +Cc: Daniel Vetter, intel-gfx
On Tue, Mar 27, 2012 at 03:05:01PM -0700, Ben Widawsky wrote:
> On Fri, 23 Mar 2012 11:45:57 -0700
> Ben Widawsky <ben@bwidawsk.net> wrote:
>
> > On Fri, 23 Mar 2012 17:38:49 +0000
> > Chris Wilson <chris@chris-wilson.co.uk> wrote:
> >
> > > Fixes a regression from 9e984bc1 (drm/i915: Don't do MTRR setup if
> > > PAT is enabled) where we left the MTRR as 0 and so tried to free a
> > > MTRR we did not own during unload.
> > >
> > > Reported-by: Ben Widawsky <ben@bwidawsk.net>
> > > Cc: Ben Widawsky <ben@bwidawsk.net>
> > > Cc: Adam Jackson <ajax@redhat.com>
> > > Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
> >
> > Reported-and-tested-by: Ben Widawsky <ben@bwidawsk.net>
>
> Daniel, can you please pick this one up.
Done. Pardon for the delay, I've somehow thought that this is a 3.4
regression, not post-3.4.
Yours, Daniel
--
Daniel Vetter
Mail: daniel@ffwll.ch
Mobile: +41 (0)79 365 57 48
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2012-03-28 20:08 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2012-03-23 17:38 [PATCH] drm/i915: Initialise GTT MTRR to -1 Chris Wilson
2012-03-23 17:43 ` Adam Jackson
2012-03-23 18:45 ` Ben Widawsky
2012-03-27 22:05 ` Ben Widawsky
2012-03-28 20:09 ` Daniel Vetter
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.