* [Qemu-devel] [PATCH] trace-events: Fix broken build caused by wrong format specifier
@ 2012-03-24 7:13 Stefan Weil
2012-03-25 9:21 ` Alon Levy
2012-03-26 11:35 ` [Qemu-devel] [Qemu-trivial] " Stefan Hajnoczi
0 siblings, 2 replies; 3+ messages in thread
From: Stefan Weil @ 2012-03-24 7:13 UTC (permalink / raw)
To: Alon Levy, qemu-devel; +Cc: qemu-trivial, Stefan Weil
mem is an uint64_t value, so %lx was wrong.
Signed-off-by: Stefan Weil <sw@weilnetz.de>
---
trace-events | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/trace-events b/trace-events
index 70f059d..db2cd39 100644
--- a/trace-events
+++ b/trace-events
@@ -726,7 +726,7 @@ ppm_save(const char *filename, void *display_surface) "%s surface=%p"
# hw/qxl.c
disable qxl_interface_set_mm_time(int qid, uint32_t mm_time) "%d %d"
disable qxl_io_write_vga(int qid, const char *mode, uint32_t addr, uint32_t val) "%d %s addr=%u val=%u"
-qxl_create_guest_primary(int qid, uint32_t width, uint32_t height, uint64_t mem, uint32_t format, uint32_t position) "%d %dx%d mem=%lx %d,%d"
+qxl_create_guest_primary(int qid, uint32_t width, uint32_t height, uint64_t mem, uint32_t format, uint32_t position) "%d %ux%u mem=%" PRIx64 " %u,%u"
qxl_create_guest_primary_rest(int qid, int32_t stride, uint32_t type, uint32_t flags) "%d %d,%d,%d"
qxl_destroy_primary(int qid) "%d"
qxl_enter_vga_mode(int qid) "%d"
--
1.7.0.4
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [Qemu-devel] [PATCH] trace-events: Fix broken build caused by wrong format specifier
2012-03-24 7:13 [Qemu-devel] [PATCH] trace-events: Fix broken build caused by wrong format specifier Stefan Weil
@ 2012-03-25 9:21 ` Alon Levy
2012-03-26 11:35 ` [Qemu-devel] [Qemu-trivial] " Stefan Hajnoczi
1 sibling, 0 replies; 3+ messages in thread
From: Alon Levy @ 2012-03-25 9:21 UTC (permalink / raw)
To: Stefan Weil; +Cc: qemu-trivial, qemu-devel
On Sat, Mar 24, 2012 at 08:13:34AM +0100, Stefan Weil wrote:
> mem is an uint64_t value, so %lx was wrong.
>
Thanks,
ACK
> Signed-off-by: Stefan Weil <sw@weilnetz.de>
> ---
> trace-events | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/trace-events b/trace-events
> index 70f059d..db2cd39 100644
> --- a/trace-events
> +++ b/trace-events
> @@ -726,7 +726,7 @@ ppm_save(const char *filename, void *display_surface) "%s surface=%p"
> # hw/qxl.c
> disable qxl_interface_set_mm_time(int qid, uint32_t mm_time) "%d %d"
> disable qxl_io_write_vga(int qid, const char *mode, uint32_t addr, uint32_t val) "%d %s addr=%u val=%u"
> -qxl_create_guest_primary(int qid, uint32_t width, uint32_t height, uint64_t mem, uint32_t format, uint32_t position) "%d %dx%d mem=%lx %d,%d"
> +qxl_create_guest_primary(int qid, uint32_t width, uint32_t height, uint64_t mem, uint32_t format, uint32_t position) "%d %ux%u mem=%" PRIx64 " %u,%u"
> qxl_create_guest_primary_rest(int qid, int32_t stride, uint32_t type, uint32_t flags) "%d %d,%d,%d"
> qxl_destroy_primary(int qid) "%d"
> qxl_enter_vga_mode(int qid) "%d"
> --
> 1.7.0.4
>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [Qemu-devel] [Qemu-trivial] [PATCH] trace-events: Fix broken build caused by wrong format specifier
2012-03-24 7:13 [Qemu-devel] [PATCH] trace-events: Fix broken build caused by wrong format specifier Stefan Weil
2012-03-25 9:21 ` Alon Levy
@ 2012-03-26 11:35 ` Stefan Hajnoczi
1 sibling, 0 replies; 3+ messages in thread
From: Stefan Hajnoczi @ 2012-03-26 11:35 UTC (permalink / raw)
To: Stefan Weil; +Cc: qemu-trivial, Alon Levy, qemu-devel
On Sat, Mar 24, 2012 at 08:13:34AM +0100, Stefan Weil wrote:
> mem is an uint64_t value, so %lx was wrong.
>
> Signed-off-by: Stefan Weil <sw@weilnetz.de>
> ---
> trace-events | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
Normally build fixes are sent directly to qemu.git/master committers for
quick merging. But this fix is only needed for 32-bit hosts that use
stderr tracing or another backend that uses the format string.
Thanks, applied to the trivial patches tree:
https://github.com/stefanha/qemu/commits/trivial-patches
Stefan
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2012-03-26 11:36 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2012-03-24 7:13 [Qemu-devel] [PATCH] trace-events: Fix broken build caused by wrong format specifier Stefan Weil
2012-03-25 9:21 ` Alon Levy
2012-03-26 11:35 ` [Qemu-devel] [Qemu-trivial] " Stefan Hajnoczi
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.