All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Michael S. Tsirkin" <mst@redhat.com>
To: Avi Kivity <avi@redhat.com>
Cc: Amit Shah <amit.shah@redhat.com>,
	yan@daynix.com, qemu-devel@nongnu.org, kvm@vger.kernel.org
Subject: Re: console class in kvm
Date: Mon, 26 Mar 2012 15:37:18 +0200	[thread overview]
Message-ID: <20120326133717.GC16511@redhat.com> (raw)
In-Reply-To: <4F706146.7040905@redhat.com>

On Mon, Mar 26, 2012 at 02:29:58PM +0200, Avi Kivity wrote:
> On 03/26/2012 01:19 PM, Michael S. Tsirkin wrote:
> > On Mon, Mar 26, 2012 at 12:18:54PM +0200, Avi Kivity wrote:
> > > On 03/26/2012 11:48 AM, Michael S. Tsirkin wrote:
> > > > kvm used to carry this commit:
> > > 
> > > Used to?  Which commit reverts this?
> >
> > A merge from qemu.git I would guess.
> > git log does not seem to show the culprit, I don't know
> > how to find it.
> 
> It was e2478f504fff20ad (git log  -SPCI_CLASS_OTHERS master -m -p).
> 
> 
> > > > commit 4667e6ec0df770867095d8093562d93c94d96ca2
> > > > Author: Avi Kivity <avi@redhat.com>
> > > > Date:   Thu Feb 12 11:43:17 2009 +0200
> > > >
> > > >     Change virtio-console to PCI_CLASS_OTHERS
> > > >     
> > > >     As a PCI_CLASS_DISPLAY_OTHER, it reduces primary display somehow on Windows XP
> > > >     (possibly Windows disables acceleration since it fails to find a driver).
> > > >     
> > > >     Signed-off-by: Avi Kivity <avi@redhat.com>
> > > >
> > > > This seems to have been dropped. Is the issue gone?
> > > > Could relevant parties speak up please?
> > > > Do we want to merge this commit into qemu.git?
> > > 
> > > It's an impossible compatibility problem now.  I have this sinking
> > > feeling that we need to create yet another driver property.
> >
> > That's easy, we have a class property for this already.
> 
> Yes, d6beee9938.

Exactly. qemu-kvm used to set the class to CLASS_OTHER while
the current code sets it to PCI_CLASS_COMMUNICATION_OTHER.
Do we want support for CLASS_OTHER or is it ok to drop it?

> 
> -- 
> error compiling committee.c: too many arguments to function

WARNING: multiple messages have this Message-ID (diff)
From: "Michael S. Tsirkin" <mst@redhat.com>
To: Avi Kivity <avi@redhat.com>
Cc: Amit Shah <amit.shah@redhat.com>,
	yan@daynix.com, qemu-devel@nongnu.org, kvm@vger.kernel.org
Subject: Re: [Qemu-devel] console class in kvm
Date: Mon, 26 Mar 2012 15:37:18 +0200	[thread overview]
Message-ID: <20120326133717.GC16511@redhat.com> (raw)
In-Reply-To: <4F706146.7040905@redhat.com>

On Mon, Mar 26, 2012 at 02:29:58PM +0200, Avi Kivity wrote:
> On 03/26/2012 01:19 PM, Michael S. Tsirkin wrote:
> > On Mon, Mar 26, 2012 at 12:18:54PM +0200, Avi Kivity wrote:
> > > On 03/26/2012 11:48 AM, Michael S. Tsirkin wrote:
> > > > kvm used to carry this commit:
> > > 
> > > Used to?  Which commit reverts this?
> >
> > A merge from qemu.git I would guess.
> > git log does not seem to show the culprit, I don't know
> > how to find it.
> 
> It was e2478f504fff20ad (git log  -SPCI_CLASS_OTHERS master -m -p).
> 
> 
> > > > commit 4667e6ec0df770867095d8093562d93c94d96ca2
> > > > Author: Avi Kivity <avi@redhat.com>
> > > > Date:   Thu Feb 12 11:43:17 2009 +0200
> > > >
> > > >     Change virtio-console to PCI_CLASS_OTHERS
> > > >     
> > > >     As a PCI_CLASS_DISPLAY_OTHER, it reduces primary display somehow on Windows XP
> > > >     (possibly Windows disables acceleration since it fails to find a driver).
> > > >     
> > > >     Signed-off-by: Avi Kivity <avi@redhat.com>
> > > >
> > > > This seems to have been dropped. Is the issue gone?
> > > > Could relevant parties speak up please?
> > > > Do we want to merge this commit into qemu.git?
> > > 
> > > It's an impossible compatibility problem now.  I have this sinking
> > > feeling that we need to create yet another driver property.
> >
> > That's easy, we have a class property for this already.
> 
> Yes, d6beee9938.

Exactly. qemu-kvm used to set the class to CLASS_OTHER while
the current code sets it to PCI_CLASS_COMMUNICATION_OTHER.
Do we want support for CLASS_OTHER or is it ok to drop it?

> 
> -- 
> error compiling committee.c: too many arguments to function

  reply	other threads:[~2012-03-26 14:17 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-03-26  9:48 console class in kvm Michael S. Tsirkin
2012-03-26  9:48 ` [Qemu-devel] " Michael S. Tsirkin
2012-03-26 10:18 ` Avi Kivity
2012-03-26 10:18   ` [Qemu-devel] " Avi Kivity
2012-03-26 11:19   ` Michael S. Tsirkin
2012-03-26 11:19     ` [Qemu-devel] " Michael S. Tsirkin
2012-03-26 12:29     ` Avi Kivity
2012-03-26 12:29       ` [Qemu-devel] " Avi Kivity
2012-03-26 13:37       ` Michael S. Tsirkin [this message]
2012-03-26 13:37         ` Michael S. Tsirkin
2012-03-26 13:43         ` Avi Kivity
2012-03-26 13:43           ` [Qemu-devel] " Avi Kivity

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20120326133717.GC16511@redhat.com \
    --to=mst@redhat.com \
    --cc=amit.shah@redhat.com \
    --cc=avi@redhat.com \
    --cc=kvm@vger.kernel.org \
    --cc=qemu-devel@nongnu.org \
    --cc=yan@daynix.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.