* [obsolete] checkpatch-add-strict-test-for-strings-split-across-multiple-lines.patch removed from -mm tree
@ 2012-03-26 19:22 akpm
0 siblings, 0 replies; only message in thread
From: akpm @ 2012-03-26 19:22 UTC (permalink / raw)
To: joe, apw, mm-commits
The patch titled
Subject: checkpatch: add --strict test for strings split across multiple lines
has been removed from the -mm tree. Its filename was
checkpatch-add-strict-test-for-strings-split-across-multiple-lines.patch
This patch was dropped because it is obsolete
The current -mm tree may be found at http://userweb.kernel.org/~akpm/mmotm/
------------------------------------------------------
From: Joe Perches <joe@perches.com>
Subject: checkpatch: add --strict test for strings split across multiple lines
Strings split across multiple lines are commonly used as formats. These
uncoalesced formats are hard to grep and are relatively error prone.
Suggest coalescing split strings when using --strict.
Signed-off-by: Joe Perches <joe@perches.com>
Cc: Andy Whitcroft <apw@shadowen.org>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
---
scripts/checkpatch.pl | 6 ++++++
1 file changed, 6 insertions(+)
diff -puN scripts/checkpatch.pl~checkpatch-add-strict-test-for-strings-split-across-multiple-lines scripts/checkpatch.pl
--- a/scripts/checkpatch.pl~checkpatch-add-strict-test-for-strings-split-across-multiple-lines
+++ a/scripts/checkpatch.pl
@@ -1860,6 +1860,12 @@ sub process {
"Don't begin block comments with only a /* line, use /* comment...\n" . $hereprev);
}
+ if ($prevline =~ /^\+.*"[ \t]*$/ &&
+ $line =~ /^\+[ \t]*"/) {
+ CHK("COALESCE_STRING",
+ "Coalesced strings are easier to grep and less error prone\n" . $hereprev);
+ }
+
# check for spaces at the beginning of a line.
# Exceptions:
# 1) within comments
_
Patches currently in -mm which might be from joe@perches.com are
origin.patch
checkpatch-warn-on-use-of-yield.patch
checkpatch-whitespace-add-remove-blank-lines.patch
checkpatch-check-for-quoted-strings-broken-across-lines.patch
linux-next.patch
maintainers-fix-remoteproc-f-typo.patch
checkpatch-suggest-pr_level-over-printkkern_level.patch
^ permalink raw reply [flat|nested] only message in thread
only message in thread, other threads:[~2012-03-26 19:23 UTC | newest]
Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2012-03-26 19:22 [obsolete] checkpatch-add-strict-test-for-strings-split-across-multiple-lines.patch removed from -mm tree akpm
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.