* git://github.com/some/thing.git/?
@ 2012-03-27 15:46 Junio C Hamano
2012-03-27 16:33 ` git://github.com/some/thing.git/? Jeff King
2012-03-27 17:54 ` git://github.com/some/thing.git/? Kevin
0 siblings, 2 replies; 8+ messages in thread
From: Junio C Hamano @ 2012-03-27 15:46 UTC (permalink / raw)
To: Jeff King, Scott Chacon; +Cc: git
I just noticed that
git ls-remote git://repo.or.cz/alt-git.git/
works, but neither of the following does:
git ls-remote git://git://github.com/gitster/git.git/
git ls-remote git://git://github.com/gitster/git/
It is just a minor irritation but it would be really nice if you can fix
it (please don't spend too much time on it if it is too involved, though).
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: git://github.com/some/thing.git/?
2012-03-27 15:46 git://github.com/some/thing.git/? Junio C Hamano
@ 2012-03-27 16:33 ` Jeff King
2012-03-27 18:25 ` git://github.com/some/thing.git/? Junio C Hamano
2012-03-27 17:54 ` git://github.com/some/thing.git/? Kevin
1 sibling, 1 reply; 8+ messages in thread
From: Jeff King @ 2012-03-27 16:33 UTC (permalink / raw)
To: Junio C Hamano; +Cc: Scott Chacon, git
On Tue, Mar 27, 2012 at 08:46:42AM -0700, Junio C Hamano wrote:
> I just noticed that
>
> git ls-remote git://repo.or.cz/alt-git.git/
>
> works, but neither of the following does:
>
> git ls-remote git://git://github.com/gitster/git.git/
> git ls-remote git://git://github.com/gitster/git/
>
> It is just a minor irritation but it would be really nice if you can fix
> it (please don't spend too much time on it if it is too involved, though).
Of course they don't work, they are malformed. :)
It took me a minute to figure it out, but I assume the interesting part
is the trailing slash?
Interestingly, this does work for http URLs, because we do some
normalization on the client side (and then append things like
"info/refs"). I wonder if we should do similar normalization for other
protocols.
Even with that, though, I think it would be good for the server to be
liberal in what it accepts.
-Peff
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: git://github.com/some/thing.git/?
2012-03-27 15:46 git://github.com/some/thing.git/? Junio C Hamano
2012-03-27 16:33 ` git://github.com/some/thing.git/? Jeff King
@ 2012-03-27 17:54 ` Kevin
1 sibling, 0 replies; 8+ messages in thread
From: Kevin @ 2012-03-27 17:54 UTC (permalink / raw)
To: Junio C Hamano; +Cc: Jeff King, Scott Chacon, git
I'm not sure if it's intentional, but notice that 'git://' is repeated in
each of the urls that don't work. If I fix it for the last one, it does
work.
On Tue, Mar 27, 2012 at 08:46:42AM -0700, Junio C Hamano wrote:
> I just noticed that
>
> git ls-remote git://repo.or.cz/alt-git.git/
>
> works, but neither of the following does:
>
> git ls-remote git://git://github.com/gitster/git.git/
> git ls-remote git://git://github.com/gitster/git/
>
> It is just a minor irritation but it would be really nice if you can fix
> it (please don't spend too much time on it if it is too involved, though).
> --
> To unsubscribe from this list: send the line "unsubscribe git" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: git://github.com/some/thing.git/?
2012-03-27 16:33 ` git://github.com/some/thing.git/? Jeff King
@ 2012-03-27 18:25 ` Junio C Hamano
2012-03-27 18:38 ` git://github.com/some/thing.git/? Jeff King
0 siblings, 1 reply; 8+ messages in thread
From: Junio C Hamano @ 2012-03-27 18:25 UTC (permalink / raw)
To: Jeff King; +Cc: Scott Chacon, git
Jeff King <peff@peff.net> writes:
> On Tue, Mar 27, 2012 at 08:46:42AM -0700, Junio C Hamano wrote:
>
>> I just noticed that
>>
>> git ls-remote git://repo.or.cz/alt-git.git/
>>
>> works, but neither of the following does:
>>
>> git ls-remote git://git://github.com/gitster/git.git/
>> git ls-remote git://git://github.com/gitster/git/
>>
>> It is just a minor irritation but it would be really nice if you can fix
>> it (please don't spend too much time on it if it is too involved, though).
>
> Of course they don't work, they are malformed. :)
Ahh, drop the duplicated "git://" from the front.
> It took me a minute to figure it out, but I assume the interesting part
> is the trailing slash?
Yes.
> Even with that, though, I think it would be good for the server to be
> liberal in what it accepts.
It is not about being liberal; it is about accepting what we have always
accepted.
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: git://github.com/some/thing.git/?
2012-03-27 18:25 ` git://github.com/some/thing.git/? Junio C Hamano
@ 2012-03-27 18:38 ` Jeff King
2012-03-27 18:47 ` git://github.com/some/thing.git/? Jonathan Nieder
2012-03-27 18:54 ` git://github.com/some/thing.git/? Junio C Hamano
0 siblings, 2 replies; 8+ messages in thread
From: Jeff King @ 2012-03-27 18:38 UTC (permalink / raw)
To: Junio C Hamano; +Cc: Scott Chacon, git
On Tue, Mar 27, 2012 at 11:25:22AM -0700, Junio C Hamano wrote:
> > Even with that, though, I think it would be good for the server to be
> > liberal in what it accepts.
>
> It is not about being liberal; it is about accepting what we have always
> accepted.
For some definition of "we"; AFAICT, github has never allowed this, and
this is the first complaint (we run a stock git-daemon, but our forwarding
proxies are picky about getting real "user/project" style paths, since
they need them to route to the correct backends).
However, it turned out to be a one-line patch. I've pushed it out for
review by other GitHubbers. The last thing the world needs is me
deploying anything to a live website.
-Peff
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: git://github.com/some/thing.git/?
2012-03-27 18:38 ` git://github.com/some/thing.git/? Jeff King
@ 2012-03-27 18:47 ` Jonathan Nieder
2012-03-28 4:28 ` git://github.com/some/thing.git/? Jeff King
2012-03-27 18:54 ` git://github.com/some/thing.git/? Junio C Hamano
1 sibling, 1 reply; 8+ messages in thread
From: Jonathan Nieder @ 2012-03-27 18:47 UTC (permalink / raw)
To: Jeff King; +Cc: Junio C Hamano, Scott Chacon, git
Jeff King wrote:
> For some definition of "we"; AFAICT, github has never allowed this, and
> this is the first complaint
I complained and got a dismissive response about two years ago. ;-) I
am not sure if bugs from back then are tracked any more. The URL in
my records is [1].
[...]
> However, it turned out to be a one-line patch. I've pushed it out for
> review by other GitHubbers.
Hoorah! Thanks for taking care of it.
Sincerely,
Jonathan
[1] http://support.github.com/discussions/repos/3046-cannot-access-repository-using-url-with-trailing-slash-is-not-a-valid-repository-name
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: git://github.com/some/thing.git/?
2012-03-27 18:38 ` git://github.com/some/thing.git/? Jeff King
2012-03-27 18:47 ` git://github.com/some/thing.git/? Jonathan Nieder
@ 2012-03-27 18:54 ` Junio C Hamano
1 sibling, 0 replies; 8+ messages in thread
From: Junio C Hamano @ 2012-03-27 18:54 UTC (permalink / raw)
To: Jeff King; +Cc: Scott Chacon, git
Jeff King <peff@peff.net> writes:
> However, it turned out to be a one-line patch.
Thanks.
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: git://github.com/some/thing.git/?
2012-03-27 18:47 ` git://github.com/some/thing.git/? Jonathan Nieder
@ 2012-03-28 4:28 ` Jeff King
0 siblings, 0 replies; 8+ messages in thread
From: Jeff King @ 2012-03-28 4:28 UTC (permalink / raw)
To: Jonathan Nieder; +Cc: Junio C Hamano, Scott Chacon, git
On Tue, Mar 27, 2012 at 01:47:54PM -0500, Jonathan Nieder wrote:
> > For some definition of "we"; AFAICT, github has never allowed this, and
> > this is the first complaint
>
> I complained and got a dismissive response about two years ago. ;-) I
> am not sure if bugs from back then are tracked any more. The URL in
> my records is [1].
I wasn't able to find the original discussion, as we've migrated through
a few different support systems in the last few years. Probably it is in
there somewhere, but I don't usually do support stuff, and I didn't
think it was worth bothering the regular support people with it.
> > However, it turned out to be a one-line patch. I've pushed it out for
> > review by other GitHubbers.
>
> Hoorah! Thanks for taking care of it.
FYI, this is now deployed, and the various front-end machines are
getting updated slowly over the next few hours (until then, it's
non-deterministic whether it will work for you or not :) ).
-Peff
^ permalink raw reply [flat|nested] 8+ messages in thread
end of thread, other threads:[~2012-03-28 4:28 UTC | newest]
Thread overview: 8+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2012-03-27 15:46 git://github.com/some/thing.git/? Junio C Hamano
2012-03-27 16:33 ` git://github.com/some/thing.git/? Jeff King
2012-03-27 18:25 ` git://github.com/some/thing.git/? Junio C Hamano
2012-03-27 18:38 ` git://github.com/some/thing.git/? Jeff King
2012-03-27 18:47 ` git://github.com/some/thing.git/? Jonathan Nieder
2012-03-28 4:28 ` git://github.com/some/thing.git/? Jeff King
2012-03-27 18:54 ` git://github.com/some/thing.git/? Junio C Hamano
2012-03-27 17:54 ` git://github.com/some/thing.git/? Kevin
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.