All of lore.kernel.org
 help / color / mirror / Atom feed
From: Johan Hedberg <johan.hedberg@gmail.com>
To: james.steele@accenture.com
Cc: linux-bluetooth@vger.kernel.org
Subject: Re: [PATCH v3 1/3] lib: Correct the HCI Testing OGF value
Date: Wed, 28 Mar 2012 20:05:06 +0300	[thread overview]
Message-ID: <20120328170506.GA14006@x220.P-661HNU-F1> (raw)
In-Reply-To: <81C9FA9C1C2E9E45A9AC3EDD1858BC4323E11458@048-CH1MPN1-101.048d.mgd.msft.net>

Hi James,

On Wed, Mar 28, 2012, james.steele@accenture.com wrote:
> This patch corrects the Testing OGF to match the value in the Bluetooth
> specification, bringing it in line with the other defined OGF values.
> ---
>  lib/hci.h |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)

Where did the git author name info disappear that you had in your
previous submissions? This needs to be part of the patches.

Furthermore, your patches do not actually apply:

error: patch failed: lib/hci.h:1428
error: lib/hci.h: patch does not apply
Patch failed at 0001 lib: Correct the HCI Testing OGF value

On closer inspection it looks like either your mail client or mail
server is converting tabs to spaces. Are you using git send-email?
(which is the preferred way to send patches). Please test sending to
yourself and applying with git am before resending to linux-bluetooth.

Johan

      reply	other threads:[~2012-03-28 17:05 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-03-28 14:31 [PATCH v3 1/3] lib: Correct the HCI Testing OGF value james.steele
2012-03-28 17:05 ` Johan Hedberg [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20120328170506.GA14006@x220.P-661HNU-F1 \
    --to=johan.hedberg@gmail.com \
    --cc=james.steele@accenture.com \
    --cc=linux-bluetooth@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.