All of lore.kernel.org
 help / color / mirror / Atom feed
* [lm-sensors] [PATCH] Don't probe EDID addresses on graphics card adapters
@ 2012-04-04  9:32 Jean Delvare
  2012-04-04 13:54 ` Guenter Roeck
  0 siblings, 1 reply; 2+ messages in thread
From: Jean Delvare @ 2012-04-04  9:32 UTC (permalink / raw)
  To: lm-sensors

Avoid probing EDID addresses (0x50-0x57) on graphics card adapters.
We had one report that it caused trouble:
http://lists.lm-sensors.org/pipermail/lm-sensors/2012-April/035847.html
Even though it's not yet clear what happened, let's play it safe.

This closes ticket #2386.
---
 prog/detect/sensors-detect |    3 +++
 1 file changed, 3 insertions(+)

--- lm-sensors.orig/prog/detect/sensors-detect	2012-03-29 08:33:21.000000000 +0200
+++ lm-sensors/prog/detect/sensors-detect	2012-04-02 18:37:31.948591233 +0200
@@ -3660,6 +3660,9 @@ sub scan_i2c_adapter
 		$input = <STDIN>;
 		chomp($input);
 		@not_to_scan = parse_not_to_scan(0x03, 0x77, $input);
+	} elsif (($class & 0xff00) = 0x0300) {
+		# Skip EDID addresses by default on graphics adapters
+		@not_to_scan = parse_not_to_scan(0x03, 0x77, "0x50-0x57");
 	}
 
 	open(local *FILE, "$dev_i2c$adapter_nr") or


-- 
Jean Delvare

_______________________________________________
lm-sensors mailing list
lm-sensors@lm-sensors.org
http://lists.lm-sensors.org/mailman/listinfo/lm-sensors

^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: [lm-sensors] [PATCH] Don't probe EDID addresses on graphics card adapters
  2012-04-04  9:32 [lm-sensors] [PATCH] Don't probe EDID addresses on graphics card adapters Jean Delvare
@ 2012-04-04 13:54 ` Guenter Roeck
  0 siblings, 0 replies; 2+ messages in thread
From: Guenter Roeck @ 2012-04-04 13:54 UTC (permalink / raw)
  To: lm-sensors

On Wed, Apr 04, 2012 at 05:32:53AM -0400, Jean Delvare wrote:
> Avoid probing EDID addresses (0x50-0x57) on graphics card adapters.
> We had one report that it caused trouble:
> http://lists.lm-sensors.org/pipermail/lm-sensors/2012-April/035847.html
> Even though it's not yet clear what happened, let's play it safe.
> 
> This closes ticket #2386.

Agreed, and looks good.

Guenter

> ---
>  prog/detect/sensors-detect |    3 +++
>  1 file changed, 3 insertions(+)
> 
> --- lm-sensors.orig/prog/detect/sensors-detect	2012-03-29 08:33:21.000000000 +0200
> +++ lm-sensors/prog/detect/sensors-detect	2012-04-02 18:37:31.948591233 +0200
> @@ -3660,6 +3660,9 @@ sub scan_i2c_adapter
>  		$input = <STDIN>;
>  		chomp($input);
>  		@not_to_scan = parse_not_to_scan(0x03, 0x77, $input);
> +	} elsif (($class & 0xff00) = 0x0300) {
> +		# Skip EDID addresses by default on graphics adapters
> +		@not_to_scan = parse_not_to_scan(0x03, 0x77, "0x50-0x57");
>  	}
>  
>  	open(local *FILE, "$dev_i2c$adapter_nr") or
> 
> 
> -- 
> Jean Delvare
> 
> _______________________________________________
> lm-sensors mailing list
> lm-sensors@lm-sensors.org
> http://lists.lm-sensors.org/mailman/listinfo/lm-sensors

-- 
Guenter Roeck
Distinguished Engineer
PDU IP Systems

_______________________________________________
lm-sensors mailing list
lm-sensors@lm-sensors.org
http://lists.lm-sensors.org/mailman/listinfo/lm-sensors

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2012-04-04 13:54 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2012-04-04  9:32 [lm-sensors] [PATCH] Don't probe EDID addresses on graphics card adapters Jean Delvare
2012-04-04 13:54 ` Guenter Roeck

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.