All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH] acer-wmi: No wifi rfkill on Sony machines
@ 2012-03-23  4:36 Lee, Chun-Yi
  2012-04-01 18:40 ` [PATCH 3.0.y] " Jonathan Nieder
  0 siblings, 1 reply; 3+ messages in thread
From: Lee, Chun-Yi @ 2012-03-23  4:36 UTC (permalink / raw)
  To: mjg
  Cc: platform-driver-x86, stable, Lee, Chun-Yi, Carlos Corbacho,
	Mattia Dongili, Dimitris N

The wireless rfkill should charged by sony-laptop but not acer-wmi.
So, add Sony's SNY5001 acpi device to blacklist in acer-wmi.

Tested on Sony Vaio

Cc: Carlos Corbacho <carlos@strangeworlds.co.uk> 
Cc: Matthew Garrett <mjg@redhat.com>
Cc: Mattia Dongili <malattia@linux.it>
Cc: Dimitris N <ddarlac@gmail.com>
Tested-by: Dimitris N <ddarlac@gmail.com>
Signed-off-by: Lee, Chun-Yi <jlee@suse.com>
---
 drivers/platform/x86/acer-wmi.c |    1 +
 1 files changed, 1 insertions(+), 0 deletions(-)

diff --git a/drivers/platform/x86/acer-wmi.c b/drivers/platform/x86/acer-wmi.c
index 1e5290b..110e4af 100644
--- a/drivers/platform/x86/acer-wmi.c
+++ b/drivers/platform/x86/acer-wmi.c
@@ -692,6 +692,7 @@ static const struct acpi_device_id norfkill_ids[] = {
 	{ "VPC2004", 0},
 	{ "IBM0068", 0},
 	{ "LEN0068", 0},
+	{ "SNY5001", 0},	/* sony-laptop in charge */
 	{ "", 0},
 };
 
-- 
1.6.0.2

^ permalink raw reply related	[flat|nested] 3+ messages in thread
* [PATCH 3.0.y] acer-wmi: No wifi rfkill on Sony machines
  2012-03-23  4:36 [PATCH] acer-wmi: No wifi rfkill on Sony machines Lee, Chun-Yi
@ 2012-04-01 18:40 ` Jonathan Nieder
  2012-04-10 23:09   ` Greg KH
  0 siblings, 1 reply; 3+ messages in thread
From: Jonathan Nieder @ 2012-04-01 18:40 UTC (permalink / raw)
  To: stable
  Cc: Lee, Chun-Yi, Matthew Garrett, platform-driver-x86, stable, Lee,
	Chun-Yi, Carlos Corbacho, Mattia Dongili, Dimitris N,
	Kalle Olavi Niemitalo

From: Lee, Chun-Yi <joeyli.kernel@gmail.com>
Date: Fri, 23 Mar 2012 12:36:44 +0800

commit 5719b81988f3c24ff694dc3a37e35b35630a3966 upstream.

The wireless rfkill should charged by sony-laptop but not acer-wmi.
So, add Sony's SNY5001 acpi device to blacklist in acer-wmi.

Tested on Sony Vaio

Addresses http://bugs.debian.org/666568

Cc: Carlos Corbacho <carlos@strangeworlds.co.uk>
Cc: Mattia Dongili <malattia@linux.it>
Tested-by: Dimitris N <ddarlac@gmail.com>
Signed-off-by: Lee, Chun-Yi <jlee@suse.com>
Signed-off-by: Matthew Garrett <mjg@redhat.com>
Tested-by: Kalle Olavi Niemitalo <kon@iki.fi> (on v3.2.13)
Signed-off-by: Jonathan Nieder <jrnieder@gmail.com>
---
Hi Greg,

Please consider this patch for the 3.0, 3.2, and 3.3-stable series.

Without this patch, on affected machines wireless simply doesn't work
unless you unload the acer-wmi driver, regardless of the state of the
physical WIRELESS switch.  "rfkill list" reports sony-wifi unblocked
and acer-wireless soft blocked.  "rfkill unblock 2" has no effect.

Kalle (cc-ed) tried the patch on top of 3.2.y and wifi started working
again on his Sony VAIO VPCYA1V9E.  More details are at
<http://bugs.debian.org/666568>.

Thanks,
Jonathan

 drivers/platform/x86/acer-wmi.c |    1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/platform/x86/acer-wmi.c b/drivers/platform/x86/acer-wmi.c
index db9b25abeb66..2080b223c74a 100644
--- a/drivers/platform/x86/acer-wmi.c
+++ b/drivers/platform/x86/acer-wmi.c
@@ -689,6 +689,7 @@ static const struct acpi_device_id norfkill_ids[] = {
 	{ "VPC2004", 0},
 	{ "IBM0068", 0},
 	{ "LEN0068", 0},
+	{ "SNY5001", 0},	/* sony-laptop in charge */
 	{ "", 0},
 };
 
-- 
1.7.10.rc3

^ permalink raw reply related	[flat|nested] 3+ messages in thread
* Re: [PATCH 3.0.y] acer-wmi: No wifi rfkill on Sony machines
  2012-04-01 18:40 ` [PATCH 3.0.y] " Jonathan Nieder
@ 2012-04-10 23:09   ` Greg KH
  0 siblings, 0 replies; 3+ messages in thread
From: Greg KH @ 2012-04-10 23:09 UTC (permalink / raw)
  To: Jonathan Nieder
  Cc: stable, Lee, Chun-Yi, Matthew Garrett, platform-driver-x86,
	stable, Lee, Chun-Yi, Carlos Corbacho, Mattia Dongili,
	Dimitris N, Kalle Olavi Niemitalo

On Sun, Apr 01, 2012 at 01:40:07PM -0500, Jonathan Nieder wrote:
> From: Lee, Chun-Yi <joeyli.kernel@gmail.com>
> Date: Fri, 23 Mar 2012 12:36:44 +0800
> 
> commit 5719b81988f3c24ff694dc3a37e35b35630a3966 upstream.
> 
> The wireless rfkill should charged by sony-laptop but not acer-wmi.
> So, add Sony's SNY5001 acpi device to blacklist in acer-wmi.
> 
> Tested on Sony Vaio
> 
> Addresses http://bugs.debian.org/666568
> 
> Cc: Carlos Corbacho <carlos@strangeworlds.co.uk>
> Cc: Mattia Dongili <malattia@linux.it>
> Tested-by: Dimitris N <ddarlac@gmail.com>
> Signed-off-by: Lee, Chun-Yi <jlee@suse.com>
> Signed-off-by: Matthew Garrett <mjg@redhat.com>
> Tested-by: Kalle Olavi Niemitalo <kon@iki.fi> (on v3.2.13)
> Signed-off-by: Jonathan Nieder <jrnieder@gmail.com>
> ---
> Hi Greg,
> 
> Please consider this patch for the 3.0, 3.2, and 3.3-stable series.

Now applied, thanks for letting me know.

greg k-h

^ permalink raw reply	[flat|nested] 3+ messages in thread
end of thread, other threads:[~2012-04-10 23:09 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2012-03-23  4:36 [PATCH] acer-wmi: No wifi rfkill on Sony machines Lee, Chun-Yi
2012-04-01 18:40 ` [PATCH 3.0.y] " Jonathan Nieder
2012-04-10 23:09   ` Greg KH

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.