From: David Miller <davem@davemloft.net>
To: paul.gortmaker@windriver.com
Cc: linux-kbuild@vger.kernel.org, linux-kernel@vger.kernel.org,
torvalds@linux-foundation.org, akpm@linux-foundation.org,
tony@bakeyournoodle.com, mmarek@suse.cz, lacombar@gmail.com
Subject: Re: [PATCH 3/5] drivers/net: remove IS_ENABLED usage from wiznet drivers
Date: Wed, 11 Apr 2012 19:54:44 -0400 (EDT) [thread overview]
Message-ID: <20120411.195444.540814653660043985.davem@davemloft.net> (raw)
In-Reply-To: <1334188257-3449-4-git-send-email-paul.gortmaker@windriver.com>
From: Paul Gortmaker <paul.gortmaker@windriver.com>
Date: Wed, 11 Apr 2012 19:50:55 -0400
> The use of IS_ENABLED in C code (vs just in CPP #if directives)
> causes us to carry the burden of a huge autoconf.h file. It is
> also misleading in that a casual inspection of the code would
> leave one thinking that the if statements were evaluated at
> runtime, when TX_FLOW is a Kconfig bool and hence evaluated
> at configure time as an either/or.
>
> Signed-off-by: Paul Gortmaker <paul.gortmaker@windriver.com>
Want me to toss this into net-next?
next prev parent reply other threads:[~2012-04-11 23:58 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-04-11 23:50 [PATCH 0/5] RFC: strip 15,000 lines from a typical autoconf.h Paul Gortmaker
2012-04-11 23:50 ` [PATCH 1/5] Revert "mm: replace PAGE_MIGRATION with IS_ENABLED(CONFIG_MIGRATION)" Paul Gortmaker
2012-04-12 0:05 ` Andrew Morton
2012-04-11 23:50 ` [PATCH 2/5] ARM: remove C users of IS_ENABLED on THUMB2_KERNEL Paul Gortmaker
2012-04-11 23:50 ` [PATCH 3/5] drivers/net: remove IS_ENABLED usage from wiznet drivers Paul Gortmaker
2012-04-11 23:54 ` David Miller [this message]
2012-04-12 0:06 ` Stephen Rothwell
2012-04-12 0:22 ` Stephen Rothwell
2012-04-12 17:15 ` Paul Gortmaker
2012-04-12 17:15 ` Paul Gortmaker
2012-04-11 23:50 ` [PATCH 4/5] Revert "kconfig: fix __enabled_ macros definition for invisible and un-selected symbols" Paul Gortmaker
2012-04-11 23:50 ` [PATCH 5/5] kconfig: limit IS_ENABLED & similar to CPP usage Paul Gortmaker
2012-04-12 0:04 ` Linus Torvalds
2012-04-12 17:46 ` Paul Gortmaker
2012-04-12 17:46 ` Paul Gortmaker
2012-04-11 23:58 ` [PATCH 0/5] RFC: strip 15,000 lines from a typical autoconf.h Linus Torvalds
2012-04-12 1:19 ` Linus Torvalds
2012-04-12 1:45 ` Andrew Morton
2012-04-12 1:55 ` Linus Torvalds
2012-04-12 3:10 ` Stephen Rothwell
2012-04-12 19:29 ` Linus Torvalds
2012-04-12 23:46 ` [PATCH 0/3] RFC v2: " Paul Gortmaker
2012-04-12 23:46 ` [PATCH 1/3] kconfig: fix IS_ENABLED to not require all options to be defined Paul Gortmaker
2012-04-13 10:31 ` Dick Streefland
2012-04-12 23:46 ` [PATCH 2/3] Revert "kconfig: fix __enabled_ macros definition for invisible and un-selected symbols" Paul Gortmaker
2012-04-12 23:46 ` [PATCH 3/3] kconfig: delete last traces of __enabled_ from autoconf.h Paul Gortmaker
2012-04-12 9:27 ` [PATCH 0/5] RFC: strip 15,000 lines from a typical autoconf.h Michal Marek
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120411.195444.540814653660043985.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=akpm@linux-foundation.org \
--cc=lacombar@gmail.com \
--cc=linux-kbuild@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mmarek@suse.cz \
--cc=paul.gortmaker@windriver.com \
--cc=tony@bakeyournoodle.com \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.