All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH] irq_work: fix compile failure on tile from missing include
@ 2012-04-11 16:21 Chris Metcalf
  2012-04-12 16:10 ` Paul Gortmaker
  0 siblings, 1 reply; 3+ messages in thread
From: Chris Metcalf @ 2012-04-11 16:21 UTC (permalink / raw)
  To: Paul Gortmaker, Ingo Molnar, Huang Ying, David Howells, linux-kernel

Building with IRQ_WORK configured results in

kernel/irq_work.c: In function ‘irq_work_run’:
kernel/irq_work.c:110: error: implicit declaration of function ‘irqs_disabled’

The appropriate header just needs to be included.

Signed-off-by: Chris Metcalf <cmetcalf@tilera.com>
---
 kernel/irq_work.c |    1 +
 1 files changed, 1 insertions(+), 0 deletions(-)

diff --git a/kernel/irq_work.c b/kernel/irq_work.c
index 0c56d44..1588e3b 100644
--- a/kernel/irq_work.c
+++ b/kernel/irq_work.c
@@ -11,6 +11,7 @@
 #include <linux/irq_work.h>
 #include <linux/percpu.h>
 #include <linux/hardirq.h>
+#include <linux/irqflags.h>
 #include <asm/processor.h>
 
 /*
-- 
1.6.5.2


^ permalink raw reply related	[flat|nested] 3+ messages in thread

* Re: [PATCH] irq_work: fix compile failure on tile from missing include
  2012-04-11 16:21 [PATCH] irq_work: fix compile failure on tile from missing include Chris Metcalf
@ 2012-04-12 16:10 ` Paul Gortmaker
  2012-04-12 16:12   ` Chris Metcalf
  0 siblings, 1 reply; 3+ messages in thread
From: Paul Gortmaker @ 2012-04-12 16:10 UTC (permalink / raw)
  To: Chris Metcalf; +Cc: Ingo Molnar, Huang Ying, David Howells, linux-kernel

On 12-04-11 12:21 PM, Chris Metcalf wrote:
> Building with IRQ_WORK configured results in
> 
> kernel/irq_work.c: In function ‘irq_work_run’:
> kernel/irq_work.c:110: error: implicit declaration of function ‘irqs_disabled’
> 
> The appropriate header just needs to be included.
> 
> Signed-off-by: Chris Metcalf <cmetcalf@tilera.com>

Hi Chris,

I've got an alpha fix and an itanic fix left wrt. the system.h
fallout to get pulled; I can bundle this system.h fix with those
if you want.

Paul.

> ---
>  kernel/irq_work.c |    1 +
>  1 files changed, 1 insertions(+), 0 deletions(-)
> 
> diff --git a/kernel/irq_work.c b/kernel/irq_work.c
> index 0c56d44..1588e3b 100644
> --- a/kernel/irq_work.c
> +++ b/kernel/irq_work.c
> @@ -11,6 +11,7 @@
>  #include <linux/irq_work.h>
>  #include <linux/percpu.h>
>  #include <linux/hardirq.h>
> +#include <linux/irqflags.h>
>  #include <asm/processor.h>
>  
>  /*

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH] irq_work: fix compile failure on tile from missing include
  2012-04-12 16:10 ` Paul Gortmaker
@ 2012-04-12 16:12   ` Chris Metcalf
  0 siblings, 0 replies; 3+ messages in thread
From: Chris Metcalf @ 2012-04-12 16:12 UTC (permalink / raw)
  To: Paul Gortmaker; +Cc: Ingo Molnar, Huang Ying, David Howells, linux-kernel

On 4/12/2012 12:10 PM, Paul Gortmaker wrote:
> On 12-04-11 12:21 PM, Chris Metcalf wrote:
>> Building with IRQ_WORK configured results in
>>
>> kernel/irq_work.c: In function ‘irq_work_run’:
>> kernel/irq_work.c:110: error: implicit declaration of function ‘irqs_disabled’
>>
>> The appropriate header just needs to be included.
>>
>> Signed-off-by: Chris Metcalf <cmetcalf@tilera.com>
> Hi Chris,
>
> I've got an alpha fix and an itanic fix left wrt. the system.h
> fallout to get pulled; I can bundle this system.h fix with those
> if you want.

That would be great; thanks.

-- 
Chris Metcalf, Tilera Corp.
http://www.tilera.com


^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2012-04-12 16:12 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2012-04-11 16:21 [PATCH] irq_work: fix compile failure on tile from missing include Chris Metcalf
2012-04-12 16:10 ` Paul Gortmaker
2012-04-12 16:12   ` Chris Metcalf

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.