All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH] arm: vic.c: local variables should not be exposed globally
@ 2012-04-12 18:13 H Hartley Sweeten
  0 siblings, 0 replies; only message in thread
From: H Hartley Sweeten @ 2012-04-12 18:13 UTC (permalink / raw)
  To: linux-arm-kernel

The variable 'vic_syscore_ops' is only referenced in this file and
should be marked static to prevent it from being exposed globally.

This quiets the sparse waring:

warning: symbol 'vic_syscore_ops' was not declared. Should it be static?

Signed-off-by: H Hartley Sweeten <hsweeten@visionengravers.com>

---

diff --git a/arch/arm/common/vic.c b/arch/arm/common/vic.c
index 7e288f9..9dc2183 100644
--- a/arch/arm/common/vic.c
+++ b/arch/arm/common/vic.c
@@ -142,7 +142,7 @@ static int vic_suspend(void)
 	return 0;
 }
 
-struct syscore_ops vic_syscore_ops = {
+static struct syscore_ops vic_syscore_ops = {
 	.suspend	= vic_suspend,
 	.resume		= vic_resume,
 };

^ permalink raw reply	[flat|nested] only message in thread

only message in thread, other threads:[~2012-04-12 18:13 UTC | newest]

Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2012-04-12 18:13 [PATCH] arm: vic.c: local variables should not be exposed globally H Hartley Sweeten

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.