* Re: [PATCH] fs: make i_generation a u64
@ 2012-04-12 6:46 ` Marco Stornelli
0 siblings, 0 replies; 10+ messages in thread
From: Marco Stornelli @ 2012-04-12 6:46 UTC (permalink / raw)
To: Josef Bacik; +Cc: linux-fsdevel, linux-btrfs, viro
2012/4/11 Josef Bacik <josef@redhat.com>:
> Btrfs stores generation numbers as 64bit numbers, which means we have to
> carry around a u64 in our incore inode in addition to setting i_generation.
> So convert to a u64 so btrfs can kill it's incore generation. Thanks,
>
> Signed-off-by: Josef Bacik <josef@redhat.com>
> ---
> include/linux/fs.h | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/include/linux/fs.h b/include/linux/fs.h
> index 9be896d..40564e0 100644
> --- a/include/linux/fs.h
> +++ b/include/linux/fs.h
> @@ -831,7 +831,7 @@ struct inode {
> struct cdev *i_cdev;
> };
>
> - __u32 i_generation;
> + u64 i_generation;
>
> #ifdef CONFIG_FSNOTIFY
> __u32 i_fsnotify_mask; /* all events this inode cares about */
> --
> 1.7.7.6
This patch can have several impact on other fs. Only to do an example
you can see the code in ioctl of ext4. I haven't got study the code
but the ioctl returns a long, but on 32bit system, long means 4 bytes,
so how we can return i_generation with ioctl?
Marco
--
To unsubscribe from this list: send the line "unsubscribe linux-btrfs" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [PATCH] fs: make i_generation a u64
2012-04-12 6:46 ` Marco Stornelli
@ 2012-04-12 13:20 ` Josef Bacik
-1 siblings, 0 replies; 10+ messages in thread
From: Josef Bacik @ 2012-04-12 13:20 UTC (permalink / raw)
To: Marco Stornelli; +Cc: Josef Bacik, linux-fsdevel, linux-btrfs, viro
On Thu, Apr 12, 2012 at 08:46:14AM +0200, Marco Stornelli wrote:
> 2012/4/11 Josef Bacik <josef@redhat.com>:
> > Btrfs stores generation numbers as 64bit numbers, which means we ha=
ve to
> > carry around a u64 in our incore inode in addition to setting i_gen=
eration.
> > So convert to a u64 so btrfs can kill it's incore generation. =A0Th=
anks,
> >
> > Signed-off-by: Josef Bacik <josef@redhat.com>
> > ---
> > =A0include/linux/fs.h | =A0 =A02 +-
> > =A01 files changed, 1 insertions(+), 1 deletions(-)
> >
> > diff --git a/include/linux/fs.h b/include/linux/fs.h
> > index 9be896d..40564e0 100644
> > --- a/include/linux/fs.h
> > +++ b/include/linux/fs.h
> > @@ -831,7 +831,7 @@ struct inode {
> > =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0struct cdev =A0 =A0 =A0 =A0 =A0 =A0 =
*i_cdev;
> > =A0 =A0 =A0 =A0};
> >
> > - =A0 =A0 =A0 __u32 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 i_generatio=
n;
> > + =A0 =A0 =A0 u64 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 i_generat=
ion;
> >
> > =A0#ifdef CONFIG_FSNOTIFY
> > =A0 =A0 =A0 =A0__u32 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 i_fsnotify=
_mask; /* all events this inode cares about */
> > --
> > 1.7.7.6
>=20
> This patch can have several impact on other fs. Only to do an example
> you can see the code in ioctl of ext4. I haven't got study the code
> but the ioctl returns a long, but on 32bit system, long means 4 bytes=
,
> so how we can return i_generation with ioctl?
>=20
Thanks for pointing this out, I will fix ext4 up and look to see if any=
body else
does something similar,
Josef
--
To unsubscribe from this list: send the line "unsubscribe linux-btrfs" =
in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [PATCH] fs: make i_generation a u64
@ 2012-04-12 13:20 ` Josef Bacik
0 siblings, 0 replies; 10+ messages in thread
From: Josef Bacik @ 2012-04-12 13:20 UTC (permalink / raw)
To: Marco Stornelli; +Cc: Josef Bacik, linux-fsdevel, linux-btrfs, viro
On Thu, Apr 12, 2012 at 08:46:14AM +0200, Marco Stornelli wrote:
> 2012/4/11 Josef Bacik <josef@redhat.com>:
> > Btrfs stores generation numbers as 64bit numbers, which means we have to
> > carry around a u64 in our incore inode in addition to setting i_generation.
> > So convert to a u64 so btrfs can kill it's incore generation. Thanks,
> >
> > Signed-off-by: Josef Bacik <josef@redhat.com>
> > ---
> > include/linux/fs.h | 2 +-
> > 1 files changed, 1 insertions(+), 1 deletions(-)
> >
> > diff --git a/include/linux/fs.h b/include/linux/fs.h
> > index 9be896d..40564e0 100644
> > --- a/include/linux/fs.h
> > +++ b/include/linux/fs.h
> > @@ -831,7 +831,7 @@ struct inode {
> > struct cdev *i_cdev;
> > };
> >
> > - __u32 i_generation;
> > + u64 i_generation;
> >
> > #ifdef CONFIG_FSNOTIFY
> > __u32 i_fsnotify_mask; /* all events this inode cares about */
> > --
> > 1.7.7.6
>
> This patch can have several impact on other fs. Only to do an example
> you can see the code in ioctl of ext4. I haven't got study the code
> but the ioctl returns a long, but on 32bit system, long means 4 bytes,
> so how we can return i_generation with ioctl?
>
Thanks for pointing this out, I will fix ext4 up and look to see if anybody else
does something similar,
Josef
--
To unsubscribe from this list: send the line "unsubscribe linux-btrfs" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [PATCH] fs: make i_generation a u64
2012-04-12 6:46 ` Marco Stornelli
@ 2012-04-12 13:56 ` Josef Bacik
-1 siblings, 0 replies; 10+ messages in thread
From: Josef Bacik @ 2012-04-12 13:56 UTC (permalink / raw)
To: Marco Stornelli; +Cc: Josef Bacik, linux-fsdevel, linux-btrfs, viro
On Thu, Apr 12, 2012 at 08:46:14AM +0200, Marco Stornelli wrote:
> 2012/4/11 Josef Bacik <josef@redhat.com>:
> > Btrfs stores generation numbers as 64bit numbers, which means we ha=
ve to
> > carry around a u64 in our incore inode in addition to setting i_gen=
eration.
> > So convert to a u64 so btrfs can kill it's incore generation. =A0Th=
anks,
> >
> > Signed-off-by: Josef Bacik <josef@redhat.com>
> > ---
> > =A0include/linux/fs.h | =A0 =A02 +-
> > =A01 files changed, 1 insertions(+), 1 deletions(-)
> >
> > diff --git a/include/linux/fs.h b/include/linux/fs.h
> > index 9be896d..40564e0 100644
> > --- a/include/linux/fs.h
> > +++ b/include/linux/fs.h
> > @@ -831,7 +831,7 @@ struct inode {
> > =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0struct cdev =A0 =A0 =A0 =A0 =A0 =A0 =
*i_cdev;
> > =A0 =A0 =A0 =A0};
> >
> > - =A0 =A0 =A0 __u32 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 i_generatio=
n;
> > + =A0 =A0 =A0 u64 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 i_generat=
ion;
> >
> > =A0#ifdef CONFIG_FSNOTIFY
> > =A0 =A0 =A0 =A0__u32 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 i_fsnotify=
_mask; /* all events this inode cares about */
> > --
> > 1.7.7.6
>=20
> This patch can have several impact on other fs. Only to do an example
> you can see the code in ioctl of ext4. I haven't got study the code
> but the ioctl returns a long, but on 32bit system, long means 4 bytes=
,
> so how we can return i_generation with ioctl?
So looking through everybody I'd have to convert a bunch of cpu_to_le32=
to
(u32)cpu_to_le64 and some other such crap which I'm not terribly intere=
sted in
doing, I don't care _that_ much about saving 8 bytes, so I'll just drop=
this for
now. Thanks,
Josef
--
To unsubscribe from this list: send the line "unsubscribe linux-btrfs" =
in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [PATCH] fs: make i_generation a u64
@ 2012-04-12 13:56 ` Josef Bacik
0 siblings, 0 replies; 10+ messages in thread
From: Josef Bacik @ 2012-04-12 13:56 UTC (permalink / raw)
To: Marco Stornelli; +Cc: Josef Bacik, linux-fsdevel, linux-btrfs, viro
On Thu, Apr 12, 2012 at 08:46:14AM +0200, Marco Stornelli wrote:
> 2012/4/11 Josef Bacik <josef@redhat.com>:
> > Btrfs stores generation numbers as 64bit numbers, which means we have to
> > carry around a u64 in our incore inode in addition to setting i_generation.
> > So convert to a u64 so btrfs can kill it's incore generation. Thanks,
> >
> > Signed-off-by: Josef Bacik <josef@redhat.com>
> > ---
> > include/linux/fs.h | 2 +-
> > 1 files changed, 1 insertions(+), 1 deletions(-)
> >
> > diff --git a/include/linux/fs.h b/include/linux/fs.h
> > index 9be896d..40564e0 100644
> > --- a/include/linux/fs.h
> > +++ b/include/linux/fs.h
> > @@ -831,7 +831,7 @@ struct inode {
> > struct cdev *i_cdev;
> > };
> >
> > - __u32 i_generation;
> > + u64 i_generation;
> >
> > #ifdef CONFIG_FSNOTIFY
> > __u32 i_fsnotify_mask; /* all events this inode cares about */
> > --
> > 1.7.7.6
>
> This patch can have several impact on other fs. Only to do an example
> you can see the code in ioctl of ext4. I haven't got study the code
> but the ioctl returns a long, but on 32bit system, long means 4 bytes,
> so how we can return i_generation with ioctl?
So looking through everybody I'd have to convert a bunch of cpu_to_le32 to
(u32)cpu_to_le64 and some other such crap which I'm not terribly interested in
doing, I don't care _that_ much about saving 8 bytes, so I'll just drop this for
now. Thanks,
Josef
--
To unsubscribe from this list: send the line "unsubscribe linux-btrfs" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
^ permalink raw reply [flat|nested] 10+ messages in thread