* [PATCH] sparc64: Fix bootup crash on sun4v.
@ 2012-04-13 19:01 David Miller
2012-04-13 21:41 ` Sam Ravnborg
2012-04-13 21:53 ` David Miller
0 siblings, 2 replies; 3+ messages in thread
From: David Miller @ 2012-04-13 19:01 UTC (permalink / raw)
To: sparclinux
The DS driver registers as a subsys_initcall() but this can be too
early, in particular this risks registering before we've had a chance
to allocate and setup module_kset in kernel/params.c which is
performed also as a subsyts_initcall().
Register DS using device_initcall() insteal.
Signed-off-by: David S. Miller <davem@davemloft.net>
Cc: stable@vger.kernel.org
---
arch/sparc/kernel/ds.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/arch/sparc/kernel/ds.c b/arch/sparc/kernel/ds.c
index fea13c7..b93c2c9 100644
--- a/arch/sparc/kernel/ds.c
+++ b/arch/sparc/kernel/ds.c
@@ -1264,4 +1264,4 @@ static int __init ds_init(void)
return vio_register_driver(&ds_driver);
}
-subsys_initcall(ds_init);
+fs_initcall(ds_init);
--
1.7.9.5
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] sparc64: Fix bootup crash on sun4v.
2012-04-13 19:01 [PATCH] sparc64: Fix bootup crash on sun4v David Miller
@ 2012-04-13 21:41 ` Sam Ravnborg
2012-04-13 21:53 ` David Miller
1 sibling, 0 replies; 3+ messages in thread
From: Sam Ravnborg @ 2012-04-13 21:41 UTC (permalink / raw)
To: sparclinux
On Fri, Apr 13, 2012 at 03:01:26PM -0400, David Miller wrote:
>
>
> Register DS using device_initcall() insteal.
>
> -subsys_initcall(ds_init);
> +fs_initcall(ds_init);
Changelog and patch does not match?!?
Sam
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] sparc64: Fix bootup crash on sun4v.
2012-04-13 19:01 [PATCH] sparc64: Fix bootup crash on sun4v David Miller
2012-04-13 21:41 ` Sam Ravnborg
@ 2012-04-13 21:53 ` David Miller
1 sibling, 0 replies; 3+ messages in thread
From: David Miller @ 2012-04-13 21:53 UTC (permalink / raw)
To: sparclinux
From: Sam Ravnborg <sam@ravnborg.org>
Date: Fri, 13 Apr 2012 23:41:36 +0200
> On Fri, Apr 13, 2012 at 03:01:26PM -0400, David Miller wrote:
>>
>>
>> Register DS using device_initcall() insteal.
>>
>> -subsys_initcall(ds_init);
>> +fs_initcall(ds_init);
>
> Changelog and patch does not match?!?
Grrr... good catch.
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2012-04-13 21:53 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2012-04-13 19:01 [PATCH] sparc64: Fix bootup crash on sun4v David Miller
2012-04-13 21:41 ` Sam Ravnborg
2012-04-13 21:53 ` David Miller
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.