From: Mark Brown <broonie@opensource.wolfsonmicro.com>
To: Jesper Juhl <jj@chaosbits.net>
Cc: linux-kernel@vger.kernel.org, alsa-devel@alsa-project.org,
Vinod Koul <vinod.koul@linux.intel.com>,
Lars-Peter Clausen <lars@metafoo.de>,
Brian Austin <brian.austin@cirrus.com>,
Axel Lin <axel.lin@gmail.com>, Takashi Iwai <tiwai@suse.de>,
Jaroslav Kysela <perex@perex.cz>, Liam Girdwood <lrg@ti.com>,
joe@nucleusys.com
Subject: Re: [PATCH] ASoC: cs42l73: don't use negative array index
Date: Fri, 13 Apr 2012 10:02:00 +0100 [thread overview]
Message-ID: <20120413090200.GI3168@opensource.wolfsonmicro.com> (raw)
In-Reply-To: <alpine.LNX.2.00.1204122152340.7553@swampdragon.chaosbits.net>
[-- Attachment #1: Type: text/plain, Size: 301 bytes --]
On Thu, Apr 12, 2012 at 09:54:34PM +0200, Jesper Juhl wrote:
> If cs42l73_get_mclkx_coeff() returns < 0 (which it can) in
> sound/soc/codecs/cs42l73.c::cs42l73_set_mclk(), then we'll be using
> the (negative) return value as array index on the very next line of
> code - that's bad.
Applied, thanks.
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 836 bytes --]
WARNING: multiple messages have this Message-ID (diff)
From: Mark Brown <broonie@opensource.wolfsonmicro.com>
To: Jesper Juhl <jj@chaosbits.net>
Cc: Brian Austin <brian.austin@cirrus.com>,
Lars-Peter Clausen <lars@metafoo.de>,
Vinod Koul <vinod.koul@linux.intel.com>,
joe@nucleusys.com, Takashi Iwai <tiwai@suse.de>,
alsa-devel@alsa-project.org, linux-kernel@vger.kernel.org,
Axel Lin <axel.lin@gmail.com>, Liam Girdwood <lrg@ti.com>
Subject: Re: [PATCH] ASoC: cs42l73: don't use negative array index
Date: Fri, 13 Apr 2012 10:02:00 +0100 [thread overview]
Message-ID: <20120413090200.GI3168@opensource.wolfsonmicro.com> (raw)
In-Reply-To: <alpine.LNX.2.00.1204122152340.7553@swampdragon.chaosbits.net>
[-- Attachment #1.1: Type: text/plain, Size: 301 bytes --]
On Thu, Apr 12, 2012 at 09:54:34PM +0200, Jesper Juhl wrote:
> If cs42l73_get_mclkx_coeff() returns < 0 (which it can) in
> sound/soc/codecs/cs42l73.c::cs42l73_set_mclk(), then we'll be using
> the (negative) return value as array index on the very next line of
> code - that's bad.
Applied, thanks.
[-- Attachment #1.2: Digital signature --]
[-- Type: application/pgp-signature, Size: 836 bytes --]
[-- Attachment #2: Type: text/plain, Size: 0 bytes --]
next prev parent reply other threads:[~2012-04-13 9:02 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-04-12 19:54 [PATCH] ASoC: cs42l73: don't use negative array index Jesper Juhl
2012-04-12 19:54 ` Jesper Juhl
2012-04-13 9:02 ` Mark Brown [this message]
2012-04-13 9:02 ` Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120413090200.GI3168@opensource.wolfsonmicro.com \
--to=broonie@opensource.wolfsonmicro.com \
--cc=alsa-devel@alsa-project.org \
--cc=axel.lin@gmail.com \
--cc=brian.austin@cirrus.com \
--cc=jj@chaosbits.net \
--cc=joe@nucleusys.com \
--cc=lars@metafoo.de \
--cc=linux-kernel@vger.kernel.org \
--cc=lrg@ti.com \
--cc=perex@perex.cz \
--cc=tiwai@suse.de \
--cc=vinod.koul@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.