* [PATCH] arm: msm: trout: fix compile failure
@ 2012-04-12 15:45 ` Daniel Walker
0 siblings, 0 replies; 8+ messages in thread
From: Daniel Walker @ 2012-04-12 15:45 UTC (permalink / raw)
To: David Brown
Cc: Daniel Walker, David Howells, Bryan Huntsman, linux-arm-msm,
linux-arm-kernel
Fixes the following warnings,
arch/arm/mach-msm/board-trout.c: In function 'trout_init':
arch/arm/mach-msm/board-trout.c:71: error: 'system_rev' undeclared (first use in this function)
arch/arm/mach-msm/board-trout.c:71: error: (Each undeclared identifier is reported only once
arch/arm/mach-msm/board-trout.c:71: error: for each function it appears in.)
and
arch/arm/mach-msm/board-trout-panel.c: In function 'trout_init_panel':
arch/arm/mach-msm/board-trout-panel.c:267: error: 'system_rev' undeclared (first use in this function)
arch/arm/mach-msm/board-trout-panel.c:267: error: (Each undeclared identifier is reported only once
arch/arm/mach-msm/board-trout-panel.c:267: error: for each function it appears in.)
This came in with the following commit 9f97da78bf018206fb623cd351d454af2f105fe0
which removes asm/system.h
Signed-off-by: Daniel Walker <dwalker@fifo99.com>
cc: David Howells <dhowells@redhat.com>
cc: Bryan Huntsman <bryanh@codeaurora.org>
cc: linux-arm-msm@vger.kernel.org
cc: linux-arm-kernel@lists.infradead.org
---
arch/arm/mach-msm/board-trout-panel.c | 1 +
arch/arm/mach-msm/board-trout.c | 1 +
2 files changed, 2 insertions(+)
diff --git a/arch/arm/mach-msm/board-trout-panel.c b/arch/arm/mach-msm/board-trout-panel.c
index 25105c1..89bf6b4 100644
--- a/arch/arm/mach-msm/board-trout-panel.c
+++ b/arch/arm/mach-msm/board-trout-panel.c
@@ -12,6 +12,7 @@
#include <asm/io.h>
#include <asm/mach-types.h>
+#include <asm/system_info.h>
#include <mach/msm_fb.h>
#include <mach/vreg.h>
diff --git a/arch/arm/mach-msm/board-trout.c b/arch/arm/mach-msm/board-trout.c
index 5414f76..d4060a3 100644
--- a/arch/arm/mach-msm/board-trout.c
+++ b/arch/arm/mach-msm/board-trout.c
@@ -19,6 +19,7 @@
#include <linux/platform_device.h>
#include <linux/clkdev.h>
+#include <asm/system_info.h>
#include <asm/mach-types.h>
#include <asm/mach/arch.h>
#include <asm/mach/map.h>
--
1.7.10.130.g36e6c
^ permalink raw reply related [flat|nested] 8+ messages in thread
* [PATCH] arm: msm: trout: fix compile failure
@ 2012-04-12 15:45 ` Daniel Walker
0 siblings, 0 replies; 8+ messages in thread
From: Daniel Walker @ 2012-04-12 15:45 UTC (permalink / raw)
To: linux-arm-kernel
Fixes the following warnings,
arch/arm/mach-msm/board-trout.c: In function 'trout_init':
arch/arm/mach-msm/board-trout.c:71: error: 'system_rev' undeclared (first use in this function)
arch/arm/mach-msm/board-trout.c:71: error: (Each undeclared identifier is reported only once
arch/arm/mach-msm/board-trout.c:71: error: for each function it appears in.)
and
arch/arm/mach-msm/board-trout-panel.c: In function 'trout_init_panel':
arch/arm/mach-msm/board-trout-panel.c:267: error: 'system_rev' undeclared (first use in this function)
arch/arm/mach-msm/board-trout-panel.c:267: error: (Each undeclared identifier is reported only once
arch/arm/mach-msm/board-trout-panel.c:267: error: for each function it appears in.)
This came in with the following commit 9f97da78bf018206fb623cd351d454af2f105fe0
which removes asm/system.h
Signed-off-by: Daniel Walker <dwalker@fifo99.com>
cc: David Howells <dhowells@redhat.com>
cc: Bryan Huntsman <bryanh@codeaurora.org>
cc: linux-arm-msm at vger.kernel.org
cc: linux-arm-kernel at lists.infradead.org
---
arch/arm/mach-msm/board-trout-panel.c | 1 +
arch/arm/mach-msm/board-trout.c | 1 +
2 files changed, 2 insertions(+)
diff --git a/arch/arm/mach-msm/board-trout-panel.c b/arch/arm/mach-msm/board-trout-panel.c
index 25105c1..89bf6b4 100644
--- a/arch/arm/mach-msm/board-trout-panel.c
+++ b/arch/arm/mach-msm/board-trout-panel.c
@@ -12,6 +12,7 @@
#include <asm/io.h>
#include <asm/mach-types.h>
+#include <asm/system_info.h>
#include <mach/msm_fb.h>
#include <mach/vreg.h>
diff --git a/arch/arm/mach-msm/board-trout.c b/arch/arm/mach-msm/board-trout.c
index 5414f76..d4060a3 100644
--- a/arch/arm/mach-msm/board-trout.c
+++ b/arch/arm/mach-msm/board-trout.c
@@ -19,6 +19,7 @@
#include <linux/platform_device.h>
#include <linux/clkdev.h>
+#include <asm/system_info.h>
#include <asm/mach-types.h>
#include <asm/mach/arch.h>
#include <asm/mach/map.h>
--
1.7.10.130.g36e6c
^ permalink raw reply related [flat|nested] 8+ messages in thread
* Re: [PATCH] arm: msm: trout: fix compile failure
2012-04-12 15:45 ` Daniel Walker
@ 2012-04-13 17:16 ` Daniel Walker
-1 siblings, 0 replies; 8+ messages in thread
From: Daniel Walker @ 2012-04-13 17:16 UTC (permalink / raw)
To: David Brown
Cc: David Howells, Bryan Huntsman, linux-arm-msm, linux-arm-kernel
On Thu, Apr 12, 2012 at 08:45:37AM -0700, Daniel Walker wrote:
> Fixes the following warnings,
>
> arch/arm/mach-msm/board-trout.c: In function 'trout_init':
> arch/arm/mach-msm/board-trout.c:71: error: 'system_rev' undeclared (first use in this function)
> arch/arm/mach-msm/board-trout.c:71: error: (Each undeclared identifier is reported only once
> arch/arm/mach-msm/board-trout.c:71: error: for each function it appears in.)
>
> and
>
> arch/arm/mach-msm/board-trout-panel.c: In function 'trout_init_panel':
> arch/arm/mach-msm/board-trout-panel.c:267: error: 'system_rev' undeclared (first use in this function)
> arch/arm/mach-msm/board-trout-panel.c:267: error: (Each undeclared identifier is reported only once
> arch/arm/mach-msm/board-trout-panel.c:267: error: for each function it appears in.)
>
This needs to go upstream ASAP ..
Daniel
^ permalink raw reply [flat|nested] 8+ messages in thread
* [PATCH] arm: msm: trout: fix compile failure
@ 2012-04-13 17:16 ` Daniel Walker
0 siblings, 0 replies; 8+ messages in thread
From: Daniel Walker @ 2012-04-13 17:16 UTC (permalink / raw)
To: linux-arm-kernel
On Thu, Apr 12, 2012 at 08:45:37AM -0700, Daniel Walker wrote:
> Fixes the following warnings,
>
> arch/arm/mach-msm/board-trout.c: In function 'trout_init':
> arch/arm/mach-msm/board-trout.c:71: error: 'system_rev' undeclared (first use in this function)
> arch/arm/mach-msm/board-trout.c:71: error: (Each undeclared identifier is reported only once
> arch/arm/mach-msm/board-trout.c:71: error: for each function it appears in.)
>
> and
>
> arch/arm/mach-msm/board-trout-panel.c: In function 'trout_init_panel':
> arch/arm/mach-msm/board-trout-panel.c:267: error: 'system_rev' undeclared (first use in this function)
> arch/arm/mach-msm/board-trout-panel.c:267: error: (Each undeclared identifier is reported only once
> arch/arm/mach-msm/board-trout-panel.c:267: error: for each function it appears in.)
>
This needs to go upstream ASAP ..
Daniel
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH] arm: msm: trout: fix compile failure
2012-04-13 17:16 ` Daniel Walker
@ 2012-04-13 17:22 ` David Brown
-1 siblings, 0 replies; 8+ messages in thread
From: David Brown @ 2012-04-13 17:22 UTC (permalink / raw)
To: Daniel Walker
Cc: David Howells, Bryan Huntsman, linux-arm-msm, linux-arm-kernel
On Fri, Apr 13, 2012 at 10:16:19AM -0700, Daniel Walker wrote:
> On Thu, Apr 12, 2012 at 08:45:37AM -0700, Daniel Walker wrote:
> > Fixes the following warnings,
> >
> > arch/arm/mach-msm/board-trout.c: In function 'trout_init':
> > arch/arm/mach-msm/board-trout.c:71: error: 'system_rev' undeclared (first use in this function)
> > arch/arm/mach-msm/board-trout.c:71: error: (Each undeclared identifier is reported only once
> > arch/arm/mach-msm/board-trout.c:71: error: for each function it appears in.)
> >
> > and
> >
> > arch/arm/mach-msm/board-trout-panel.c: In function 'trout_init_panel':
> > arch/arm/mach-msm/board-trout-panel.c:267: error: 'system_rev' undeclared (first use in this function)
> > arch/arm/mach-msm/board-trout-panel.c:267: error: (Each undeclared identifier is reported only once
> > arch/arm/mach-msm/board-trout-panel.c:267: error: for each function it appears in.)
> >
>
> This needs to go upstream ASAP ..
I was going to send out a pull request today.
David
--
Sent by an employee of the Qualcomm Innovation Center, Inc.
The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum.
^ permalink raw reply [flat|nested] 8+ messages in thread
* [PATCH] arm: msm: trout: fix compile failure
@ 2012-04-13 17:22 ` David Brown
0 siblings, 0 replies; 8+ messages in thread
From: David Brown @ 2012-04-13 17:22 UTC (permalink / raw)
To: linux-arm-kernel
On Fri, Apr 13, 2012 at 10:16:19AM -0700, Daniel Walker wrote:
> On Thu, Apr 12, 2012 at 08:45:37AM -0700, Daniel Walker wrote:
> > Fixes the following warnings,
> >
> > arch/arm/mach-msm/board-trout.c: In function 'trout_init':
> > arch/arm/mach-msm/board-trout.c:71: error: 'system_rev' undeclared (first use in this function)
> > arch/arm/mach-msm/board-trout.c:71: error: (Each undeclared identifier is reported only once
> > arch/arm/mach-msm/board-trout.c:71: error: for each function it appears in.)
> >
> > and
> >
> > arch/arm/mach-msm/board-trout-panel.c: In function 'trout_init_panel':
> > arch/arm/mach-msm/board-trout-panel.c:267: error: 'system_rev' undeclared (first use in this function)
> > arch/arm/mach-msm/board-trout-panel.c:267: error: (Each undeclared identifier is reported only once
> > arch/arm/mach-msm/board-trout-panel.c:267: error: for each function it appears in.)
> >
>
> This needs to go upstream ASAP ..
I was going to send out a pull request today.
David
--
Sent by an employee of the Qualcomm Innovation Center, Inc.
The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum.
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH] arm: msm: trout: fix compile failure
2012-04-12 15:45 ` Daniel Walker
@ 2012-04-16 8:35 ` David Howells
-1 siblings, 0 replies; 8+ messages in thread
From: David Howells @ 2012-04-16 8:35 UTC (permalink / raw)
To: Daniel Walker
Cc: dhowells, David Brown, Bryan Huntsman, linux-arm-msm, linux-arm-kernel
Daniel Walker <dwalker@fifo99.com> wrote:
> Fixes the following warnings,
>
> arch/arm/mach-msm/board-trout.c: In function 'trout_init':
> arch/arm/mach-msm/board-trout.c:71: error: 'system_rev' undeclared (first use in this function)
> arch/arm/mach-msm/board-trout.c:71: error: (Each undeclared identifier is reported only once
> arch/arm/mach-msm/board-trout.c:71: error: for each function it appears in.)
>
> and
>
> arch/arm/mach-msm/board-trout-panel.c: In function 'trout_init_panel':
> arch/arm/mach-msm/board-trout-panel.c:267: error: 'system_rev' undeclared (first use in this function)
> arch/arm/mach-msm/board-trout-panel.c:267: error: (Each undeclared identifier is reported only once
> arch/arm/mach-msm/board-trout-panel.c:267: error: for each function it appears in.)
>
> This came in with the following commit 9f97da78bf018206fb623cd351d454af2f105fe0
> which removes asm/system.h
>
> Signed-off-by: Daniel Walker <dwalker@fifo99.com>
> cc: David Howells <dhowells@redhat.com>
> cc: Bryan Huntsman <bryanh@codeaurora.org>
> cc: linux-arm-msm@vger.kernel.org
> cc: linux-arm-kernel@lists.infradead.org
Acked-by: David Howells <dhowells@redhat.com>
^ permalink raw reply [flat|nested] 8+ messages in thread
* [PATCH] arm: msm: trout: fix compile failure
@ 2012-04-16 8:35 ` David Howells
0 siblings, 0 replies; 8+ messages in thread
From: David Howells @ 2012-04-16 8:35 UTC (permalink / raw)
To: linux-arm-kernel
Daniel Walker <dwalker@fifo99.com> wrote:
> Fixes the following warnings,
>
> arch/arm/mach-msm/board-trout.c: In function 'trout_init':
> arch/arm/mach-msm/board-trout.c:71: error: 'system_rev' undeclared (first use in this function)
> arch/arm/mach-msm/board-trout.c:71: error: (Each undeclared identifier is reported only once
> arch/arm/mach-msm/board-trout.c:71: error: for each function it appears in.)
>
> and
>
> arch/arm/mach-msm/board-trout-panel.c: In function 'trout_init_panel':
> arch/arm/mach-msm/board-trout-panel.c:267: error: 'system_rev' undeclared (first use in this function)
> arch/arm/mach-msm/board-trout-panel.c:267: error: (Each undeclared identifier is reported only once
> arch/arm/mach-msm/board-trout-panel.c:267: error: for each function it appears in.)
>
> This came in with the following commit 9f97da78bf018206fb623cd351d454af2f105fe0
> which removes asm/system.h
>
> Signed-off-by: Daniel Walker <dwalker@fifo99.com>
> cc: David Howells <dhowells@redhat.com>
> cc: Bryan Huntsman <bryanh@codeaurora.org>
> cc: linux-arm-msm at vger.kernel.org
> cc: linux-arm-kernel at lists.infradead.org
Acked-by: David Howells <dhowells@redhat.com>
^ permalink raw reply [flat|nested] 8+ messages in thread
end of thread, other threads:[~2012-04-16 8:36 UTC | newest]
Thread overview: 8+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2012-04-12 15:45 [PATCH] arm: msm: trout: fix compile failure Daniel Walker
2012-04-12 15:45 ` Daniel Walker
2012-04-13 17:16 ` Daniel Walker
2012-04-13 17:16 ` Daniel Walker
2012-04-13 17:22 ` David Brown
2012-04-13 17:22 ` David Brown
2012-04-16 8:35 ` David Howells
2012-04-16 8:35 ` David Howells
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.