* [PATCH] Bluetooth: Fix missing break in hci_cmd_complete_evt
@ 2012-04-13 10:32 Szymon Janc
2012-04-13 22:08 ` Gustavo Padovan
0 siblings, 1 reply; 2+ messages in thread
From: Szymon Janc @ 2012-04-13 10:32 UTC (permalink / raw)
To: linux-bluetooth; +Cc: kanak.gupta, Szymon Janc
Command complete event for HCI_OP_USER_PASSKEY_NEG_REPLY would result
in calling handler function also for HCI_OP_LE_SET_SCAN_PARAM. This
could result in undefined behaviour.
Signed-off-by: Szymon Janc <szymon.janc@tieto.com>
---
net/bluetooth/hci_event.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/net/bluetooth/hci_event.c b/net/bluetooth/hci_event.c
index bb6d802..f8c6174 100644
--- a/net/bluetooth/hci_event.c
+++ b/net/bluetooth/hci_event.c
@@ -2344,6 +2344,7 @@ static inline void hci_cmd_complete_evt(struct hci_dev *hdev, struct sk_buff *sk
case HCI_OP_USER_PASSKEY_NEG_REPLY:
hci_cc_user_passkey_neg_reply(hdev, skb);
+ break;
case HCI_OP_LE_SET_SCAN_PARAM:
hci_cc_le_set_scan_param(hdev, skb);
--
on behalf of ST-Ericsson
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] Bluetooth: Fix missing break in hci_cmd_complete_evt
2012-04-13 10:32 [PATCH] Bluetooth: Fix missing break in hci_cmd_complete_evt Szymon Janc
@ 2012-04-13 22:08 ` Gustavo Padovan
0 siblings, 0 replies; 2+ messages in thread
From: Gustavo Padovan @ 2012-04-13 22:08 UTC (permalink / raw)
To: Szymon Janc; +Cc: linux-bluetooth, kanak.gupta
Hi Szymon,
* Szymon Janc <szymon.janc@tieto.com> [2012-04-13 12:32:42 +0200]:
> Command complete event for HCI_OP_USER_PASSKEY_NEG_REPLY would result
> in calling handler function also for HCI_OP_LE_SET_SCAN_PARAM. This
> could result in undefined behaviour.
>
> Signed-off-by: Szymon Janc <szymon.janc@tieto.com>
> ---
> net/bluetooth/hci_event.c | 1 +
> 1 file changed, 1 insertion(+)
Applied to both bluetooth and bluetooth-next trees. Thanks.
Gustavo
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2012-04-13 22:08 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2012-04-13 10:32 [PATCH] Bluetooth: Fix missing break in hci_cmd_complete_evt Szymon Janc
2012-04-13 22:08 ` Gustavo Padovan
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.