All of lore.kernel.org
 help / color / mirror / Atom feed
From: Jeff King <peff@peff.net>
To: Marc Branchaud <marcnarc@xiplink.com>
Cc: Junio C Hamano <gitster@pobox.com>,
	Jonathan Nieder <jrnieder@gmail.com>,
	git@vger.kernel.org
Subject: Re: [PATCHv2] fetch: Only call a new ref a "branch" if it's under refs/heads/.
Date: Mon, 16 Apr 2012 11:00:36 -0400	[thread overview]
Message-ID: <20120416150036.GA15009@sigill.intra.peff.net> (raw)
In-Reply-To: <4F8C338D.1050805@xiplink.com>

On Mon, Apr 16, 2012 at 10:58:21AM -0400, Marc Branchaud wrote:

> Git is better off describing what's appeared in the remote repo, and not
> worrying about describing how the user might've mapped those things to local
> refs.

That's my preference, as well, so it sounds like you, Junio, and I are
all in agreement.

> (That said, patching fetch.c to do that is a bit beyond me at the moment.
> Where would I find the remote's name for the ref?)

During transfer operations, the remote side of the pair is generally
pointed to by the peer_ref member of "struct ref" (so just use
"ref->peer_ref->name" instead of "ref->name").

-Peff

  reply	other threads:[~2012-04-16 15:00 UTC|newest]

Thread overview: 27+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-04-13 17:08 [PATCHv2] fetch: Only call a new ref a "branch" if it's under refs/heads/ marcnarc
2012-04-13 20:07 ` Jonathan Nieder
2012-04-16 14:26   ` Marc Branchaud
2012-04-13 21:13 ` Jeff King
2012-04-13 21:53   ` Jonathan Nieder
2012-04-13 22:39     ` Junio C Hamano
2012-04-16 14:58       ` Marc Branchaud
2012-04-16 15:00         ` Jeff King [this message]
2012-04-16 15:52           ` [PATCHv3] fetch: Use the remote's ref name to decide how to describe new refs marcnarc
2012-04-16 16:10             ` Jonathan Nieder
2012-04-16 17:59             ` Junio C Hamano
2012-04-16 20:21             ` Marc Branchaud
2012-04-16 22:08             ` [PATCHv4 0/3] fetch: Only call a new ref a "branch" if it's under refs/heads/ marcnarc
2012-04-16 22:08               ` [PATCH 1/3] submodules: recursive fetch also checks new tags for submodule commits marcnarc
2012-04-16 22:08               ` [PATCH 2/3] fetch: Pass both the full remote ref and its short name to update_local_ref() marcnarc
2012-04-16 22:08               ` [PATCH 3/3] fetch: Use the remote's ref name to decide how to describe new refs marcnarc
2012-04-16 22:34                 ` Jonathan Nieder
2012-04-17  7:53                   ` Zbigniew Jędrzejewski-Szmek
2012-04-17  7:57                     ` Jonathan Nieder
2012-04-17  8:39                       ` Zbigniew Jędrzejewski-Szmek
2012-04-17 14:23                     ` Marc Branchaud
2012-04-17 15:18                       ` Jonathan Nieder
2012-04-17 15:26               ` [PATCHv4 0/3] fetch: Only call a new ref a "branch" if it's under refs/heads/ Junio C Hamano
2012-04-17 15:28                 ` Junio C Hamano
2012-04-17 19:30                 ` Marc Branchaud
2012-04-17 22:29               ` Jeff King
2012-04-16 16:08           ` [PATCHv2] " Jonathan Nieder

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20120416150036.GA15009@sigill.intra.peff.net \
    --to=peff@peff.net \
    --cc=git@vger.kernel.org \
    --cc=gitster@pobox.com \
    --cc=jrnieder@gmail.com \
    --cc=marcnarc@xiplink.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.