Re: [PATCH i18n 01/11] Add three convenient format printing functions with \n automatically appended

From: Jonathan Nieder <jrnieder@gmail.com>
To: "Nguyễn Thái Ngọc Duy" <pclouds@gmail.com>
Cc: git@vger.kernel.org, "Ævar Arnfjörð" <avarab@gmail.com>,
	"Jiang Xin" <worldhello.net@gmail.com>
Subject: Re: [PATCH i18n 01/11] Add three convenient format printing functions with \n automatically appended
Date: Mon, 16 Apr 2012 12:26:54 -0500	[thread overview]
Message-ID: <20120416172654.GU5813@burratino> (raw)
In-Reply-To: <1334580603-11577-2-git-send-email-pclouds@gmail.com>

Nguyễn Thái Ngọc Duy wrote:

>     printf("hello world\n");
>
> can be converted to
>
>     printf_ln(_("hello world"));

Fun.

[...]
> --- a/strbuf.c
> +++ b/strbuf.c
> @@ -464,3 +464,36 @@ void strbuf_addstr_urlencode(struct strbuf *sb, const char *s,
[...]
> +int printf_ln(const char *fmt, ...)
> +{
> +	int ret;
> +	va_list ap;
> +	va_start(ap, fmt);
> +	ret = vprintf(fmt, ap);
> +	va_end(ap);
> +	if (ret >= 0)
> +		ret += printf("\n");

What happens if the second printf fails?