* [patch] debugobjects: fill_pool() returns void now
@ 2012-04-18 11:28 ` Dan Carpenter
0 siblings, 0 replies; 3+ messages in thread
From: Dan Carpenter @ 2012-04-18 11:28 UTC (permalink / raw)
To: Thomas Gleixner; +Cc: Andrew Morton, linux-kernel, kernel-janitors
There was a return missed in 1fda107d44 "debugobjects: Remove unused
return value from fill_pool()". It makes gcc complain:
lib/debugobjects.c: In function ‘fill_pool’:
lib/debugobjects.c:98:4: warning: ‘return’ with a value, in
function returning void [enabled by default]
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
diff --git a/lib/debugobjects.c b/lib/debugobjects.c
index 1b6c00a..d11808c 100644
--- a/lib/debugobjects.c
+++ b/lib/debugobjects.c
@@ -95,7 +95,7 @@ static void fill_pool(void)
new = kmem_cache_zalloc(obj_cache, gfp);
if (!new)
- return obj_pool_free;
+ return;
raw_spin_lock_irqsave(&pool_lock, flags);
hlist_add_head(&new->node, &obj_pool);
^ permalink raw reply related [flat|nested] 3+ messages in thread
* [patch] debugobjects: fill_pool() returns void now
@ 2012-04-18 11:28 ` Dan Carpenter
0 siblings, 0 replies; 3+ messages in thread
From: Dan Carpenter @ 2012-04-18 11:28 UTC (permalink / raw)
To: Thomas Gleixner; +Cc: Andrew Morton, linux-kernel, kernel-janitors
There was a return missed in 1fda107d44 "debugobjects: Remove unused
return value from fill_pool()". It makes gcc complain:
lib/debugobjects.c: In function ‘fill_pool’:
lib/debugobjects.c:98:4: warning: ‘return’ with a value, in
function returning void [enabled by default]
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
diff --git a/lib/debugobjects.c b/lib/debugobjects.c
index 1b6c00a..d11808c 100644
--- a/lib/debugobjects.c
+++ b/lib/debugobjects.c
@@ -95,7 +95,7 @@ static void fill_pool(void)
new = kmem_cache_zalloc(obj_cache, gfp);
if (!new)
- return obj_pool_free;
+ return;
raw_spin_lock_irqsave(&pool_lock, flags);
hlist_add_head(&new->node, &obj_pool);
^ permalink raw reply related [flat|nested] 3+ messages in thread
* [tip:core/debugobjects] debugobjects: Fill_pool() returns void now
2012-04-18 11:28 ` Dan Carpenter
(?)
@ 2012-04-18 11:49 ` tip-bot for Dan Carpenter
-1 siblings, 0 replies; 3+ messages in thread
From: tip-bot for Dan Carpenter @ 2012-04-18 11:49 UTC (permalink / raw)
To: linux-tip-commits; +Cc: linux-kernel, hpa, mingo, tglx, dan.carpenter
Commit-ID: 3340808cf04faad7b87d6c6e13800825e5552b51
Gitweb: http://git.kernel.org/tip/3340808cf04faad7b87d6c6e13800825e5552b51
Author: Dan Carpenter <dan.carpenter@oracle.com>
AuthorDate: Wed, 18 Apr 2012 14:28:10 +0300
Committer: Thomas Gleixner <tglx@linutronix.de>
CommitDate: Wed, 18 Apr 2012 13:38:48 +0200
debugobjects: Fill_pool() returns void now
There was a return missed in 1fda107d44 "debugobjects: Remove unused
return value from fill_pool()". It makes gcc complain:
lib/debugobjects.c: In function ‘fill_pool’:
lib/debugobjects.c:98:4: warning: ‘return’ with a value, in
function returning void [enabled by default]
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Link: http://lkml.kernel.org/r/20120418112810.GA2669@elgon.mountain
Signed-off-by: Thomas Gleixner <tglx@linutronix.de>
---
lib/debugobjects.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/lib/debugobjects.c b/lib/debugobjects.c
index 1b6c00a..d11808c 100644
--- a/lib/debugobjects.c
+++ b/lib/debugobjects.c
@@ -95,7 +95,7 @@ static void fill_pool(void)
new = kmem_cache_zalloc(obj_cache, gfp);
if (!new)
- return obj_pool_free;
+ return;
raw_spin_lock_irqsave(&pool_lock, flags);
hlist_add_head(&new->node, &obj_pool);
^ permalink raw reply related [flat|nested] 3+ messages in thread
end of thread, other threads:[~2012-04-18 11:50 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2012-04-18 11:28 [patch] debugobjects: fill_pool() returns void now Dan Carpenter
2012-04-18 11:28 ` Dan Carpenter
2012-04-18 11:49 ` [tip:core/debugobjects] debugobjects: Fill_pool() " tip-bot for Dan Carpenter
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.