All of lore.kernel.org
 help / color / mirror / Atom feed
From: Shawn Guo <shawn.guo@linaro.org>
To: Wolfram Sang <w.sang@pengutronix.de>
Cc: Dong Aisheng <aisheng.dong@freescale.com>,
	Huang Shijie <b32955@freescale.com>,
	linux-arm-kernel@lists.infradead.org,
	linux-kernel@vger.kernel.org, Arnd Bergmann <arnd@arndb.de>
Subject: Re: [PATCH V2 1/3] lib: add support for stmp-style devices
Date: Fri, 20 Apr 2012 13:30:17 +0800	[thread overview]
Message-ID: <20120420053014.GK22219@S2101-09.ap.freescale.net> (raw)
In-Reply-To: <20120418092019.GB2232@pengutronix.de>

On Wed, Apr 18, 2012 at 11:20:19AM +0200, Wolfram Sang wrote:
> > If not, i guess include/linux/fsl which already exists may be the
> > right place.
> 
> Which is a bad choice in my book. linux/dma would have been the proper
> thing for mxs-dma.h, I'd think.
> 
If it already exists, it will be the proper place.  We do not want to
be too invasive to create folders in include/linux for every subsystem
for only the need of fsl drivers.

On the other hand, I have seen a clear need for include/linux/fsl.
The following files are all good candidates to be moved there.

  include/linux/fsl_devices.h
  include/linux/fsl-diu-fb.h
  include/linux/fsl_hypervisor.h

IMO, include/linux/stmp_device.h is just another good candidate.

Oh, today I was asked by Fabio where is the good place for ssp-regs.h
which will be shared by mxs-mmc and spi-mxs, as we are cleaning up
<mach/*> from drivers.  I told him include/linux/fsl.

-- 
Regards,
Shawn

WARNING: multiple messages have this Message-ID (diff)
From: shawn.guo@linaro.org (Shawn Guo)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH V2 1/3] lib: add support for stmp-style devices
Date: Fri, 20 Apr 2012 13:30:17 +0800	[thread overview]
Message-ID: <20120420053014.GK22219@S2101-09.ap.freescale.net> (raw)
In-Reply-To: <20120418092019.GB2232@pengutronix.de>

On Wed, Apr 18, 2012 at 11:20:19AM +0200, Wolfram Sang wrote:
> > If not, i guess include/linux/fsl which already exists may be the
> > right place.
> 
> Which is a bad choice in my book. linux/dma would have been the proper
> thing for mxs-dma.h, I'd think.
> 
If it already exists, it will be the proper place.  We do not want to
be too invasive to create folders in include/linux for every subsystem
for only the need of fsl drivers.

On the other hand, I have seen a clear need for include/linux/fsl.
The following files are all good candidates to be moved there.

  include/linux/fsl_devices.h
  include/linux/fsl-diu-fb.h
  include/linux/fsl_hypervisor.h

IMO, include/linux/stmp_device.h is just another good candidate.

Oh, today I was asked by Fabio where is the good place for ssp-regs.h
which will be shared by mxs-mmc and spi-mxs, as we are cleaning up
<mach/*> from drivers.  I told him include/linux/fsl.

-- 
Regards,
Shawn

  parent reply	other threads:[~2012-04-20  5:29 UTC|newest]

Thread overview: 44+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-03-21 22:21 [PATCH V2 0/3] introduce stmp-style devices Wolfram Sang
2012-03-21 22:21 ` Wolfram Sang
2012-03-21 22:21 ` [PATCH V2 1/3] lib: add support for " Wolfram Sang
2012-03-21 22:21   ` Wolfram Sang
2012-03-29  2:45   ` Huang Shijie
2012-03-29  2:45     ` Huang Shijie
2012-03-29  6:43     ` Wolfram Sang
2012-03-29  6:43       ` Wolfram Sang
2012-04-18  9:05       ` Dong Aisheng
2012-04-18  9:05         ` Dong Aisheng
2012-04-18  9:20         ` Wolfram Sang
2012-04-18  9:20           ` Wolfram Sang
2012-04-19 16:24           ` Arnd Bergmann
2012-04-19 16:24             ` Arnd Bergmann
2012-04-20  5:30           ` Shawn Guo [this message]
2012-04-20  5:30             ` Shawn Guo
2012-04-20 21:11             ` Wolfram Sang
2012-04-20 21:11               ` Wolfram Sang
2012-04-21 11:09               ` Arnd Bergmann
2012-04-21 11:09                 ` Arnd Bergmann
2012-04-04 11:21   ` Huang Shijie
2012-04-04 11:21     ` Huang Shijie
2012-04-04 12:23     ` Wolfram Sang
2012-04-04 12:23       ` Wolfram Sang
2012-04-06  7:40       ` Huang Shijie
2012-04-06  7:40         ` Huang Shijie
2012-04-06 18:21         ` Wolfram Sang
2012-04-06 18:21           ` Wolfram Sang
2012-04-07  2:30           ` Huang Shijie
2012-04-07  2:30             ` Huang Shijie
2012-04-07  8:00             ` Wolfram Sang
2012-04-07  8:00               ` Wolfram Sang
2012-04-07 13:45               ` Huang Shijie
2012-04-07 13:45                 ` Huang Shijie
2012-04-23  6:55   ` Andrew Morton
2012-04-23  6:55     ` Andrew Morton
2012-04-23  7:28     ` Wolfram Sang
2012-04-23  7:28       ` Wolfram Sang
2012-04-23 11:06       ` Arnd Bergmann
2012-04-23 11:06         ` Arnd Bergmann
2012-03-21 22:21 ` [PATCH 2/3] i2c: mxs: use global reset function Wolfram Sang
2012-03-21 22:21   ` Wolfram Sang
2012-03-21 22:21 ` [PATCH 3/3] rtc: stmp3xxx: use global stmp_device functionality Wolfram Sang
2012-03-21 22:21   ` Wolfram Sang

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20120420053014.GK22219@S2101-09.ap.freescale.net \
    --to=shawn.guo@linaro.org \
    --cc=aisheng.dong@freescale.com \
    --cc=arnd@arndb.de \
    --cc=b32955@freescale.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=w.sang@pengutronix.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.