All of lore.kernel.org
 help / color / mirror / Atom feed
* [patch] Yama: remove an unused variable
@ 2012-04-20 13:35 Dan Carpenter
  2012-04-20 17:58 ` Kees Cook
  2012-04-23  7:21 ` James Morris
  0 siblings, 2 replies; 3+ messages in thread
From: Dan Carpenter @ 2012-04-20 13:35 UTC (permalink / raw)
  To: kernel-janitors

GCC complains that we don't use "one" any more after 389da25f93 "Yama:
add additional ptrace scopes".

security/yama/yama_lsm.c:322:12: warning: ‘one’ defined but not used
	[-Wunused-variable]

Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>

diff --git a/security/yama/yama_lsm.c b/security/yama/yama_lsm.c
index afb04cb..c852f74 100644
--- a/security/yama/yama_lsm.c
+++ b/security/yama/yama_lsm.c
@@ -319,7 +319,6 @@ static int yama_dointvec_minmax(struct ctl_table *table, int write,
 }
 
 static int zero;
-static int one = 1;
 static int max_scope = YAMA_SCOPE_NO_ATTACH;
 
 struct ctl_path yama_sysctl_path[] = {

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [patch] Yama: remove an unused variable
  2012-04-20 13:35 [patch] Yama: remove an unused variable Dan Carpenter
@ 2012-04-20 17:58 ` Kees Cook
  2012-04-23  7:21 ` James Morris
  1 sibling, 0 replies; 3+ messages in thread
From: Kees Cook @ 2012-04-20 17:58 UTC (permalink / raw)
  To: kernel-janitors

On Fri, Apr 20, 2012 at 6:35 AM, Dan Carpenter <dan.carpenter@oracle.com> wrote:
> GCC complains that we don't use "one" any more after 389da25f93 "Yama:
> add additional ptrace scopes".
>
> security/yama/yama_lsm.c:322:12: warning: ‘one’ defined but not used
>        [-Wunused-variable]
>
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>

Acked-by: Kees Cook <keescook@chromium.org>

Thanks for catching that! I was still building with another set of
patches that used it. Whoops! :)

-Kees

-- 
Kees Cook
Chrome OS Security
--
To unsubscribe from this list: send the line "unsubscribe kernel-janitors" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [patch] Yama: remove an unused variable
  2012-04-20 13:35 [patch] Yama: remove an unused variable Dan Carpenter
  2012-04-20 17:58 ` Kees Cook
@ 2012-04-23  7:21 ` James Morris
  1 sibling, 0 replies; 3+ messages in thread
From: James Morris @ 2012-04-23  7:21 UTC (permalink / raw)
  To: kernel-janitors

[-- Attachment #1: Type: TEXT/PLAIN, Size: 729 bytes --]

On Fri, 20 Apr 2012, Kees Cook wrote:

> On Fri, Apr 20, 2012 at 6:35 AM, Dan Carpenter <dan.carpenter@oracle.com> wrote:
> > GCC complains that we don't use "one" any more after 389da25f93 "Yama:
> > add additional ptrace scopes".
> >
> > security/yama/yama_lsm.c:322:12: warning: ?one? defined but not used
> >        [-Wunused-variable]
> >
> > Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
> 
> Acked-by: Kees Cook <keescook@chromium.org>
> 
> Thanks for catching that! I was still building with another set of
> patches that used it. Whoops! :)

Thanks, applied to
git://git.kernel.org/pub/scm/linux/kernel/git/jmorris/linux-security.git next



- James
-- 
James Morris
<jmorris@namei.org>

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2012-04-23  7:21 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2012-04-20 13:35 [patch] Yama: remove an unused variable Dan Carpenter
2012-04-20 17:58 ` Kees Cook
2012-04-23  7:21 ` James Morris

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.