* [PATCH] ks8851: Fix request_irq/free_irq mismatch
@ 2012-04-19 17:17 mjr
2012-04-19 18:13 ` Stephen Boyd
0 siblings, 1 reply; 3+ messages in thread
From: mjr @ 2012-04-19 17:17 UTC (permalink / raw)
To: sboyd; +Cc: ben, netdev, Matt Renzelmann
From: Matt Renzelmann <mjr@cs.wisc.edu>
The dev_id parameter passed to free_irq needs to match the one passed
to the corresponding request_irq.
Signed-off-by: Matt Renzelmann <mjr@cs.wisc.edu>
---
Resending -- forgot driver name in the title. Sorry about that.
drivers/net/ethernet/micrel/ks8851.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/drivers/net/ethernet/micrel/ks8851.c b/drivers/net/ethernet/micrel/ks8851.c
index e5dc075..a8b7d5b 100644
--- a/drivers/net/ethernet/micrel/ks8851.c
+++ b/drivers/net/ethernet/micrel/ks8851.c
@@ -1524,7 +1524,7 @@ static int __devinit ks8851_probe(struct spi_device *spi)
err_netdev:
- free_irq(ndev->irq, ndev);
+ free_irq(ndev->irq, ks);
err_id:
err_irq:
--
1.7.5.4
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] ks8851: Fix request_irq/free_irq mismatch
2012-04-19 17:17 [PATCH] ks8851: Fix request_irq/free_irq mismatch mjr
@ 2012-04-19 18:13 ` Stephen Boyd
2012-04-21 19:56 ` David Miller
0 siblings, 1 reply; 3+ messages in thread
From: Stephen Boyd @ 2012-04-19 18:13 UTC (permalink / raw)
To: mjr; +Cc: ben, netdev
On 04/19/12 10:17, mjr@cs.wisc.edu wrote:
> From: Matt Renzelmann <mjr@cs.wisc.edu>
>
> The dev_id parameter passed to free_irq needs to match the one passed
> to the corresponding request_irq.
>
> Signed-off-by: Matt Renzelmann <mjr@cs.wisc.edu>
Acked-by: Stephen Boyd <sboyd@codeaurora.org>
--
Sent by an employee of the Qualcomm Innovation Center, Inc.
The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum.
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] ks8851: Fix request_irq/free_irq mismatch
2012-04-19 18:13 ` Stephen Boyd
@ 2012-04-21 19:56 ` David Miller
0 siblings, 0 replies; 3+ messages in thread
From: David Miller @ 2012-04-21 19:56 UTC (permalink / raw)
To: sboyd; +Cc: mjr, ben, netdev
From: Stephen Boyd <sboyd@codeaurora.org>
Date: Thu, 19 Apr 2012 11:13:51 -0700
> On 04/19/12 10:17, mjr@cs.wisc.edu wrote:
>> From: Matt Renzelmann <mjr@cs.wisc.edu>
>>
>> The dev_id parameter passed to free_irq needs to match the one passed
>> to the corresponding request_irq.
>>
>> Signed-off-by: Matt Renzelmann <mjr@cs.wisc.edu>
>
> Acked-by: Stephen Boyd <sboyd@codeaurora.org>
Applied, thanks.
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2012-04-21 19:57 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2012-04-19 17:17 [PATCH] ks8851: Fix request_irq/free_irq mismatch mjr
2012-04-19 18:13 ` Stephen Boyd
2012-04-21 19:56 ` David Miller
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.