All of lore.kernel.org
 help / color / mirror / Atom feed
* [U-Boot] [PATCH] net: ll_temac: drop obsolete "NAMESIZE" define
@ 2012-04-10 16:20 Stephan Linz
  2012-04-10 16:26 ` Mike Frysinger
  2012-04-21 15:28 ` Wolfgang Denk
  0 siblings, 2 replies; 3+ messages in thread
From: Stephan Linz @ 2012-04-10 16:20 UTC (permalink / raw)
  To: u-boot

... after commit "net/miiphy/serial: drop duplicate NAMESIZE
define" (sha1:f6add13) was applied. The building of the new
LL TEMAC network driver fails with error below:

xilinx_ll_temac.c: In function 'xilinx_ll_temac_initialize':
xilinx_ll_temac.c:301: error: 'NAMESIZE' undeclared (first use in this function)
xilinx_ll_temac.c:301: error: (Each undeclared identifier is reported only once
xilinx_ll_temac.c:301: error: for each function it appears in.)

Signed-off-by: Stephan Linz <linz@li-pro.net>
---
 drivers/net/xilinx_ll_temac.c |    4 ++--
 1 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/net/xilinx_ll_temac.c b/drivers/net/xilinx_ll_temac.c
index 85660c0..27dafc1 100644
--- a/drivers/net/xilinx_ll_temac.c
+++ b/drivers/net/xilinx_ll_temac.c
@@ -298,9 +298,9 @@ int xilinx_ll_temac_initialize(bd_t *bis, struct ll_temac_info *devinf)
 
 	/* use given name or generate its own unique name */
 	if (devinf->devname) {
-		strncpy(dev->name, devinf->devname, NAMESIZE);
+		strncpy(dev->name, devinf->devname, sizeof(dev->name));
 	} else {
-		snprintf(dev->name, NAMESIZE, "lltemac.%lx", devinf->base_addr);
+		snprintf(dev->name, sizeof(dev->name), "lltemac.%lx", devinf->base_addr);
 		devinf->devname = dev->name;
 	}
 
-- 
1.7.0.4

^ permalink raw reply related	[flat|nested] 3+ messages in thread

* [U-Boot] [PATCH] net: ll_temac: drop obsolete "NAMESIZE" define
  2012-04-10 16:20 [U-Boot] [PATCH] net: ll_temac: drop obsolete "NAMESIZE" define Stephan Linz
@ 2012-04-10 16:26 ` Mike Frysinger
  2012-04-21 15:28 ` Wolfgang Denk
  1 sibling, 0 replies; 3+ messages in thread
From: Mike Frysinger @ 2012-04-10 16:26 UTC (permalink / raw)
  To: u-boot

On Tuesday 10 April 2012 12:20:57 Stephan Linz wrote:
> ... after commit "net/miiphy/serial: drop duplicate NAMESIZE
> define" (sha1:f6add13) was applied. The building of the new
> LL TEMAC network driver fails with error below:
> 
> xilinx_ll_temac.c: In function 'xilinx_ll_temac_initialize':
> xilinx_ll_temac.c:301: error: 'NAMESIZE' undeclared (first use in this
> function) xilinx_ll_temac.c:301: error: (Each undeclared identifier is
> reported only once xilinx_ll_temac.c:301: error: for each function it
> appears in.)

Acked-by: Mike Frysinger <vapier@gentoo.org>
-mike
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 836 bytes
Desc: This is a digitally signed message part.
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20120410/ec2d0e32/attachment.pgp>

^ permalink raw reply	[flat|nested] 3+ messages in thread

* [U-Boot] [PATCH] net: ll_temac: drop obsolete "NAMESIZE" define
  2012-04-10 16:20 [U-Boot] [PATCH] net: ll_temac: drop obsolete "NAMESIZE" define Stephan Linz
  2012-04-10 16:26 ` Mike Frysinger
@ 2012-04-21 15:28 ` Wolfgang Denk
  1 sibling, 0 replies; 3+ messages in thread
From: Wolfgang Denk @ 2012-04-21 15:28 UTC (permalink / raw)
  To: u-boot

Dear Stephan Linz,

In message <1334074857-16432-1-git-send-email-linz@li-pro.net> you wrote:
> ... after commit "net/miiphy/serial: drop duplicate NAMESIZE
> define" (sha1:f6add13) was applied. The building of the new
> LL TEMAC network driver fails with error below:
> 
> xilinx_ll_temac.c: In function 'xilinx_ll_temac_initialize':
> xilinx_ll_temac.c:301: error: 'NAMESIZE' undeclared (first use in this function)
> xilinx_ll_temac.c:301: error: (Each undeclared identifier is reported only once
> xilinx_ll_temac.c:301: error: for each function it appears in.)
> 
> Signed-off-by: Stephan Linz <linz@li-pro.net>
> ---
>  drivers/net/xilinx_ll_temac.c |    4 ++--
>  1 files changed, 2 insertions(+), 2 deletions(-)

Applied, thanks.

Best regards,

Wolfgang Denk

-- 
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
Overdrawn?  But I still have checks left!

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2012-04-21 15:28 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2012-04-10 16:20 [U-Boot] [PATCH] net: ll_temac: drop obsolete "NAMESIZE" define Stephan Linz
2012-04-10 16:26 ` Mike Frysinger
2012-04-21 15:28 ` Wolfgang Denk

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.