* [PATCH] revert: add missing va_end
@ 2012-04-21 21:15 Christian Couder
2012-04-22 5:20 ` Junio C Hamano
0 siblings, 1 reply; 2+ messages in thread
From: Christian Couder @ 2012-04-21 21:15 UTC (permalink / raw)
To: Junio C Hamano; +Cc: git, Ramkumar Ramachandra
Signed-off-by: Christian Couder <chriscool@tuxfamily.org>
---
builtin/revert.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/builtin/revert.c b/builtin/revert.c
index e6840f2..e4ed023 100644
--- a/builtin/revert.c
+++ b/builtin/revert.c
@@ -86,6 +86,7 @@ static void verify_opt_mutually_compatible(const char *me, ...)
break;
}
}
+ va_end(ap);
if (opt1 && opt2)
die(_("%s: %s cannot be used with %s"), me, opt1, opt2);
--
1.7.10.rc0.17.g74595
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] revert: add missing va_end
2012-04-21 21:15 [PATCH] revert: add missing va_end Christian Couder
@ 2012-04-22 5:20 ` Junio C Hamano
0 siblings, 0 replies; 2+ messages in thread
From: Junio C Hamano @ 2012-04-22 5:20 UTC (permalink / raw)
To: Christian Couder; +Cc: git, Ramkumar Ramachandra
Christian Couder <chriscool@tuxfamily.org> writes:
> Signed-off-by: Christian Couder <chriscool@tuxfamily.org>
> ---
> builtin/revert.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/builtin/revert.c b/builtin/revert.c
> index e6840f2..e4ed023 100644
> --- a/builtin/revert.c
> +++ b/builtin/revert.c
> @@ -86,6 +86,7 @@ static void verify_opt_mutually_compatible(const char *me, ...)
> break;
> }
> }
> + va_end(ap);
Yeah, the original from v1.7.8-rc0~141^2~2 is obviously wrong. Thanks.
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2012-04-22 5:20 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2012-04-21 21:15 [PATCH] revert: add missing va_end Christian Couder
2012-04-22 5:20 ` Junio C Hamano
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.