All of lore.kernel.org
 help / color / mirror / Atom feed
From: Wolfram Sang <w.sang@pengutronix.de>
To: Stephen Warren <swarren@wwwdotorg.org>
Cc: Grant Likely <grant.likely@secretlab.ca>,
	Rob Herring <rob.herring@calxeda.com>,
	Ben Dooks <ben-linux@fluff.org>,
	Linus Walleij <linus.walleij@linaro.org>,
	devicetree-discuss@lists.ozlabs.org, linux-i2c@vger.kernel.org,
	linux-kernel@vger.kernel.org, Stephen Warren <swarren@nvidia.com>,
	David Daney <ddaney.cavm@gmail.com>
Subject: Re: [PATCH 1/2] i2c: mux: add device tree support
Date: Mon, 23 Apr 2012 19:00:26 +0200	[thread overview]
Message-ID: <20120423170026.GG27321@pengutronix.de> (raw)
In-Reply-To: <4F957F9F.7000309@wwwdotorg.org>

[-- Attachment #1: Type: text/plain, Size: 1311 bytes --]

On Mon, Apr 23, 2012 at 10:13:19AM -0600, Stephen Warren wrote:
> On 04/23/2012 05:15 AM, Wolfram Sang wrote:
> > On Tue, Apr 17, 2012 at 12:49:04PM -0600, Stephen Warren wrote:
> >> From: Stephen Warren <swarren@nvidia.com>
> >>
> >> * Define core portions of the DT binding for I2C bus muxes.
> >> * Enhance i2c_add_mux_adapter():
> >> ** Add parameters required for DT support. Update all callers.
> >> ** Set the appropriate adap->dev.of_node for the child bus.
> >> ** Call of_i2c_register_devices() for the child bus.
> >>
> >> Signed-off-by: Stephen Warren <swarren@nvidia.com>
> > 
> > David Daney (CCed) posted another variant [1]. Just looking at the
> > patches (and not really using them), I tend to like the approach using
> > <reg> better. But I am open for discussion, so I'd appreciate your
> > feedback.
> > 
> > Regards,
> > 
> >    Wolfram
> > 
> > [1] http://lkml.org/lkml/2012/4/12/423
> 
> Ah, that does look like a reasonable binding.

May I interpret this as an ack? :)

> to be listed last in pinctrl-names (if it's listed at all). I'll update
> my patches based on that David's patch.

Thanks.

-- 
Pengutronix e.K.                           | Wolfram Sang                |
Industrial Linux Solutions                 | http://www.pengutronix.de/  |

[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 198 bytes --]

WARNING: multiple messages have this Message-ID (diff)
From: Wolfram Sang <w.sang-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org>
To: Stephen Warren <swarren-3lzwWm7+Weoh9ZMKESR00Q@public.gmane.org>
Cc: Grant Likely
	<grant.likely-s3s/WqlpOiPyB63q8FvJNQ@public.gmane.org>,
	Rob Herring <rob.herring-bsGFqQB8/DxBDgjK7y7TUQ@public.gmane.org>,
	Ben Dooks <ben-linux-elnMNo+KYs3YtjvyW6yDsg@public.gmane.org>,
	Linus Walleij
	<linus.walleij-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org>,
	devicetree-discuss-uLR06cmDAlY/bJ5BZ2RsiQ@public.gmane.org,
	linux-i2c-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
	linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
	Stephen Warren <swarren-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>,
	David Daney <ddaney.cavm-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
Subject: Re: [PATCH 1/2] i2c: mux: add device tree support
Date: Mon, 23 Apr 2012 19:00:26 +0200	[thread overview]
Message-ID: <20120423170026.GG27321@pengutronix.de> (raw)
In-Reply-To: <4F957F9F.7000309-3lzwWm7+Weoh9ZMKESR00Q@public.gmane.org>

[-- Attachment #1: Type: text/plain, Size: 1369 bytes --]

On Mon, Apr 23, 2012 at 10:13:19AM -0600, Stephen Warren wrote:
> On 04/23/2012 05:15 AM, Wolfram Sang wrote:
> > On Tue, Apr 17, 2012 at 12:49:04PM -0600, Stephen Warren wrote:
> >> From: Stephen Warren <swarren-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>
> >>
> >> * Define core portions of the DT binding for I2C bus muxes.
> >> * Enhance i2c_add_mux_adapter():
> >> ** Add parameters required for DT support. Update all callers.
> >> ** Set the appropriate adap->dev.of_node for the child bus.
> >> ** Call of_i2c_register_devices() for the child bus.
> >>
> >> Signed-off-by: Stephen Warren <swarren-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>
> > 
> > David Daney (CCed) posted another variant [1]. Just looking at the
> > patches (and not really using them), I tend to like the approach using
> > <reg> better. But I am open for discussion, so I'd appreciate your
> > feedback.
> > 
> > Regards,
> > 
> >    Wolfram
> > 
> > [1] http://lkml.org/lkml/2012/4/12/423
> 
> Ah, that does look like a reasonable binding.

May I interpret this as an ack? :)

> to be listed last in pinctrl-names (if it's listed at all). I'll update
> my patches based on that David's patch.

Thanks.

-- 
Pengutronix e.K.                           | Wolfram Sang                |
Industrial Linux Solutions                 | http://www.pengutronix.de/  |

[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 198 bytes --]

  reply	other threads:[~2012-04-23 17:00 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-04-17 18:49 [PATCH 1/2] i2c: mux: add device tree support Stephen Warren
2012-04-17 18:49 ` Stephen Warren
2012-04-17 18:49 ` [PATCH 2/2] i2c: Add generic I2C multiplexer using pinctrl API Stephen Warren
2012-04-17 18:49   ` Stephen Warren
2012-04-17 19:50   ` Linus Walleij
2012-04-17 19:50     ` Linus Walleij
2012-04-23 11:15 ` [PATCH 1/2] i2c: mux: add device tree support Wolfram Sang
2012-04-23 11:15   ` Wolfram Sang
2012-04-23 16:13   ` Stephen Warren
2012-04-23 16:13     ` Stephen Warren
2012-04-23 17:00     ` Wolfram Sang [this message]
2012-04-23 17:00       ` Wolfram Sang
2012-04-23 17:11     ` David Daney
2012-04-23 17:11       ` David Daney

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20120423170026.GG27321@pengutronix.de \
    --to=w.sang@pengutronix.de \
    --cc=ben-linux@fluff.org \
    --cc=ddaney.cavm@gmail.com \
    --cc=devicetree-discuss@lists.ozlabs.org \
    --cc=grant.likely@secretlab.ca \
    --cc=linus.walleij@linaro.org \
    --cc=linux-i2c@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=rob.herring@calxeda.com \
    --cc=swarren@nvidia.com \
    --cc=swarren@wwwdotorg.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.