All of lore.kernel.org
 help / color / mirror / Atom feed
* [U-Boot] [PATCH] EXYNOS: Change bits per pixel value proper for u-boot.
@ 2012-04-24  1:37 Donghwa Lee
  2012-04-24 11:44 ` Anatolij Gustschin
  0 siblings, 1 reply; 3+ messages in thread
From: Donghwa Lee @ 2012-04-24  1:37 UTC (permalink / raw)
  To: u-boot

vl_bpix of vidinfo_t was changed proper value for u-boot.
It is used to multiple of 2 by using NBITS() macro. 

Signed-off-by: Donghwa Lee <dh09.lee@samsung.com>
Signed-off-by: Kyungmin Park <kyungmin.park@samsung.com>
---
 board/samsung/trats/trats.c |    2 +-
 drivers/video/exynos_fb.c   |    2 +-
 drivers/video/exynos_fimd.c |    6 +++---
 3 files changed, 5 insertions(+), 5 deletions(-)

diff --git a/board/samsung/trats/trats.c b/board/samsung/trats/trats.c
index f0775fd..3085de1 100644
--- a/board/samsung/trats/trats.c
+++ b/board/samsung/trats/trats.c
@@ -467,7 +467,7 @@ void init_panel_info(vidinfo_t *vid)
 	vid->vl_vsp	= CONFIG_SYS_LOW;
 	vid->vl_dp	= CONFIG_SYS_LOW;
 
-	vid->vl_bpix	= 32;
+	vid->vl_bpix	= 5;
 	vid->dual_lcd_enabled = 0;
 
 	/* s6e8ax0 Panel */
diff --git a/drivers/video/exynos_fb.c b/drivers/video/exynos_fb.c
index 0eb7f58..a1cf449 100644
--- a/drivers/video/exynos_fb.c
+++ b/drivers/video/exynos_fb.c
@@ -52,7 +52,7 @@ static void exynos_lcd_init_mem(void *lcdbase, vidinfo_t *vid)
 	unsigned long palette_size;
 	unsigned int fb_size;
 
-	fb_size = vid->vl_row * vid->vl_col * (vid->vl_bpix >> 3);
+	fb_size = vid->vl_row * vid->vl_col * (NBITS(vid->vl_bpix) >> 3);
 
 	lcd_base = lcdbase;
 
diff --git a/drivers/video/exynos_fimd.c b/drivers/video/exynos_fimd.c
index 2a60fcf..6416b90 100644
--- a/drivers/video/exynos_fimd.c
+++ b/drivers/video/exynos_fimd.c
@@ -110,7 +110,7 @@ static void exynos_fimd_set_buffer_address(unsigned int win_id)
 		(struct exynos4_fb *)samsung_get_base_fimd();
 
 	start_addr = (unsigned long)lcd_base_addr;
-	end_addr = start_addr + ((pvid->vl_col * (pvid->vl_bpix / 8)) *
+	end_addr = start_addr + ((pvid->vl_col * (NBITS(pvid->vl_bpix) / 8)) *
 				pvid->vl_row);
 
 	writel(start_addr, (unsigned int)&fimd_ctrl->vidw00add0b0 +
@@ -331,7 +331,7 @@ void exynos_fimd_lcd_init(vidinfo_t *vid)
 	exynos_fimd_set_buffer_address(pvid->win_id);
 
 	/* set buffer size */
-	cfg = EXYNOS_VIDADDR_PAGEWIDTH(pvid->vl_col * pvid->vl_bpix / 8);
+	cfg = EXYNOS_VIDADDR_PAGEWIDTH(pvid->vl_col * NBITS(pvid->vl_bpix) / 8);
 	writel(cfg, (unsigned int)&fimd_ctrl->vidw00add2 +
 					EXYNOS_BUFFER_SIZE(pvid->win_id));
 
@@ -350,5 +350,5 @@ void exynos_fimd_lcd_init(vidinfo_t *vid)
 
 unsigned long exynos_fimd_calc_fbsize(void)
 {
-	return pvid->vl_col * pvid->vl_row * (pvid->vl_bpix / 8);
+	return pvid->vl_col * pvid->vl_row * (NBITS(pvid->vl_bpix) / 8);
 }
-- 
1.7.4.1

^ permalink raw reply related	[flat|nested] 3+ messages in thread

* [U-Boot] [PATCH] EXYNOS: Change bits per pixel value proper for u-boot.
  2012-04-24  1:37 [U-Boot] [PATCH] EXYNOS: Change bits per pixel value proper for u-boot Donghwa Lee
@ 2012-04-24 11:44 ` Anatolij Gustschin
  2012-04-25  7:50   ` Minkyu Kang
  0 siblings, 1 reply; 3+ messages in thread
From: Anatolij Gustschin @ 2012-04-24 11:44 UTC (permalink / raw)
  To: u-boot

Hi,

On Tue, 24 Apr 2012 10:37:05 +0900
Donghwa Lee <dh09.lee@samsung.com> wrote:

> vl_bpix of vidinfo_t was changed proper value for u-boot.
> It is used to multiple of 2 by using NBITS() macro. 
> 
> Signed-off-by: Donghwa Lee <dh09.lee@samsung.com>
> Signed-off-by: Kyungmin Park <kyungmin.park@samsung.com>
> ---
>  board/samsung/trats/trats.c |    2 +-
>  drivers/video/exynos_fb.c   |    2 +-
>  drivers/video/exynos_fimd.c |    6 +++---
>  3 files changed, 5 insertions(+), 5 deletions(-)

Acked-by: Anatolij Gustschin <agust@denx.de>

This patch should go through u-boot-samsung.git tree as the
other exynos_fb patches are in this tree.

Thanks,
Anatolij

^ permalink raw reply	[flat|nested] 3+ messages in thread

* [U-Boot] [PATCH] EXYNOS: Change bits per pixel value proper for u-boot.
  2012-04-24 11:44 ` Anatolij Gustschin
@ 2012-04-25  7:50   ` Minkyu Kang
  0 siblings, 0 replies; 3+ messages in thread
From: Minkyu Kang @ 2012-04-25  7:50 UTC (permalink / raw)
  To: u-boot

On 24 April 2012 20:44, Anatolij Gustschin <agust@denx.de> wrote:
> Hi,
>
> On Tue, 24 Apr 2012 10:37:05 +0900
> Donghwa Lee <dh09.lee@samsung.com> wrote:
>
>> vl_bpix of vidinfo_t was changed proper value for u-boot.
>> It is used to multiple of 2 by using NBITS() macro.
>>
>> Signed-off-by: Donghwa Lee <dh09.lee@samsung.com>
>> Signed-off-by: Kyungmin Park <kyungmin.park@samsung.com>
>> ---
>> ?board/samsung/trats/trats.c | ? ?2 +-
>> ?drivers/video/exynos_fb.c ? | ? ?2 +-
>> ?drivers/video/exynos_fimd.c | ? ?6 +++---
>> ?3 files changed, 5 insertions(+), 5 deletions(-)
>
> Acked-by: Anatolij Gustschin <agust@denx.de>
>

applied to u-boot-samsung.

Thanks
Minkyu Kang.
-- 
from. prom.
www.promsoft.net

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2012-04-25  7:50 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2012-04-24  1:37 [U-Boot] [PATCH] EXYNOS: Change bits per pixel value proper for u-boot Donghwa Lee
2012-04-24 11:44 ` Anatolij Gustschin
2012-04-25  7:50   ` Minkyu Kang

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.