All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH] media: videobuf2-dma-contig: quiet sparse noise about plain integer as NULL pointer
@ 2012-04-24 23:12 H Hartley Sweeten
  2012-04-26 14:08 ` Marek Szyprowski
  0 siblings, 1 reply; 2+ messages in thread
From: H Hartley Sweeten @ 2012-04-24 23:12 UTC (permalink / raw)
  To: Linux Kernel; +Cc: linux-media, pawel, m.szyprowski, kyungmin.park, mchehab

The function vb2_dma_contig_vaddr returns a void * not an integer.

Quiets the sparse noise:

warning: Using plain integer as NULL pointer

Signed-off-by: H Hartley Sweeten <hsweeten@visionengravers.com>
Cc: Pawel Osciak <pawel@osciak.com>
Cc: Marek Szyprowski <m.szyprowski@samsung.com>
Cc: Kyungmin Park <kyungmin.park@samsung.com>
Cc: Mauro Carvalho Chehab <mchehab@infradead.org>
---

diff --git a/drivers/media/video/videobuf2-dma-contig.c b/drivers/media/video/videobuf2-dma-contig.c
index f17ad98..7de6843 100644
--- a/drivers/media/video/videobuf2-dma-contig.c
+++ b/drivers/media/video/videobuf2-dma-contig.c
@@ -85,7 +85,7 @@ static void *vb2_dma_contig_vaddr(void *buf_priv)
 {
 	struct vb2_dc_buf *buf = buf_priv;
 	if (!buf)
-		return 0;
+		return NULL;
 
 	return buf->vaddr;
 }

^ permalink raw reply related	[flat|nested] 2+ messages in thread

* RE: [PATCH] media: videobuf2-dma-contig: quiet sparse noise about plain integer as NULL pointer
  2012-04-24 23:12 [PATCH] media: videobuf2-dma-contig: quiet sparse noise about plain integer as NULL pointer H Hartley Sweeten
@ 2012-04-26 14:08 ` Marek Szyprowski
  0 siblings, 0 replies; 2+ messages in thread
From: Marek Szyprowski @ 2012-04-26 14:08 UTC (permalink / raw)
  To: 'H Hartley Sweeten', 'Linux Kernel'
  Cc: linux-media, pawel, kyungmin.park, mchehab

Hi,

On Wednesday, April 25, 2012 1:13 AM H Hartley Sweeten wrote:
 
> The function vb2_dma_contig_vaddr returns a void * not an integer.
> 
> Quiets the sparse noise:
> 
> warning: Using plain integer as NULL pointer
> 
> Signed-off-by: H Hartley Sweeten <hsweeten@visionengravers.com>
> Cc: Pawel Osciak <pawel@osciak.com>
> Cc: Marek Szyprowski <m.szyprowski@samsung.com>
> Cc: Kyungmin Park <kyungmin.park@samsung.com>
> Cc: Mauro Carvalho Chehab <mchehab@infradead.org>

Acked-by: Marek Szyprowski <m.szyprowski@samsung.com>

> ---
> 
> diff --git a/drivers/media/video/videobuf2-dma-contig.c b/drivers/media/video/videobuf2-dma-
> contig.c
> index f17ad98..7de6843 100644
> --- a/drivers/media/video/videobuf2-dma-contig.c
> +++ b/drivers/media/video/videobuf2-dma-contig.c
> @@ -85,7 +85,7 @@ static void *vb2_dma_contig_vaddr(void *buf_priv)
>  {
>  	struct vb2_dc_buf *buf = buf_priv;
>  	if (!buf)
> -		return 0;
> +		return NULL;
> 
>  	return buf->vaddr;
>  }

Best regards
-- 
Marek Szyprowski
Samsung Poland R&D Center


^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2012-04-26 14:08 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2012-04-24 23:12 [PATCH] media: videobuf2-dma-contig: quiet sparse noise about plain integer as NULL pointer H Hartley Sweeten
2012-04-26 14:08 ` Marek Szyprowski

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.