* [PATCH] crush: include header for global symbols
@ 2012-04-25 0:38 ` H Hartley Sweeten
0 siblings, 0 replies; 3+ messages in thread
From: H Hartley Sweeten @ 2012-04-25 0:38 UTC (permalink / raw)
To: Linux Kernel; +Cc: netdev, ceph-devel, sage, davem
Include the header to pickup the definitions of the global symbols.
Quiets the following sparse warnings:
warning: symbol 'crush_find_rule' was not declared. Should it be static?
warning: symbol 'crush_do_rule' was not declared. Should it be static?
Signed-off-by: H Hartley Sweeten <hsweeten@visionengravers.com>
Cc: Sage Weil <sage@newdream.net>
Cc: "David S. Miller" <davem@davemloft.net>
---
diff --git a/net/ceph/crush/mapper.c b/net/ceph/crush/mapper.c
index 854ac53..363f8f7 100644
--- a/net/ceph/crush/mapper.c
+++ b/net/ceph/crush/mapper.c
@@ -20,6 +20,7 @@
#include <linux/crush/crush.h>
#include <linux/crush/hash.h>
+#include <linux/crush/mapper.h>
/*
* Implement the core CRUSH mapping algorithm.
^ permalink raw reply related [flat|nested] 3+ messages in thread
* [PATCH] crush: include header for global symbols
@ 2012-04-25 0:38 ` H Hartley Sweeten
0 siblings, 0 replies; 3+ messages in thread
From: H Hartley Sweeten @ 2012-04-25 0:38 UTC (permalink / raw)
To: Linux Kernel; +Cc: netdev, ceph-devel, sage, davem
Include the header to pickup the definitions of the global symbols.
Quiets the following sparse warnings:
warning: symbol 'crush_find_rule' was not declared. Should it be static?
warning: symbol 'crush_do_rule' was not declared. Should it be static?
Signed-off-by: H Hartley Sweeten <hsweeten@visionengravers.com>
Cc: Sage Weil <sage@newdream.net>
Cc: "David S. Miller" <davem@davemloft.net>
---
diff --git a/net/ceph/crush/mapper.c b/net/ceph/crush/mapper.c
index 854ac53..363f8f7 100644
--- a/net/ceph/crush/mapper.c
+++ b/net/ceph/crush/mapper.c
@@ -20,6 +20,7 @@
#include <linux/crush/crush.h>
#include <linux/crush/hash.h>
+#include <linux/crush/mapper.h>
/*
* Implement the core CRUSH mapping algorithm.
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] crush: include header for global symbols
2012-04-25 0:38 ` H Hartley Sweeten
(?)
@ 2012-04-27 4:04 ` David Miller
-1 siblings, 0 replies; 3+ messages in thread
From: David Miller @ 2012-04-27 4:04 UTC (permalink / raw)
To: hartleys; +Cc: linux-kernel, netdev, ceph-devel, sage
From: H Hartley Sweeten <hartleys@visionengravers.com>
Date: Tue, 24 Apr 2012 17:38:37 -0700
> Include the header to pickup the definitions of the global symbols.
>
> Quiets the following sparse warnings:
>
> warning: symbol 'crush_find_rule' was not declared. Should it be static?
> warning: symbol 'crush_do_rule' was not declared. Should it be static?
>
> Signed-off-by: H Hartley Sweeten <hsweeten@visionengravers.com>
Applied.
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2012-04-27 4:04 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2012-04-25 0:38 [PATCH] crush: include header for global symbols H Hartley Sweeten
2012-04-25 0:38 ` H Hartley Sweeten
2012-04-27 4:04 ` David Miller
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.