From: Eric Wong <normalperson@yhbt.net>
To: Matthijs Kooijman <matthijs@stdin.nl>
Cc: Gustav Munkby <grddev@gmail.com>,
Edward Rudd <urkle@outoforder.cc>, Carsten Bormann <cabo@tzi.org>,
git@vger.kernel.org
Subject: Re: [PATCH 1/2] git-svn: use platform specific auth providers
Date: Fri, 27 Apr 2012 08:21:18 +0000 [thread overview]
Message-ID: <20120427082118.GA7257@dcvr.yhbt.net> (raw)
In-Reply-To: <1335468843-24653-1-git-send-email-matthijs@stdin.nl>
Matthijs Kooijman <matthijs@stdin.nl> wrote:
> On Linux, this makes authentication using passwords from gnome-keyring
> and kwallet work (only the former was tested). On Mac OS X, this allows
> using the OS X Keychain.
Thanks, this looks good. Can you add a Signed-off-by? (you can just
reply here and I'll add it to the commit message when pushing.
Otherwise, consider this Acked-by: Eric Wong <normalperson@yhbt.net>
> + # earlier 1.6.x versions would segfault, and <= 1.5.x didn't have
> + # this function
> + if ($SVN::Core::VERSION gt '1.6.12') {
Thank you for documenting this segfault, btw.
next prev parent reply other threads:[~2012-04-27 8:21 UTC|newest]
Thread overview: 35+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-02-18 0:36 git-svn won't remember pem password Igor
2012-02-18 11:30 ` Jakub Narebski
2012-02-19 4:03 ` Nikolaus Demmel
2012-02-20 0:57 ` Jeff King
2012-02-20 3:08 ` Nikolaus Demmel
2012-02-19 1:30 ` Eric Wong
2012-04-26 18:00 ` Matthijs Kooijman
[not found] ` <41A093CB-CA4A-4FEF-9F5C-A9B626D10AFB@gmail.com>
[not found] ` <20120426181327.GZ4023@login.drsnuggles.stderr.nl>
2012-04-26 18:31 ` Igor
2012-04-26 18:36 ` Matthijs Kooijman
2012-04-26 19:34 ` [PATCH 1/2] git-svn: use platform specific auth providers Matthijs Kooijman
2012-04-26 19:34 ` [PATCH 2/2] git-svn: Configure a prompt callback for gnome_keyring Matthijs Kooijman
2012-04-27 8:28 ` Eric Wong
2012-04-27 9:36 ` Matthijs Kooijman
2013-06-18 16:36 ` Matthijs Kooijman
2013-06-18 16:38 ` [PATCH] " Matthijs Kooijman
2013-08-29 9:42 ` Matthijs Kooijman
2013-08-29 17:38 ` Eric Wong
[not found] ` <35AE7D09-F859-4277-AC74-729BA1188D10@outoforder.cc>
2013-08-29 17:56 ` Eric Wong
2012-04-27 8:29 ` [PATCH 2/2] " Matthijs Kooijman
2012-04-27 8:21 ` Eric Wong [this message]
2012-04-27 8:25 ` [PATCH 1/2] git-svn: use platform specific auth providers Matthijs Kooijman
2012-04-29 8:23 ` Eric Wong
2012-04-30 0:03 ` Junio C Hamano
2012-04-30 1:21 ` Junio C Hamano
2012-04-30 8:19 ` Eric Wong
2012-04-30 16:04 ` Junio C Hamano
2012-04-30 16:53 ` Matthijs Kooijman
2012-04-30 19:02 ` Eric Wong
2012-04-30 19:20 ` Matthijs Kooijman
2012-05-01 1:08 ` Junio C Hamano
2012-06-03 10:49 ` Charles Bailey
2012-06-03 21:44 ` Junio C Hamano
2012-06-04 9:00 ` Matthijs Kooijman
2012-06-04 19:26 ` Junio C Hamano
2012-06-04 19:36 ` Eric Wong
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120427082118.GA7257@dcvr.yhbt.net \
--to=normalperson@yhbt.net \
--cc=cabo@tzi.org \
--cc=git@vger.kernel.org \
--cc=grddev@gmail.com \
--cc=matthijs@stdin.nl \
--cc=urkle@outoforder.cc \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.