Re: [PATCH 2/2] git-svn: Configure a prompt callback for gnome_keyring.

From: Matthijs Kooijman <matthijs@stdin.nl>
To: Eric Wong <normalperson@yhbt.net>
Cc: Gustav Munkby <grddev@gmail.com>,
	Edward Rudd <urkle@outoforder.cc>, Carsten Bormann <cabo@tzi.org>,
	git@vger.kernel.org
Subject: Re: [PATCH 2/2] git-svn: Configure a prompt callback for gnome_keyring.
Date: Tue, 18 Jun 2013 18:36:10 +0200	[thread overview]
Message-ID: <20130618163609.GD10217@login.drsnuggles.stderr.nl> (raw)
In-Reply-To: <20120427082840.GB7257@dcvr.yhbt.net>

Hi folks,

On Fri, Apr 27, 2012 at 08:28:40AM +0000, Eric Wong wrote:
> Matthijs Kooijman <matthijs@stdin.nl> wrote:
> > This allows git-svn to prompt for a keyring unlock password, when a
> > the needed gnome keyring is locked.
> > 
> > This requires changes in the subversion perl bindings which have been
> > committed to trunk (1241554 and some followup commits) and should be
> > available with the (as of yet unreleased) 1.8.0 release.
> 
> I'm a hesitant to use/depend on unreleased functionality in SVN.
> 
> Is there a chance the API could change before the release.  Also,
> what kind of tests do the SVN guys do on the Perl bindings + GNOME?
> I'm especially concerned since we just worked around segfault
> bugs in the other patch.
> 
> Can we put this on hold until somebody can test the 1.8.0 release?

After over a year, Subversion has finally started with 1.8.0 release
candidates. I've rebased this patch and succesfully tested it against
1.8.0-rc3.

I'll send the updated patch over as a reply to this mail.

As for testing, it took a bit of messing to get all the paths correct,
so I'll document what I did here.

I used a the 1.8.0-rc3 tarball and ran:

	subversion-1.8.0-rc3$ ./configure --prefix=/usr/local/svn
	subversion-1.8.0-rc3$ make all install
	subversion-1.8.0-rc3$ make swig-pl install-swig-pl PREFIX=/usr/local/svn

I took a git master checkout with the patch applied and ran:

	git$ make prefix=/usr/local/git all install

Then, inside some git-svn clone, I ran:

	$ PERL5LIB=/usr/local/svn/local/lib/perl/5.14.2/ LD_LIBRARY_PATH=/usr/local/svn/lib/  /usr/local/git/bin/git svn rebase
	Password for 'default' GNOME keyring:
	Current branch master is up to date.

When removing the PERL5LIB and LD_LIBRARY_PATH variables to run against
the system version of subversion (1.6.17 here), I get an authorization
failure as before:

	$ /usr/local/git/bin/git svn rebase
	Authorization failed: OPTIONS of 'http://svn.example.org': authorization failed: Could not authenticate to server: rejected Basic challenge (http://example.org) at /usr/local/git/share/perl/5.14.2/Git/SVN.pm line 717

Gr.

Matthijs